-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mechanism to get blockhash queue length #10162
Add mechanism to get blockhash queue length #10162
Conversation
|
Funny thing, I'm currently improving |
c20ca6f
to
86c2132
Compare
What about returning the lifespan via |
Codecov Report
@@ Coverage Diff @@
## master #10162 +/- ##
=======================================
Coverage 81.3% 81.4%
=======================================
Files 283 283
Lines 66038 66094 +56
=======================================
+ Hits 53731 53829 +98
+ Misses 12307 12265 -42 |
Problem
It can be crucial for clients to know if a particular blockhash has expired.
getFeeCalculatorForBlockhash
offers one way to test this, but it would also be helpful for clients to be able to estimate how many slots until expiration.getRecentBlockhash
returns the slot context of the response, so clients just need the blockhash queue length to track its expiration.We may also want to be able to change how long a blockhash is valid for, most likely at epoch boundaries.
re: #10054 (comment)
Summary of Changes
getBlockhashLifespan
rpc endpoint. Response includes the relevant epoch, on the assumption that any queue-length changes will be valid for the entire epoch.getBlockhashLifespan
through clientsolana fees
, and add blockhash-lifespan info to it.