Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cli: expose last-valid-slot in solana fees #10254

Merged
merged 2 commits into from
May 26, 2020
Merged

Cli: expose last-valid-slot in solana fees #10254

merged 2 commits into from
May 26, 2020

Conversation

CriesofCarrots
Copy link
Contributor

@CriesofCarrots CriesofCarrots commented May 26, 2020 •
edited
Loading

Problem

Rpc getFees now exists and returns a blockhash with last-valid-slot information, but this info is not available in the Cli.

Summary of Changes

  • Brush up solana fees, and expose last-valid-slot
  • Also sneak in a few camelCase tags that were missing in cli_output

Useful stuff from #10162

@CriesofCarrots CriesofCarrots added v1.2 automerge Merge this Pull Request automatically once CI passes labels May 26, 2020
@solana-grimes
Copy link
Contributor

💔 Unable to automerge due to CI failure

@solana-grimes solana-grimes removed the automerge Merge this Pull Request automatically once CI passes label May 26, 2020
@codecov
Copy link

codecov bot commented May 26, 2020

Codecov Report

Merging #10254 into master will increase coverage by 0.0%.
The diff coverage is 0.0%.

@@           Coverage Diff           @@
##           master   #10254   +/-   ##
=======================================
  Coverage    81.4%    81.4%           
=======================================
  Files         288      288           
  Lines       66620    66632   +12     
=======================================
+ Hits        54281    54301   +20     
+ Misses      12339    12331    -8

@mvines mvines added the automerge Merge this Pull Request automatically once CI passes label May 26, 2020
@solana-grimes solana-grimes merged commit b6083ca into solana-labs:master May 26, 2020
mergify bot pushed a commit that referenced this pull request May 26, 2020
@CriesofCarrots
Cli: expose last-valid-slot in solana fees (#10254)
92bda62 
automerge

(cherry picked from commit b6083ca)
@mergify mergify bot mentioned this pull request May 26, 2020
Merged
CriesofCarrots added a commit that referenced this pull request May 26, 2020
@CriesofCarrots
Cli: expose last-valid-slot in solana fees (#10254)
06542ee 
automerge

(cherry picked from commit b6083ca)
CriesofCarrots added a commit that referenced this pull request May 26, 2020
@mergify @CriesofCarrots
Cli: expose last-valid-slot in solana fees (#10254) (#10256)
606a392 
automerge

(cherry picked from commit b6083ca)

Co-authored-by: Tyera Eulberg <teulberg@gmail.com>
@CriesofCarrots CriesofCarrots mentioned this pull request May 27, 2020
Closed
@CriesofCarrots CriesofCarrots deleted the cli-fees-2 branch May 28, 2020 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
automerge Merge this Pull Request automatically once CI passes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CriesofCarrots @solana-grimes @mvines