Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Use BlockCommitmentCache for RPC slots" #11122

Merged
merged 1 commit into from
Jul 18, 2020

Conversation

mvines
Copy link
Member

@mvines mvines commented Jul 18, 2020

Reverts #11103

Broke master :-/

@mvines mvines mentioned this pull request Jul 18, 2020
@codecov
Copy link

codecov bot commented Jul 18, 2020

Codecov Report

Merging #11122 into master will increase coverage by 0.0%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #11122   +/-   ##
=======================================
  Coverage    82.1%    82.1%           
=======================================
  Files         319      319           
  Lines       73471    73471           
=======================================
+ Hits        60386    60391    +5     
+ Misses      13085    13080    -5     

@carllin carllin merged commit d19cd3a into master Jul 18, 2020
@mvines mvines deleted the revert-11103-highest-descendant branch July 19, 2020 00:54
@garious
Copy link
Contributor

garious commented Jul 20, 2020

@mvines, broke master how?

@mvines
Copy link
Member Author

mvines commented Jul 20, 2020

@CriesofCarrots
Copy link
Contributor

Looks like a rebase issue wrt #11106

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants