Fix a bug in input deserialization in the C SDK #17217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the input contains more accounts than the user has requested to be deserialized, and one of the excess ones is a dup, the input pointer is not adjusted correctly. Compare the lines added by this commit to line 401: "input += 7; // padding". Since the input data layout does not depend on the number of accounts the user wants to deserialize, this adjustment by 7 bytes must happen in both branches.
|
Looks like a general problem with the pipeline, unrelated to the change. |
|
What is the unrelated issue? I'm working up a test case for this issue |
|
Ah, you are referring to CI, I kicked it |
|
lgtm, @jackcmay any concerns landing so we can get this into 1.6.9 (cc: @CriesofCarrots) |
|
I'd like to see some tests to verify it but that could follow, I have limited service today so won't get to it asap |
mergify bot
pushed a commit
that referenced
this pull request
May 14, 2021
When the input contains more accounts than the user has requested to be deserialized, and one of the excess ones is a dup, the input pointer is not adjusted correctly. Compare the lines added by this commit to line 401: "input += 7; // padding". Since the input data layout does not depend on the number of accounts the user wants to deserialize, this adjustment by 7 bytes must happen in both branches. (cherry picked from commit e02b4e1)
mergify bot
added a commit
that referenced
this pull request
May 15, 2021
When the input contains more accounts than the user has requested to be deserialized, and one of the excess ones is a dup, the input pointer is not adjusted correctly. Compare the lines added by this commit to line 401: "input += 7; // padding". Since the input data layout does not depend on the number of accounts the user wants to deserialize, this adjustment by 7 bytes must happen in both branches. (cherry picked from commit e02b4e1) Co-authored-by: Christian Machacek <39452430+machacekch@users.noreply.github.com>
jackcmay
added a commit
to jackcmay/solana
that referenced
this pull request
May 17, 2021
jackcmay
added a commit
that referenced
this pull request
May 17, 2021
jackcmay
added a commit
that referenced
this pull request
May 19, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When the input contains more accounts than the user has requested to be deserialized, and one of the excess ones is a dup, the input pointer is not adjusted correctly.
Compare the lines added by this commit to line 401:
input += 7; // padding. Since the input data layout does not depend on the number of accounts the user wants to deserialize, this adjustment by 7 bytes must happen in both branches.Summary of Changes
Adjust the
inputpointer by 7 bytes whether the user cares about the account or not.