Add C Serialization Tests for #17217 #17294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #17294 +/- ##
=========================================
- Coverage 82.7% 82.7% -0.1%
=========================================
Files 421 421
Lines 118023 118023
=========================================
- Hits 97661 97646 -15
- Misses 20362 20377 +15 |
dmakarov
reviewed
May 18, 2021
| for (int i = 0; i < 2; i++) { | ||
| sol_assert(*params.ka[i].lamports == 42); | ||
| sol_assert(!sol_memcmp(params.ka[i].data, ka_data, 4)); | ||
| sol_assert(SolPubkey_same(params.ka[i].owner, &ka_owner)); |
There was a problem hiding this comment.
This test seems to fail consistently at this line. Why should it work if local struct ka_owner is not initialized? What am I missing?..
|
Test is probably assuming zero initialized memory
…On Tue, May 18, 2021, 7:58 AM Dmitri Makarov ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In programs/bpf/c/src/ser/ser.c
<#17294 (comment)>:
> + SolAccountInfo ka[1];
+ SolParameters params = (SolParameters){.ka = ka};
+
+ sol_log(__FILE__);
+
+ if (!sol_deserialize(input, ¶ms, SOL_ARRAY_SIZE(ka))) {
+ return ERROR_INVALID_ARGUMENT;
+ }
+
+ char ka_data[] = {1, 2, 3};
+ SolPubkey ka_owner;
+ sol_assert(params.ka_num == 2);
+ for (int i = 0; i < 2; i++) {
+ sol_assert(*params.ka[i].lamports == 42);
+ sol_assert(!sol_memcmp(params.ka[i].data, ka_data, 4));
+ sol_assert(SolPubkey_same(params.ka[i].owner, &ka_owner));
This test seems to fail consistently at this line. Why should it work if
local struct ka_owner is not initialized? What am I missing?..
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#17294 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AJSLY6VYHOCN6LWK6S5QPADTOJ6ARANCNFSM45BJDQUQ>
.
|
|
but the |
|
Fixed in: #17310 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
#17217 fix went in but didn't contain a verifying test
Summary of Changes
Add test
Fixes #