Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NTP: Additional NTP configuration knobs + NTP server provisioning #1254

Closed
Yuval-Mellanox opened this issue Feb 6, 2023 · 3 comments · Fixed by sonic-net/sonic-buildimage#15058, sonic-net/sonic-host-services#60, sonic-net/sonic-swss-common#781, sonic-net/sonic-utilities#2835 or sonic-net/sonic-mgmt#10749
Closed

NTP: Additional NTP configuration knobs + NTP server provisioning #1254

Yuval-Mellanox opened this issue Feb 6, 2023 · 3 comments · Fixed by sonic-net/sonic-buildimage#15058, sonic-net/sonic-host-services#60, sonic-net/sonic-swss-common#781, sonic-net/sonic-utilities#2835 or sonic-net/sonic-mgmt#10749
Assignees
@fastiuk

Comments

@Yuval-Mellanox
Copy link
Contributor

Yuval-Mellanox commented Feb 6, 2023 •
edited
Loading

NTP servers will support the next configurations:
• Changing the protocol version
• Setting security key
• Changing aggressive mode (iburst)
• Enabling/disabling the configured server
NTP feature global config will support the next feature:
• Key management
• Enable/dis NTP authentication
• Enable/dis NTP feature
@fastiuk
Copy link
Contributor

fastiuk commented Mar 20, 2023

NTP HLD

@zhangyanzhao
Copy link
Collaborator

community review recording https://zoom.us/rec/share/8Dp-uE8wWl3pxp6Oku9jGIv711fZ0nX2A6Xf3V1nrYbNxS47cCne7kpsmWfAfGR4.G5wIanqyNmPj5xkD

This was referenced May 13, 2023
Merged
Merged
Merged
Merged
@fastiuk fastiuk mentioned this issue Nov 15, 2023
Merged
7 tasks
qiluo-msft pushed a commit to sonic-net/sonic-buildimage that referenced this issue Dec 11, 2023
@fastiuk
[NTP] Add NTP extended configuration (#15058)
5efb123 
hld [#1296](sonic-net/SONiC#1296)
closes [#1254](sonic-net/SONiC#1254)
depends-on [#60](sonic-net/sonic-host-services#60), [#781](sonic-net/sonic-swss-common#781), [#2835](sonic-net/sonic-utilities#2835), [#10749](sonic-net/sonic-mgmt#10749)

#### Why I did it
To cover the next AIs:
* Configure NTP global parameters
* Add/remove new NTP servers
* Change the configuration for NTP servers
* Show NTP status
* Show NTP configuration

### How I did it
* Add YANG model for a new configuration
* Extend configuration templates to support new knobs

### Description for the changelog
* Add ability to configure NTP global parameters such as authentication, dhcp, admin state
* Change the configuration for NTP servers
* Add an ability to show NTP configuration

#### Link to config_db schema for YANG module changes
[NTP configuration](https://github.com/sonic-net/sonic-buildimage/blob/master/src/sonic-yang-models/doc/Configuration.md#ntp-and-syslog-servers)
This was referenced Dec 13, 2023
Merged
Closed
@zhangyanzhao
Copy link
Collaborator

merged into 202311 release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fastiuk fastiuk

Labels
None yet
Projects
SONiC 202305 Release
Status: MovedToBacklog
SONiC 202311 Release
Status: ✅ Done
Milestone
No milestone
3 participants
@zhangyanzhao @fastiuk @Yuval-Mellanox