Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DellEMC S6100 Watchdog support #2835

Merged
merged 1 commit into from
Jun 29, 2019
Merged

DellEMC S6100 Watchdog support #2835

merged 1 commit into from
Jun 29, 2019

Conversation

paavaanan
Copy link
Contributor

- What I did

  • Added two scripts platform_watchdog_enable.sh and platform_watchdog_disable.sh.

- How I did it

  • Before upgrading the box please do execute platform_watchdog_enable.sh. This enable the SMF Watchdog bit. Also, configure the watchdog timer to 180 seconds.
  • Upgrade the box with new image.
  • During upgrade or in the middle of upgrade, if the box hangs in middle, watchdog kicks-in at 180 seconds interval and perform a warm-reboot.
  • This will avoid manual power-cycle interruption at the time of issue state.
  • Instead, if there is no any issues with the box we disable watchdog in startup script [s6100_platform.sh]
  • Enabling watchdog is not a in-build one. The user have to manually trigger the script to enable watchdog.

- How to verify it

  • execute platform_watchdog_enable.sh
  • Upgrade the box with latest image.

@paavaanan
Copy link
Contributor Author

unit-test-logs.txt

@paavaanan
Copy link
Contributor Author

This need to be cherrypicked for 201811 branch

@yxieca
Copy link
Contributor

yxieca commented May 9, 2019

@jleveque The scripts seems to be working. I am not too sure about the naming of the scripts though. platform_watchdog_<disable|enable>.sh sound too generic to me. This is dell specific code. Do we have plan to use these 2 names for all hardware watchdog scripts?

Other than the naming, I have no other issues with this PR.

@jleveque
Copy link
Contributor

jleveque commented May 9, 2019

@yxieca: We do not intend to use these names across platforms. The goal is to have all platform vendors implement the watchdog portion of the new platform API so that we have a universal method of interacting with the watchdog on all platforms. Unless we feel we need a stopgap for the S6100 in the interim, it might be best to not merge this and wait for the proper solution.

@lguohan lguohan self-requested a review May 10, 2019 03:35
@lguohan
Copy link
Collaborator

lguohan commented May 10, 2019

this is just for temp use in case. by default the watchdog is not enabled. I do not think we need to have this in 201811 branch.

@lguohan lguohan merged commit 4f737f8 into sonic-net:master Jun 29, 2019
seiferteric pushed a commit to project-arlo/sonic-buildimage that referenced this pull request Oct 14, 2019
@ds952811
[JIRA SONIC-5862] DELL S5235F & Z9264F: initial platform support
aae32f1 
1. Z9264F
   Sync up with the following commit on master branch of community

   commit 4f737f8
   [devices]: DellEMC S6100 Watchdog support (sonic-net#2835)

2. S5235F
   Cherry pick the changes from PR sonic-net#3090
   sonic-net#3090

Signed-off-by: Dante (Kuo-Jung) Su <dante.su@broadcom.com>
Change-Id: I50101db8abd19e01a70ba8945aac09eed918028c
yxieca pushed a commit that referenced this pull request Dec 11, 2019
@yxieca
[devices]: DellEMC S6100 Watchdog support (#2835)
11920b3
@paavaanan paavaanan deleted the watchdog-s6100-support branch May 10, 2020 06:10
yxieca pushed a commit that referenced this pull request Nov 30, 2023
@saiarcot895
Update sonic-utilities to master branch version (#17297)
ddd1f43 
* Update sonic-utilities to master branch version

sonic-utilities was (intentionally) pointing to a commit on a fork,
since merging sonic-utilities's changes for Bookworm first onto the
master branch would result in PR checker failures. Now that
sonic-buildimage is on master branch and the Bookworm changes in
sonic-utilities have been merged into master, sonic-utilties can now
point to master.

17e77fe2 Revert "Run yang validation in unit test (#3025)" (#3055)
96dd5559 [dhcp_relay] Fix dhcp_relay counter display issue (#3054)
6dfeee69 [sflow][db_migrator] Egress Sflow support (#3020)
02a588b7 Don't collect /proc/sched_debug
d7ec3251 Fix error about having a mutable default for field headers in dataclass
0ab3ab91 Fix test execution on Bookworm (#3041)
ef8f6f83 Specify test dependencies under extra_requires
61c44e80 Update python packages
1e813105 [wol] Implement wol command line utility (#3048)
8ebc56a0 [sonic_installer]: Improve exception handling: introduce notes. (#3029)
3610ce93 [sonic-package-manager] Fix YANG validation failure on upgrade when feature has constraints in YANG model on FEATURE table (#2933)
cfd2dd39 Add container rsyslog.conf to the sys dump (#3039)
c4b07828 Support new platform in generic configuration update (#3038)
a8d236c8 [fast-reboot-filter-routes.py] Remove click and improve error reporting (#3030)
75199c0f [sonic-package-manager] insert newline in /etc/sonic/generated_services.conf (#3040)
cd855698 [VOQ][saidump] Modify generate_dump: replace save_saidump with save_saidump_by_route_size (#2972)
f1e24ae5 GCU support for Cisco-8000 features (#3010)
67e1c3dc Update GCU rsyslog validator (#3012)
253b7975 [sonic-package-manager] do not modify config_db.json (#3032)
177dd8e8 [sonic-package-manager] add generated service to /etc/sonic/generated_services.conf (#3037)
62fcd77a Configure NTP according to extended configuration (#2835)
ced09404 [dualtor_neighbor_check] Adjust zero-mac check condition (#3034)
a4eeb698 [config] config reload should generate sysinfo if missing  (#3031)
e01fc891 Run yang validation in unit test (#3025)

Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
qiluo-msft pushed a commit that referenced this pull request Dec 11, 2023
@fastiuk
[NTP] Add NTP extended configuration (#15058)
5efb123 
hld [#1296](sonic-net/SONiC#1296)
closes [#1254](sonic-net/SONiC#1254)
depends-on [#60](sonic-net/sonic-host-services#60), [#781](sonic-net/sonic-swss-common#781), [#2835](sonic-net/sonic-utilities#2835), [#10749](sonic-net/sonic-mgmt#10749)

#### Why I did it
To cover the next AIs:
* Configure NTP global parameters
* Add/remove new NTP servers
* Change the configuration for NTP servers
* Show NTP status
* Show NTP configuration

### How I did it
* Add YANG model for a new configuration
* Extend configuration templates to support new knobs

### Description for the changelog
* Add ability to configure NTP global parameters such as authentication, dhcp, admin state
* Change the configuration for NTP servers
* Add an ability to show NTP configuration

#### Link to config_db schema for YANG module changes
[NTP configuration](https://github.com/sonic-net/sonic-buildimage/blob/master/src/sonic-yang-models/doc/Configuration.md#ntp-and-syslog-servers)
yxieca pushed a commit that referenced this pull request Dec 14, 2023
@mssonicbld
[submodule] Update submodule sonic-utilities to the latest HEAD autom…
0cb0891 
…atically (#17457)

src/sonic-utilities

* 1b1402f5 - (HEAD -> 202311, origin/202311) [hash]: Add ECMP/LAG hash algorithm CLI (#3036) (9 days ago) [Nazarii Hnydyn]
* 71514ea3 - Revert "Run yang validation in unit test (#3025)" (#3055) (9 days ago) [Ying Xie]
* b5daf5d4 - [dhcp_relay] Fix dhcp_relay counter display issue (#3054) (9 days ago) [Yaqiang Zhu]
* b3172505 - [sflow][db_migrator] Egress Sflow support (#3020) (9 days ago) [Rajkumar-Marvell]
* 1e813105 - [wol] Implement wol command line utility (#3048) (3 weeks ago) [Zhijian Li]
* 8ebc56a0 - [sonic_installer]: Improve exception handling: introduce notes. (#3029) (3 weeks ago) [Nazarii Hnydyn]
* 3610ce93 - [sonic-package-manager] Fix YANG validation failure on upgrade when feature has constraints in YANG model on FEATURE table (#2933) (3 weeks ago) [Stepan Blyshchak]
* cfd2dd39 - Add container rsyslog.conf to the sys dump (#3039) (4 weeks ago) [Vivek]
* c4b07828 - Support new platform in generic configuration update (#3038) (4 weeks ago) [Stephen Sun]
* a8d236c8 - [fast-reboot-filter-routes.py] Remove click and improve error reporting (#3030) (4 weeks ago) [Stepan Blyshchak]
* 75199c0f - [sonic-package-manager] insert newline in /etc/sonic/generated_services.conf (#3040) (4 weeks ago) [Stepan Blyshchak]
* cd855698 - [VOQ][saidump] Modify generate_dump: replace save_saidump with save_saidump_by_route_size (#2972) (4 weeks ago) [JunhongMao]
* f1e24ae5 - GCU support for Cisco-8000 features (#3010) (4 weeks ago) [rbpittman]
* 67e1c3dc - Update GCU rsyslog validator (#3012) (4 weeks ago) [jingwenxie]
* 253b7975 - [sonic-package-manager] do not modify config_db.json (#3032) (5 weeks ago) [Stepan Blyshchak]
* 177dd8e8 - [sonic-package-manager] add generated service to /etc/sonic/generated_services.conf (#3037) (5 weeks ago) [Stepan Blyshchak]
* 62fcd77a - Configure NTP according to extended configuration (#2835) (5 weeks ago) [Yevhen Fastiuk]
* ced09404 - [dualtor_neighbor_check] Adjust zero-mac check condition (#3034) (5 weeks ago) [Longxiang Lyu]
* a4eeb698 - [config] config reload should generate sysinfo if missing  (#3031) (6 weeks ago) [jingwenxie]
* e01fc891 - Run yang validation in unit test (#3025) (6 weeks ago) [ganglv]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lguohan lguohan lguohan approved these changes

Assignees
No one assigned
Labels
Enhancement ➕ Included in 201811 Branch Platform: DellEMC Request for 201811 Branch :shipit:
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@paavaanan @yxieca @jleveque @lguohan