Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Persistent loglevel HLD #1041

Merged
merged 46 commits into from
Aug 30, 2022
Merged

Persistent loglevel HLD #1041

merged 46 commits into from
Aug 30, 2022

Conversation

EdenGri
Copy link
Contributor

@EdenGri EdenGri commented Jul 31, 2022 •
edited
Loading

@qiluo-msft qiluo-msft requested a review from yxieca August 18, 2022 22:28
qiluo-msft
qiluo-msft reviewed Aug 18, 2022
View reviewed changes
doc/logging/persistent_logger/persistent_loglevel.md Outdated
- In case of a warm upgrade, move Logger tables from LOGLEVEL DB to CONFIG DB (with a minor change in the key) and delete LOGLEVEL DB.
- Exposing the "del" function from the swss-common/sonicv2-connector.h to the db migrator.

(Downgrade will not be supported).
Copy link
Contributor

@qiluo-msft qiluo-msft Aug 18, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Downgrade will not be supported

@yxieca Can we skip downgrade in design? #Closed

Copy link
Contributor

@yxieca yxieca Aug 21, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. I don't think the feature has to work for downgrade. However, downgrade is an important operation. It is important to state what would be the behavior for downgrade.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @yxieca! I am mostly worried the process:

  1. running with an image with this feature
  2. downgrade to older image without this feature. By default, the new ConfigDB table is kept and no processes consume it
  3. upgrade again to an image with this feature: since the config_db.json is carried over to new image, will it be override by "Logger tables from LOGLEVEL DB"?

Copy link
Contributor Author

@EdenGri EdenGri Aug 22, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this case, after step 1: we will have the Logger tables in the CONFIG DB and the LOGLEVEL DB will be empty.
after step 2: the CONFIG DB will contain the old Logger tables and the LOGLEVEL DB will contain new Logger tables with default values.
after step 3: in case of warm-upgrade the content of the Logger tables from the CONFIG DB will be replaced by the content from the LOGLEVEL DB. and the LOGLEVEL DB will be empty.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's nice design consideration. I am looking forward to have this in the design doc itself.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just updated it, thanks!

qiluo-msft
qiluo-msft previously approved these changes Aug 26, 2022
View reviewed changes
@yxieca yxieca merged commit 67e7e73 into sonic-net:master Aug 30, 2022
@dprital dprital mentioned this pull request Sep 7, 2022
Merged
7 tasks
This was referenced Nov 9, 2022
Merged
Merged
Merged
Merged
Merged
Merged
@zhangyanzhao
Copy link
Collaborator

@EdenGri are all code PRs captured in this HLD now? I see new code PRs came recently. Thanks.

@EdenGri
Copy link
Contributor Author

EdenGri commented Nov 13, 2022

@zhangyanzhao all code PRs captured in the HLD.

qiluo-msft pushed a commit to sonic-net/sonic-py-swsssdk that referenced this pull request Nov 13, 2022
@EdenGri
Remove LOGLEVEL DB since is no longer used (#129)
d3584fc 
This PR is part of the following HLD:
Persistent loglevel HLD: sonic-net/SONiC#1041
**- What I did**
Deleted the LOGLEVEL_DB.
After the Logger tables moved from the LOGLEVEL_DB to the CONFIG_DB and the jinja2_cache was deleted the LOGLEVEL_DB is not in use.
**- How I did it**
Removed the LOGLEVEL_DB from the SONiC code

**- How to verify it**
All tests were passed
liat-grozovik pushed a commit to sonic-net/sonic-swss that referenced this pull request Nov 14, 2022
@EdenGri
Remove LOGLEVEL DB since is no longer used (#2507)
da56bd6 
This PR is part of the following HLD:
Persistent loglevel HLD: sonic-net/SONiC#1041

- What I did
Deleted the LOGLEVEL_DB.
After the Logger tables moved from the LOGLEVEL_DB to the CONFIG_DB and the jinja2_cache was deleted the LOGLEVEL_DB is not in use.

- How I did it
Removed the LOGLEVEL_DB from the SONiC code

- How to verify it
All tests were passed
qiluo-msft pushed a commit to sonic-net/sonic-mgmt-common that referenced this pull request Nov 14, 2022
@EdenGri
Remove LOGLEVEL DB since is no longer used (#64)
68e0341 
This PR is part of the following HLD:
Persistent loglevel HLD: sonic-net/SONiC#1041

**- What I did**
Deleted the LOGLEVEL_DB.
After the Logger tables moved from the LOGLEVEL_DB to the CONFIG_DB and the jinja2_cache was deleted the LOGLEVEL_DB is not in use.

**- How I did it**
Removed the LOGLEVEL_DB from the SONiC code

**- How to verify it**
All tests were passed
liat-grozovik pushed a commit to sonic-net/sonic-buildimage that referenced this pull request Nov 14, 2022
@EdenGri
Remove LOGLEVEL DB since is no longer used (#12657)
b1102ad 
This PR is part of the following HLD:
Persistent loglevel HLD: sonic-net/SONiC#1041

- Why I did it
After the Logger tables moved from the LOGLEVEL_DB to the CONFIG_DB and the jinja2_cache was deleted the LOGLEVEL_DB is not in use.

- How I did it
Removed the LOGLEVEL_DB from the SONiC code

- How to verify it
All tests were passed
qiluo-msft pushed a commit to sonic-net/sonic-snmpagent that referenced this pull request Nov 14, 2022
@EdenGri
Remove LOGLEVEL DB since is no longer used (#271)
05f2a28 
This PR is part of the following HLD:
Persistent loglevel HLD: sonic-net/SONiC#1041

**- What I did**
Deleted the LOGLEVEL_DB.
After the Logger tables moved from the LOGLEVEL_DB to the CONFIG_DB and the jinja2_cache was deleted the LOGLEVEL_DB is not in use.
**- How I did it**
Removed the LOGLEVEL_DB from the SONiC code

**- How to verify it**
All tests were passed
davidpil2002 pushed a commit to davidpil2002/sonic-buildimage that referenced this pull request Nov 15, 2022
@EdenGri @davidpil2002
Remove LOGLEVEL DB since is no longer used (sonic-net#12657)
c09c5f9 
This PR is part of the following HLD:
Persistent loglevel HLD: sonic-net/SONiC#1041

- Why I did it
After the Logger tables moved from the LOGLEVEL_DB to the CONFIG_DB and the jinja2_cache was deleted the LOGLEVEL_DB is not in use.

- How I did it
Removed the LOGLEVEL_DB from the SONiC code

- How to verify it
All tests were passed
qiluo-msft pushed a commit to sonic-net/sonic-gnmi that referenced this pull request Nov 28, 2022
@EdenGri
Remove LOGLEVEL DB since is no longer used (#56)
99bfa8f 
This PR is part of the following HLD:
Persistent loglevel HLD: sonic-net/SONiC#1041

#### Why I did it
After the Logger tables moved from the LOGLEVEL_DB to the CONFIG_DB and the jinja2_cache was deleted the LOGLEVEL_DB is not in use.
#### How I did it
Removed the LOGLEVEL_DB from the SONiC code

#### How to verify it
All tests were passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stepanblyschak stepanblyschak stepanblyschak left review comments

@yxieca yxieca yxieca approved these changes

@dprital dprital dprital left review comments

@qiluo-msft qiluo-msft qiluo-msft left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@EdenGri @mssonicbld @dprital @zhangyanzhao @qiluo-msft @yxieca @stepanblyschak