Make the loglevel persistent by moving the LOGGER table from the LOGLEVEL DB to the CONFIG DB #687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qiluo-msft
reviewed
Sep 20, 2022
qiluo-msft
reviewed
Sep 20, 2022
qiluo-msft
reviewed
Sep 20, 2022
qiluo-msft
reviewed
Sep 20, 2022
qiluo-msft
reviewed
Sep 20, 2022
qiluo-msft
previously approved these changes
Oct 6, 2022
EdenGri
changed the title
Merged
7 tasks
EdenGri
force-pushed
the
persistent_loglevel
branch
from
68f99c3
to
31410c3
Compare
…ent to default, change LOGLEVEL DB to CONFIG DB
…NFIG DB and not LOGLEVEL DB
…cessing the table, use static const instead define, and add white space where needed
EdenGri
force-pushed
the
persistent_loglevel
branch
from
31410c3
to
12fa97a
Compare
|
/azpw run |
|
/azpw run |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
merging as the PR as prev approved and only build failures fixed |
liat-grozovik
approved these changes
Oct 28, 2022
dprital
added a commit
to dprital/sonic-buildimage
that referenced
this pull request
Oct 28, 2022
Update sonic-swss-common submodule pointer to include the following: * abda263 Make the loglevel persistent by moving the LOGGER table from the LOGLEVEL DB to the CONFIG DB ([sonic-net#687](sonic-net/sonic-swss-common#687)) * d0fdf62 Check whether a pointer created by dynamic_cast is null before using it. ([sonic-net#689](sonic-net/sonic-swss-common#689)) * 2cae742 [Fast/Warm restart] Implement helper class for waiting restart done ([sonic-net#691](sonic-net/sonic-swss-common#691)) Signed-off-by: dprital <drorp@nvidia.com>
7 tasks
dprital
added a commit
to dprital/sonic-buildimage
that referenced
this pull request
Oct 30, 2022
Update sonic-swss-common submodule pointer to include the following: * abda263 Make the loglevel persistent by moving the LOGGER table from the LOGLEVEL DB to the CONFIG DB ([sonic-net#687](sonic-net/sonic-swss-common#687)) Signed-off-by: dprital <drorp@nvidia.com>
7 tasks
liat-grozovik
pushed a commit
to sonic-net/sonic-buildimage
that referenced
this pull request
Oct 31, 2022
Update sonic-swss-common submodule pointer to include the following: * abda263 Make the loglevel persistent by moving the LOGGER table from the LOGLEVEL DB to the CONFIG DB ([#687](sonic-net/sonic-swss-common#687)) Signed-off-by: dprital <drorp@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR needs to be merged only after the following PR: sonic-net/sonic-buildimage#11996
What I did
Add the ability to the user to save the loglevel and make it persistent to reboot.
How I did it
Move the logger tables from the LOGLEVEL DB to the CONFIG DB
How to verify it