-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chery pick of azure master PR # 16026 #75
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add yang model for MUX_LINKMGR|MUXLOGGER. Co-authored-by: Jing Zhang <zhangjing@microsoft.com>
…(#16026) What I did: Fix the Loopback0 IPv6 address of LC's in chassis not reachable from peer devices. Why I did: For Ipv6 Loopback0 address we only advertise /64 subnet to the peer devices. However, in case of chassis each LC will have it own /128 address of that /64 subnet . Since this /128 address does not get advertised peer devices can-not ping/reach the LC's loopback0. How I fix: Advertise /128 Loopback0 Ipv6 address only between i-BGP peers. This way even though /64 is advertised to e-BGP peer devices when packet reaches any of LC's it can reach the appropriate LC's. How I verify: Manual verification UT added for same. Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
@abdosi There seems to be extra files brought in by this PR which were not present in the original PR you are trying to cherry-pick from... can you check this? the next additional changes seem to be related to "MUXLOGGER"... |
…16021)" This reverts commit cc20464.
gechiang
approved these changes
Aug 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
jon-nokia
pushed a commit
to jon-nokia/sonic-buildimage-msft
that referenced
this pull request
Aug 9, 2023
…atically (#15373) src/sonic-telemetry * 5a83c07 - (HEAD -> 202205, origin/202205) Merge pull request sonic-net#109 from zbud-msft/backport-202205 (86 minutes ago) [Ying Xie] * 0f75a64 - [202012] Workaround gomonkey for armhf (sonic-net#88) (3 weeks ago) [Zain Budhwani] * 1b0dc75 - Fix Makefile error (3 weeks ago) [Zain Budhwani] * 72e4540 - Add diff cov (sonic-net#85) (3 weeks ago) [Zain Budhwani] * 11aace5 - Add get-update to azp yml (sonic-net#79) (3 weeks ago) [Zain Budhwani] * 3eaaccc - Add net core and code coverage results (sonic-net#77) (3 weeks ago) [Zain Budhwani] * 3cf3883 - Enable unit test (3 weeks ago) [ganglyu] * 2a0928f - Change dir name in pipeline (sonic-net#75) (4 weeks ago) [Zain Budhwani] * baa845a - Update yml (4 weeks ago) [Zain Budhwani] * c533d52 - Fix format (4 weeks ago) [ganglyu]
mssonicbld
added a commit
to mssonicbld/sonic-buildimage-msft
that referenced
this pull request
Nov 24, 2023
…utomatically (#17229) #### Why I did it src/sonic-host-services ``` * 689395a - (HEAD -> 202305, origin/202305) Updated the iptable rule to use parent/base name of midplane interface of chassis. (sonic-net#75) (2 days ago) [abdosi] * 45212a8 - [DualToR][caclmgrd] Fix IPtables rules for multiple vlan interfaces for DualToR config (sonic-net#82) (2 days ago) [vdahiya12] ``` #### How I did it #### How to verify it #### Description for the changelog
jon-nokia
pushed a commit
to jon-nokia/sonic-buildimage-msft
that referenced
this pull request
May 3, 2024
…utomatically (#16670) #### Why I did it src/sonic-host-services ``` * 3022c1b - (HEAD -> master, origin/master, origin/HEAD) Updated the iptable rule to use parent/base name of midplane interface of chassis. (sonic-net#75) (6 hours ago) [abdosi] ``` #### How I did it #### How to verify it #### Description for the changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR: sonic-net/sonic-buildimage#16026