[chassis] Fix the Loopback0 IPv6 address of LC's in chassis not reachable from peer devices #16026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peer device's Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
abdosi
added
Request for 202305 Branch
P0
arlakshm
reviewed
Aug 4, 2023
| @@ -104,6 +104,9 @@ router bgp {{ DEVICE_METADATA['localhost']['bgp_asn'] }} | |||
| network {{ get_ipv6_loopback_address(LOOPBACK_INTERFACE, "Loopback0") | ip }}/128 | |||
| {% else %} | |||
| network {{ get_ipv6_loopback_address(LOOPBACK_INTERFACE, "Loopback0") | ip }}/64 | |||
| {% if DEVICE_METADATA['localhost']['switch_type'] == 'voq' or DEVICE_METADATA['localhost']['switch_type'] == 'chassis-packet' %} | |||
There was a problem hiding this comment.
In multi asic linecard, both asics will have same Loopback0. how will this change effect in this case?
There was a problem hiding this comment.
connected routes in the local table have the highest priority
arlakshm
approved these changes
Aug 4, 2023
gechiang
added
the
Included in Chassis for 202205 Branch
|
@StormLiangMS |
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
Aug 14, 2023
…onic-net#16026) What I did: Fix the Loopback0 IPv6 address of LC's in chassis not reachable from peer devices. Why I did: For Ipv6 Loopback0 address we only advertise /64 subnet to the peer devices. However, in case of chassis each LC will have it own /128 address of that /64 subnet . Since this /128 address does not get advertised peer devices can-not ping/reach the LC's loopback0. How I fix: Advertise /128 Loopback0 Ipv6 address only between i-BGP peers. This way even though /64 is advertised to e-BGP peer devices when packet reaches any of LC's it can reach the appropriate LC's. How I verify: Manual verification UT added for same. Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
|
Cherry-pick PR to 202305: #16140 |
mssonicbld
pushed a commit
that referenced
this pull request
Aug 14, 2023
…16026) What I did: Fix the Loopback0 IPv6 address of LC's in chassis not reachable from peer devices. Why I did: For Ipv6 Loopback0 address we only advertise /64 subnet to the peer devices. However, in case of chassis each LC will have it own /128 address of that /64 subnet . Since this /128 address does not get advertised peer devices can-not ping/reach the LC's loopback0. How I fix: Advertise /128 Loopback0 Ipv6 address only between i-BGP peers. This way even though /64 is advertised to e-BGP peer devices when packet reaches any of LC's it can reach the appropriate LC's. How I verify: Manual verification UT added for same. Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
mssonicbld
added
Included in 202305 Branch
and removed
Created PR to 202305 Branch
labels
sonic-otn
pushed a commit
to sonic-otn/sonic-buildimage
that referenced
this pull request
Sep 20, 2023
…onic-net#16026) What I did: Fix the Loopback0 IPv6 address of LC's in chassis not reachable from peer devices. Why I did: For Ipv6 Loopback0 address we only advertise /64 subnet to the peer devices. However, in case of chassis each LC will have it own /128 address of that /64 subnet . Since this /128 address does not get advertised peer devices can-not ping/reach the LC's loopback0. How I fix: Advertise /128 Loopback0 Ipv6 address only between i-BGP peers. This way even though /64 is advertised to e-BGP peer devices when packet reaches any of LC's it can reach the appropriate LC's. How I verify: Manual verification UT added for same. Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
mlok-nokia
pushed a commit
to mlok-nokia/sonic-buildimage
that referenced
this pull request
Jun 5, 2024
…onic-net#16026) What I did: Fix the Loopback0 IPv6 address of LC's in chassis not reachable from peer devices. Why I did: For Ipv6 Loopback0 address we only advertise /64 subnet to the peer devices. However, in case of chassis each LC will have it own /128 address of that /64 subnet . Since this /128 address does not get advertised peer devices can-not ping/reach the LC's loopback0. How I fix: Advertise /128 Loopback0 Ipv6 address only between i-BGP peers. This way even though /64 is advertised to e-BGP peer devices when packet reaches any of LC's it can reach the appropriate LC's. How I verify: Manual verification UT added for same. Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did:
Fix the Loopback0 IPv6 address of LC's in chassis not reachable from peer devices.
Why I did:
For Ipv6 Loopback0 address we only advertise /64 subnet to the peer devices. However, in case of chassis each LC will have it own /128 address of that /64 subnet . Since this /128 address does not get advertised peer devices can-not ping/reach the LC's loopback0.
How I fix:
Advertise /128 Loopback0 Ipv6 address only between i-BGP peers. This way even though /64 is advertised to e-BGP peer devices when packet reaches any of LC's it can reach the appropriate LC's.
How I verify:
Manual verification
UT added for same.