Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[vstest]Remove config calls from test_virtual_chassis.py in swss vs tests #10246

Closed
dgsudharsan opened this issue Mar 16, 2022 · 3 comments
Closed

[vstest]Remove config calls from test_virtual_chassis.py in swss vs tests #10246

dgsudharsan opened this issue Mar 16, 2022 · 3 comments
Assignees
@prsunny
Labels
Chassis 🤖 Modular chassis support Help Wanted 🆘 NOKIA Triaged this issue has been triaged

Comments

@dgsudharsan
Copy link
Collaborator

Description

As a part of ongoing effort to decouple vstests from sonic-utilities, the click commands called in vs tests should be modified to redis-CLI based config_db set.
This is to remove vs tests from running in sonic-utilities pipeline checkers

Example of existing command in test_virtual_chassis:
https://github.com/Azure/sonic-swss/blob/00266891a9f41e5bd37100b05237e865cde429b2/tests/test_virtual_chassis.py#L40

Example of how to migrate:
sonic-net/sonic-swss#2179

Steps to reproduce the issue:

Describe the results you received:

Describe the results you expected:

Output of show version:

(paste your output here)

Output of show techsupport:

(paste your output here or download and attach the file here )

Additional information you deem important (e.g. issue happens only occasionally):
@zhangyanzhao zhangyanzhao added the Chassis 🤖 Modular chassis support label Mar 30, 2022
@zhangyanzhao zhangyanzhao added the Triaged this issue has been triaged label Mar 30, 2022
@prsunny
Copy link
Contributor

prsunny commented Mar 30, 2022

@vganesan-nokia , can you please work on the fix?
@rlhui for viz

vganesan-nokia pushed a commit to vganesan-nokia/sonic-swss that referenced this issue Mar 31, 2022
[vstest][virtual chassis] Removed dvs.runcmd using click commands
6971613 
As needed by sonic-buildimage PR# sonic-net/sonic-buildimage#10246
the click commands usage is avoided in test_virtual_chassis.py

Signed-off-by: vedganes <vedavinayagam.ganesan@nokia.com>
@vganesan-nokia vganesan-nokia mentioned this issue Mar 31, 2022
Merged
vganesan-nokia pushed a commit to vganesan-nokia/sonic-swss that referenced this issue May 27, 2022
[vstest][virtual chassis] Removed dvs.runcmd using click commands
277b01b 
As needed by sonic-buildimage PR# sonic-net/sonic-buildimage#10246
the click commands usage is avoided in test_virtual_chassis.py

Signed-off-by: vedganes <vedavinayagam.ganesan@nokia.com>
@abdosi
Copy link
Contributor

abdosi commented Aug 17, 2022

@saksarav-nokia : Please help in updating test to new infra.

@abdosi abdosi added the NOKIA label Aug 17, 2022
@saksarav-nokia
Copy link
Contributor

@abdosi, This issue is fixed in PR #2214 .

vganesan-nokia added a commit to vganesan-nokia/sonic-swss that referenced this issue Dec 7, 2022
@vganesan-nokia
[vstest][virtual chassis] Removed dvs.runcmd using click commands
5c3abb1 
As needed by sonic-buildimage PR# sonic-net/sonic-buildimage#10246
the click commands usage is avoided in test_virtual_chassis.py

Signed-off-by: vedganes <veda.ganesan@nokia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@prsunny prsunny

Labels
Chassis 🤖 Modular chassis support Help Wanted 🆘 NOKIA Triaged this issue has been triaged
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@zhangyanzhao @dgsudharsan @prsunny @abdosi @saksarav-nokia