[vstest]Migrating vs tests from using click commands to direct DB access #2179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request fixes 2 alerts when merging 52e66a4 into ce88696 - view on LGTM.com fixed alerts:
|
liat-grozovik
previously approved these changes
Mar 15, 2022
Signed-off-by: Sudharsan Dhamal Gopalarathnam <sudharsand@nvidia.com>
|
This pull request fixes 2 alerts when merging 4a286a5 into 608acc3 - view on LGTM.com fixed alerts:
|
This was referenced Mar 16, 2022
Closed
[vstest]Remove config calls from test_mclag_cfg.py in swss vs tests
sonic-net/sonic-buildimage#10245
Closed
|
/azpw run Azure.sonic-swss |
|
/AzurePipelines run Azure.sonic-swss |
|
Azure Pipelines successfully started running 1 pipeline(s). |
liat-grozovik
approved these changes
Mar 20, 2022
|
/azp run Azure.sonic-swss |
|
Azure Pipelines successfully started running 1 pipeline(s). |
prsunny
approved these changes
Mar 21, 2022
|
/azp run Azure.sonic-swss |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run Azure.sonic-swss |
|
Azure Pipelines successfully started running 1 pipeline(s). |
dprital
pushed a commit
to dprital/sonic-swss
that referenced
this pull request
May 8, 2022
…ess (sonic-net#2179) * [vstest]Migrating vs tests from using click commands to direct DB access Signed-off-by: Sudharsan Dhamal Gopalarathnam <sudharsand@nvidia.com>
preetham-singh
pushed a commit
to preetham-singh/sonic-swss
that referenced
this pull request
Aug 6, 2022
…ess (sonic-net#2179) * [vstest]Migrating vs tests from using click commands to direct DB access Signed-off-by: Sudharsan Dhamal Gopalarathnam <sudharsand@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Migrate vs tests from using click commands to direct DB access.
Why I did it
This is to decouple sonic-utilities and sonic-swss. Currently sonic-utilities need to run vstests since many tests use the click commands from config_db. When we have pipeline failures in vs tests it also affects sonic-utilities PR.
Removed ACL CLI and few CRM tests that test CLI and aren't relevant in vstests scenario.
ACL CLI is covered here https://github.com/Azure/sonic-utilities/blob/47c243eb7e9cbe6ebd3479290a98183071cf2124/tests/acl_config_test.py
CRM CLI is covered here
https://github.com/Azure/sonic-utilities/blob/47c243eb7e9cbe6ebd3479290a98183071cf2124/tests/crm_test.py
How I verified it
Run the vs tests
Details if related