Builds now require password-less sudo access

[jusherma]

#11111 assumes that all users building SONIC have password-less sudo access, which is not the case in our build environment. This is causing build problems for us.

A more portable solution would be to mount the $(DOCKER_ROOT) directory in a temporary docker container and delete it from there. That way, the only requirement is that the user has docker access (a pre-req for build anyway)

Originally posted by @jusherma in #11111 (comment)

[qiluo-msft]

Could you give more details on repro? What is the steps and what is observed? Thanks!

[jusherma]

During normal build (make init, make configure, make all), user gets prompted by sudo for their password multiple times. Build proceeds normally even if they don't have sudo access, but this makes the build stall until they deal with the interactive password prompt

Suggested remediation: using a small, temporary docker container to remove the files. For example:

$(docker run --rm -v $(DOCKER_ROOT)\:/mount alpine sh -c 'rm -rf /mount/')
$(mkdir -p $(DOCKER_ROOT))

[zhangyanzhao]

@jusherma what is your specific ask to the community?

[jusherma]

Well, I was hoping this regression would be fixed. Assuming passwordless sudo is available for all users who build SONIC is not a good assumption to make. I now have a fix for this, so I'll open a PR later today

[zhangyanzhao]

Thanks @jusherma

[xumia]

FYI.
@jusherma has fixed in master branch, see #11417
The PR has been merged to 202205.
Waiting for release manager to merge to 202111&202106, if urgent we can send a separate PR to merge to the release branches.