Revert "[build] don't require passwordless sudo (Closes #11292)"

[qiluo-msft]

Reverts #11417

This docker image alpine is unnecessary dependency.

[qiluo-msft]

@jusherma Could you help review?

[jusherma]

This is reverting a change which fixed a build issue (#11292). This should not be reverted

[kv-y]

This is reverting a change which fixed a build issue (#11292). This should not be reverted

Current code also doesn't work. It does nothing.

1. Word shell is missed
2. You can't remove mounted directory inside a container. Try and you get Resoure busy error.
   Possible solution is mount parent directory of $(DOCKER_ROOT).
3. Instead of alpine probably better to use debian:$(BLDENV) container.

[kv-y]

Suggested change

	$(shell sudo rm -rf $(DOCKER_ROOT) && mkdir -p $(DOCKER_ROOT))
	$(shell [ -d $(DOCKER_ROOT) ] && \
	docker run --rm -v $(DOCKER_ROOT)/..\:/mount $(DEFAULT_CONTAINER_REGISTRY)debian:buster \
	sh -c 'rm -rf /mount/$$(basename "$(DOCKER_ROOT)")')

1. debian:buster because we already use it for DOCKER_MACHINE in Makefile.work, but maybe need a variable for default release name.
2. We mount a parent directory because we can't remove bind mounted directory itself.
3. I think we don't need mkdir command. If $(DOCKER_ROOT) doesn't exist then docker creates it (https://docs.docker.com/storage/bind-mounts/).

[jusherma]

Thanks Konstantin. I not sure if $(shell ) is needed. My understanding is that it tells make to treat the command's output as if it were part of the makefile (https://www.gnu.org/software/make/manual/html_node/Shell-Function.html)

But if the above works, I'm not too particular about how it works. My only requirement is that sudo isn't used as that breaks the builds for us

[kv-y]

@xumia
Could you please review this.
You added this feature in #11111
But side effect of your commit was requiring sudo for each make.

There was a fix for this in #11417.
But fix doesn't work correctly because:

1. word shell was missed
2. It's not possible to remove bind-mounted directory itself
   So at this moment fsroot directories are not removed when you do make.

Also this fix has some drawbacks:

1. Docker image alpine is unnecessary dependency. We can use debian:buster instead (we already use it for DOCKER_MACHINE detection)
2. We don't have to remove fsroot directory and run docker container for this every time (e.g. when we use a native docker)
3. We don't have to recreate this directory because docker does it anyway (if we use -v option).

I can do a pull request instead of suggestion. But in this case it will take some time because I haven't signed CCLA yet.

[qiluo-msft]

Close in favor of #15132