Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Is sonic_sfp / sonic_psu (inherted by sfputil.py / psuutil.py) on the Porting Guilde re-designing?? #1433

Closed
pollyhsu2git opened this issue Mar 1, 2018 · 3 comments
Closed

Is sonic_sfp / sonic_psu (inherted by sfputil.py / psuutil.py) on the Porting Guilde re-designing?? #1433

pollyhsu2git opened this issue Mar 1, 2018 · 3 comments
Assignees
@taoyl-ms

Comments

@pollyhsu2git
Copy link
Contributor

pollyhsu2git commented Mar 1, 2018 •
edited
Loading

Description

  1. We've ported / tested OK / PRed sfputil.py ([Accton AS7816-64X] Add new platform and device for AS7816-64X. #1260 ) based on the Porting Guilde
    **##### https://github.com/Azure/SONiC/wiki/Porting-Guide
    sfputil.py: Format: Python module that must implement the class SfpUtil which must inherit from sonic_sfp.sfputilbase.SfpUtilBase which communicates with your SFP device driver
    psuutil.py: Format: Python module that must implement the class PsuUtil which must inherit from sonic_psu.psu_base.PsuBase which communicates with your PSU device driver

  2. We found that sfputil show even sfputil version was not working under the build image with the commit: e18bffd

  3. After examining the sonic-utilities PRs, we found that sonic_sfp together with sonic_psu were removed from its setup.py at its Added profile.ini into docker-syncd-cavm #184 (Remove platform-specific hardware plugin packages; They have been moved to sonic-platform-common repo sonic-utilities#184)
    #####
    $ dpkg --contents ./debs/python-sonic-utilities_1.2-1_all.deb | grep sonic_sfp
    $ [NO FOUND]
    #####

Steps to reproduce the issue:

  1. list the sfputil.py (ls -al)
  2. Issue sfputil version
  3. Issue sfputil show

Describe the results you received:
root@sonic:/# ls -al ./usr/share/sonic/device/x86_64-accton_as7816_64x-r0/plugin/sfputil.py
-rw-r--r-- 1 root root 3611 Feb 27 2018 ./usr/share/sonic/device/x86_64-accton_as7816_64x-r0/plugins/sfputil.py
root@sonic:/# sfputil version
Failed to load platform module 'sfputil': [Errno 2] No such file or directory
root@sonic:/# sfputil show
Failed to load platform module 'sfputil': [Errno 2] No such file or directory

Describe the results you expected:

Additional information you deem important (e.g. issue happens only occasionally):

**Output of `show version`:**

root@sonic:/home/admin# show version
SONiC Software Version: SONiC.HEAD.0-dirty-20180227.062038
Distribution: Debian 8.10
Kernel: 3.16.0-5-amd64
Build commit: e18bffd
Build date: Tue Feb 27 06:27:54 UTC 2018

**Attach debug file `sudo generate_dump`:**

sonic_dump_sonic_20000101_000542.tar.gz
@fillmorechen0928
Copy link

fillmorechen0928 commented Mar 1, 2018 •
edited
Loading

The same issue as (sonic-net/sonic-utilities#215)

Not fixed

@pollyhsu2git
Copy link
Contributor Author

@fillmorechen0928, thanks for the info~

@taoyl-ms taoyl-ms mentioned this issue Mar 1, 2018
Merged
@jleveque
Copy link
Contributor

jleveque commented Mar 1, 2018

Fixed in #1438

@jleveque jleveque closed this as completed Mar 1, 2018
@ForzaTian ForzaTian mentioned this issue Mar 6, 2018
Closed
abdosi added a commit that referenced this issue Sep 19, 2020
@abdosi
[Submodule update] sonic-swss
f930f39 
Avoid adding loopback interface (ip link add) when setting nat zone on
loopback interface (#1434)
    [acl] Remove Ethertype from L3V6 qualifiers (#1433)
    Sflow fixes during DEL processing (#1427)
    Fix #3971 by skipping create-only SAI attributes when modifying
    buffer pools or profiles in orchagent (#1430)
    Fix issue: bufferorch only pass the first attribute to sai when
    setting attribute (#1442)

Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
abdosi added a commit to abdosi/sonic-buildimage that referenced this issue Sep 29, 2020
@abdosi
[Submodule update] sonic swss
4156c1a 
be51ebc Add IPv6 key item support to request parser (sonic-net#1449)
76e2251 When teamd feature state is disabled the Netdevice created by teamd were (sonic-net#1450)
6aa97ce Use .clear() after std::move() (sonic-net#1444)
d5757db Add libzmq to README dependencies (sonic-net#1447)
c7b262e Add libzmq to Makefiles (sonic-net#1443)
0b2e59a [drop counters] Clarify log messages for initial counter setup (sonic-net#1445)
003cf24 [dvs] Refactor and add buffer pool wm test (sonic-net#1446)
2f5d2d9 [acl] Remove Ethertype from L3V6 qualifiers (sonic-net#1433)
f7b974f Fix issue: bufferorch only pass the first attribute to sai when setting attribute (sonic-net#1442)

Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
@abdosi abdosi mentioned this issue Sep 29, 2020
Merged
3 tasks
lguohan pushed a commit that referenced this issue Oct 2, 2020
@abdosi
[Submodule update] sonic swss (#5489)
dda9802 
be51ebc Add IPv6 key item support to request parser (#1449)
76e2251 When teamd feature state is disabled the Netdevice created by teamd were (#1450)
6aa97ce Use .clear() after std::move() (#1444)
d5757db Add libzmq to README dependencies (#1447)
c7b262e Add libzmq to Makefiles (#1443)
0b2e59a [drop counters] Clarify log messages for initial counter setup (#1445)
003cf24 [dvs] Refactor and add buffer pool wm test (#1446)
2f5d2d9 [acl] Remove Ethertype from L3V6 qualifiers (#1433)
f7b974f Fix issue: bufferorch only pass the first attribute to sai when setting attribute (#1442)

Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
@yxieca yxieca mentioned this issue Oct 5, 2020
Closed
@volodymyrsamotiy volodymyrsamotiy mentioned this issue Jan 8, 2021
Merged
4 tasks
raphaelt-nvidia pushed a commit to raphaelt-nvidia/sonic-buildimage that referenced this issue Jan 14, 2021
@daall @abdosi
[acl] Remove Ethertype from L3V6 qualifiers (sonic-net#1433)
5c72824 
This change was already done for MIRRORV6 tables a while back. ETHER_TYPE is unnecessary for V6 tables as the ethertype should always be the same (86DD) for IPv6 traffic. Additionally, this qualifier breaks IPv6 support on some platforms (e.g. Mellanox).

Signed-off-by: Danny Allen <daall@microsoft.com>
lguohan pushed a commit that referenced this issue Jan 17, 2021
@volodymyrsamotiy
[submodule] Update swss submodules (#6394)
312a596 
To add updated PFC storm detection logic for Mellanox platforms

swss commits

a1b6e5e [pfcwd] Update PFC storm detection logic for Mellanox platforms (#1523)
4999565 [acl] Remove Ethertype from L3V6 qualifiers (#1433)

Signed-off-by: Volodymyr Samotiy <volodymyrs@nvidia.com>
abdosi added a commit that referenced this issue Feb 19, 2021
@abdosi
[submodule-update] sonic-utilities
dc306ee 
02438f953aafa3303792eda2309f8f3303e55dc7 (HEAD -> 201911, origin/201911) Cherry-pick Master PR for route-checker tool (#1433)
e54fb69f7323f6ef48f44a1a893fe8266fd6f817 [201911][vnet] Add "vnet_route_check" script (#1443)

Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
santhosh-kt pushed a commit to santhosh-kt/sonic-buildimage that referenced this issue Feb 25, 2021
@abdosi @santhosh-kt
[Submodule update] sonic swss (sonic-net#5489)
35caaa5 
be51ebc Add IPv6 key item support to request parser (sonic-net#1449)
76e2251 When teamd feature state is disabled the Netdevice created by teamd were (sonic-net#1450)
6aa97ce Use .clear() after std::move() (sonic-net#1444)
d5757db Add libzmq to README dependencies (sonic-net#1447)
c7b262e Add libzmq to Makefiles (sonic-net#1443)
0b2e59a [drop counters] Clarify log messages for initial counter setup (sonic-net#1445)
003cf24 [dvs] Refactor and add buffer pool wm test (sonic-net#1446)
2f5d2d9 [acl] Remove Ethertype from L3V6 qualifiers (sonic-net#1433)
f7b974f Fix issue: bufferorch only pass the first attribute to sai when setting attribute (sonic-net#1442)

Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
theasianpianist pushed a commit to theasianpianist/sonic-buildimage that referenced this issue Feb 5, 2022
@daall
[acl] Remove Ethertype from L3V6 qualifiers (sonic-net#1433)
2f5d2d9 
This change was already done for MIRRORV6 tables a while back. ETHER_TYPE is unnecessary for V6 tables as the ethertype should always be the same (86DD) for IPv6 traffic. Additionally, this qualifier breaks IPv6 support on some platforms (e.g. Mellanox).

Signed-off-by: Danny Allen <daall@microsoft.com>
taras-keryk pushed a commit to taras-keryk/sonic-buildimage that referenced this issue Jul 22, 2022
@bingwang-ms
[submodule update] SAI submodule update (sonic-net#1023)
473c990 
* SAI submodule update

- d0f3333 Tunnel Scoped TC MAP and Remarking (sonic-net#1413) (sonic-net#1451)
- 62364a3 Add two more API as RPC for warmboot testing (sonic-net#1421) (sonic-net#1437)
- 426fad1 Make saithriftv compatible with thrift 0.14.1 (sonic-net#1433)

Signed-off-by: bingwang <bingwang@microsoft.com>
mssonicbld added a commit that referenced this issue Oct 22, 2024
@mssonicbld
[submodule] Update submodule sonic-sairedis to the latest HEAD automa…
99f760d 
…tically (#20569)

#### Why I did it
src/sonic-sairedis
```
* 4060b794 - (HEAD -> 202405, origin/202405) [Mellanox] Resolve New Line Formatting Issues in syncd's sai.profile (#1412) (#1433) (3 hours ago) [bingwang-ms]
```
#### How I did it
#### How to verify it
#### Description for the changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@taoyl-ms taoyl-ms

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jleveque @taoyl-ms @pollyhsu2git @fillmorechen0928