Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Commenting out BGP configuration on default minigraph.xml's for Celestica SKUs #1421

Closed
wants to merge 2 commits into from
Closed

Commenting out BGP configuration on default minigraph.xml's for Celestica SKUs #1421

wants to merge 2 commits into from

Conversation

rodnymolina
Copy link
Contributor

The goal here is to prevent injecting irrelevant default config-state into configDB. We are commenting BGP configuration out (instead of deleting it) to reduce as much as possible the potential collisions that may be coming our way during subsequent changes to minigraph.xml files.

Before my changes:

127.0.0.1:6379[4]> keys "BGP*"

  1. "BGP_NEIGHBOR|10.0.0.33"
  2. "BGP_NEIGHBOR|10.0.0.43"
  3. "BGP_NEIGHBOR|10.0.0.21"
  4. "BGP_NEIGHBOR|10.0.0.9"
  5. "BGP_NEIGHBOR|10.0.0.1"
    ...
    ...

After:

127.0.0.1:6379[4]> keys "BGP*"
(empty list or set)
127.0.0.1:6379[4]>

Commenting out BGP configuration on default minigraph.xml's for Celes…
e96b77a 
…tica SKUs.

The goal here is to prevent injecting irrelevant default config-state into configDB. We are commenting BGP configuration out (instead of deleting it) to reduce as much as possible the potential collisions that may be coming our way during subsequent changes to minigraph.xml files.

Before my changes:

127.0.0.1:6379[4]> keys "BGP*"
1) "BGP_NEIGHBOR|10.0.0.33"
2) "BGP_NEIGHBOR|10.0.0.43"
3) "BGP_NEIGHBOR|10.0.0.21"
4) "BGP_NEIGHBOR|10.0.0.9"
5) "BGP_NEIGHBOR|10.0.0.1"
...
...

After:

127.0.0.1:6379[4]> keys "BGP*"
(empty list or set)
127.0.0.1:6379[4]>

RB=1231714
G=lnos-reviewers
R=ntrianta,pmao,rmolina,sfardeen,zxu
A=
Commenting out BGP config on missing minigraph.xml file.
44ce94d 
RB=
G=lnos-reviewers
R=ntrianta,pmao,rmolina,sfardeen,zxu
A=
@lguohan lguohan closed this May 2, 2019
abdosi added a commit that referenced this pull request Sep 3, 2020
@abdosi
[Submodule update] sonic-swss
fbc4d58 
[portsorch] add buffer drop FC group 
[bitmap_vnet] Fix VNET route priority issue (#1421)
[vnet] Maintain the reference count of the nexthop when creating a
vn… (#1414)
[intfsorch] Retrieve Port object before setting NAT zone on router
interfaces. (#1372)
raphaelt-nvidia pushed a commit to raphaelt-nvidia/sonic-buildimage that referenced this pull request Jan 14, 2021
@volodymyrsamotiy @abdosi
[bitmap_vnet] Fix VNET route priority issue (sonic-net#1421)
debc5bb 
Signed-off-by: Volodymyr Samotiy <volodymyrs@mellanox.com>
yxieca added a commit to yxieca/sonic-buildimage that referenced this pull request Feb 23, 2021
@yxieca
[202012][utilities][swss] update submodule head
ef01457 
- swss:
* 459d09b 2021-02-22 | [acl] Enable VLAN ID qualifier for ACL rules (sonic-net#1648) (HEAD -> 202012) [Danny Allen]
* 60859b1 2021-02-08 | [buffermgr] Support maximum port headroom checking (sonic-net#1607) [Stephen Sun]
* 3161cbb 2021-02-17 | Add SAI_INGRESS_PRIORITY_GROUP_STAT_DROPPED_PACKETS counter, create new FlexCounter group (sonic-net#1600) [Andriy Yurkiv]
* 256ed9c 2021-02-08 | Support shared headroom pool on top of dynamic buffer calculation (sonic-net#1581) [Stephen Sun]

- utilities:
* 30d7069 2021-02-16 | [decode-syseeprom] Refactor to utilize sonic-platform package (sonic-net#1435) (HEAD -> 202012, tag: foo) [Joe LeVeque]
* 891fef4 2021-02-16 | [psuutil] Refactor to utilize sonic-platform package (sonic-net#1434) [Joe LeVeque]
* 8c5e505 2021-02-17 | [sfputil] Refactor to utilize sonic-platform package (sonic-net#1421) [Joe LeVeque]
* ca5dd2c 2021-02-17 | [sfpshow] Cleanup (sonic-net#1405) [Joe LeVeque]
* bf489ea 2021-02-17 | Add new cli for SAI_INGRESS_PRIORITY_GROUP_STAT_DROPPED_PACKETS counter in counterpoll utility (sonic-net#1355) [Andriy Yurkiv]
* 25feed3 2021-02-08 | Support shared headroom pool on top of dynamic buffer calculation (sonic-net#1348) [Stephen Sun]
* aaa323a 2021-02-02 | [vrf]: Fix freezing during interface binding (sonic-net#1325) [maksymbelei95]
* cc0bb6e 2021-01-27 | [show] fix "show interfaces breakout" command (sonic-net#1198) [Dmytro Shevchuk]

Signed-off-by: Ying Xie <ying.xie@microsoft.com>
@yxieca yxieca mentioned this pull request Feb 23, 2021
Merged
@jleveque jleveque mentioned this pull request Feb 24, 2021
Closed
daall pushed a commit that referenced this pull request Feb 24, 2021
@yxieca
[202012][utilities][swss] update submodule head (#6869)
038c6aa 
- swss:
* 459d09b 2021-02-22 | [acl] Enable VLAN ID qualifier for ACL rules (#1648) (HEAD -> 202012) [Danny Allen]
* 60859b1 2021-02-08 | [buffermgr] Support maximum port headroom checking (#1607) [Stephen Sun]
* 3161cbb 2021-02-17 | Add SAI_INGRESS_PRIORITY_GROUP_STAT_DROPPED_PACKETS counter, create new FlexCounter group (#1600) [Andriy Yurkiv]
* 256ed9c 2021-02-08 | Support shared headroom pool on top of dynamic buffer calculation (#1581) [Stephen Sun]

- utilities:
* 30d7069 2021-02-16 | [decode-syseeprom] Refactor to utilize sonic-platform package (#1435) (HEAD -> 202012, tag: foo) [Joe LeVeque]
* 891fef4 2021-02-16 | [psuutil] Refactor to utilize sonic-platform package (#1434) [Joe LeVeque]
* 8c5e505 2021-02-17 | [sfputil] Refactor to utilize sonic-platform package (#1421) [Joe LeVeque]
* ca5dd2c 2021-02-17 | [sfpshow] Cleanup (#1405) [Joe LeVeque]
* bf489ea 2021-02-17 | Add new cli for SAI_INGRESS_PRIORITY_GROUP_STAT_DROPPED_PACKETS counter in counterpoll utility (#1355) [Andriy Yurkiv]
* 25feed3 2021-02-08 | Support shared headroom pool on top of dynamic buffer calculation (#1348) [Stephen Sun]
* aaa323a 2021-02-02 | [vrf]: Fix freezing during interface binding (#1325) [maksymbelei95]
* cc0bb6e 2021-01-27 | [show] fix "show interfaces breakout" command (#1198) [Dmytro Shevchuk]

Signed-off-by: Ying Xie <ying.xie@microsoft.com>
stepanblyschak pushed a commit to stepanblyschak/sonic-buildimage that referenced this pull request May 10, 2021
@jleveque
[sfputil] Refactor to utilize sonic-platform package (sonic-net#1421)
6b0ca96 
Refactor sfputil to use sonic-platform package in lieu of old, deprecated platform plugins.

The sfputil utility is still useful, as sfpshow only reads and displays SFP data from State DB. However, we still need a utility to write to the transceivers (low power mode, reset, etc.), and the ability to read directly from the transceivers is helpful for debugging.

- Complete refactor to use sonic-platform package
- Refactor display functions to align with sfpshow utility
- Bump version to 3.0
- Add unit tests
theasianpianist pushed a commit to theasianpianist/sonic-buildimage that referenced this pull request Feb 5, 2022
@volodymyrsamotiy
[bitmap_vnet] Fix VNET route priority issue (sonic-net#1421)
1b89185 
Signed-off-by: Volodymyr Samotiy <volodymyrs@mellanox.com>
taras-keryk pushed a commit to taras-keryk/sonic-buildimage that referenced this pull request Jul 22, 2022
@bingwang-ms
[submodule update] SAI submodule update (sonic-net#1023)
473c990 
* SAI submodule update

- d0f3333 Tunnel Scoped TC MAP and Remarking (sonic-net#1413) (sonic-net#1451)
- 62364a3 Add two more API as RPC for warmboot testing (sonic-net#1421) (sonic-net#1437)
- 426fad1 Make saithriftv compatible with thrift 0.14.1 (sonic-net#1433)

Signed-off-by: bingwang <bingwang@microsoft.com>
mssonicbld added a commit that referenced this pull request Oct 31, 2024
@mssonicbld
[submodule] Update submodule sonic-sairedis to the latest HEAD automa…
b5d4f4e 
…tically (#20641)

#### Why I did it
src/sonic-sairedis
```
* 17e893c5 - (HEAD -> 202405, origin/202405) Rename file name to fit case insensitive file system. (#1446) (22 hours ago) [Liu Shilong]
* 1f189486 - Fix adding flex counter to wrong context (#1421) (#1445) (2 days ago) [Yaqiang Zhu]
```
#### How I did it
#### How to verify it
#### Description for the changelog
mssonicbld added a commit that referenced this pull request Oct 31, 2024
@mssonicbld
[submodule] Update submodule sonic-sairedis to the latest HEAD automa…
89c1d81 
…tically (#20540)

#### Why I did it
src/sonic-sairedis
```
* e394ced7 - (HEAD -> master, origin/master, origin/HEAD) Fix compilation on Buster (#1449) (11 hours ago) [Saikrishna Arcot]
* 4d504ff8 - Rename file name to fit case insensitive file system. (#1444) (2 days ago) [Liu Shilong]
* fe650bb7 - [syncd] Add workaround for port error status notification (#1430) (6 days ago) [Kamil Cudnik]
* cd2773a3 - [syncd] Fix inspect asic command (#1434) (7 days ago) [Kamil Cudnik]
* 2d873766 - [syncd] Make sure notification queue release memory when drained (#1427) (8 days ago) [Kamil Cudnik]
* b8a8856a - Fix adding flex counter to wrong context (#1421) (8 days ago) [byu343]
* 40979e0b - [fastboot] Notify SAI that fastboot is done (#1396) (8 days ago) [Junchao-Mellanox]
* 952ee406 - [codeql] Change pull_request_target to pull_request (#1442) (9 days ago) [Kamil Cudnik]
* 697d86b5 - [syncd] Create neighbor entries before next hop (#1432) (9 days ago) [Kamil Cudnik]
* fa76ca13 - [codeql] Remove git ancestry (#1441) (10 days ago) [Kamil Cudnik]
* 3838d7ee - [codeql] Show git ancestry graph (#1440) (10 days ago) [Kamil Cudnik]
* 2e7d946b - [codeql] Show gcc version before compile (#1438) (10 days ago) [Kamil Cudnik]
* a1e93f58 - [submodule] Update SAI to latest master (#1431) (2 weeks ago) [Kamil Cudnik]
```
#### How I did it
#### How to verify it
#### Description for the changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikos-github nikos-github nikos-github approved these changes

Assignees
No one assigned
Labels
Enhancement ➕
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rodnymolina @nikos-github @lguohan