Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dell-S6100]:Buffer_profile is not dynamically changed after changing cable length in config db #1602

Closed
chitra-raghavan opened this issue Apr 16, 2018 · 3 comments
Assignees

Comments

@chitra-raghavan
Copy link
Contributor

Description

Upon changing the Cable length for an interface in config db, buffer_profile is not dynamically created and applied to the interface

Steps to reproduce the issue:

  1. change cable length for an interface in config db
  2. create and apply buffer profiles
  3. Check whether the buffer_profiles got changed for the particular port

Describe the results you received:

  1. Initial Config :
  • Interface : Ethernet1 connected to Spine router
  • Localhost : Leafrouter
  • Speed : 10000
  • Cable length : 300m
  • Buffer profile : pg_lossless_10000_300m_profile
127.0.0.1:6379[4]> hget DEVICE_METADATA|localhost type
"LeafRouter"

127.0.0.1:6379[4]> hget PORT|Ethernet1 "speed"
"10000"
127.0.0.1:6379[4]> hgetall "DEVICE_NEIGHBOR|Ethernet1"
1) "name"
2) "ARISTA02T2"
3) "port"
4) "Ethernet1"
127.0.0.1:6379[4]> hget "DEVICE_NEIGHBOR_METADATA|ARISTA02T2" type
"SpineRouter"
127.0.0.1:6379[4]>   hget  "CABLE_LENGTH|AZURE" Ethernet1
"300m"
127.0.0.1:6379[4]>  hgetall  "BUFFER_PG|Ethernet1|3-4"
1) "profile"
2) "[BUFFER_PROFILE|pg_lossless_10000_300m_profile]"

  1. Change the neighbor , create buffer.json file and apply
  • Now Ethernet1 is conneced to Tor Router
  • create Buffer templates and apply to db
  • Check Cable _length and buffer profiles. Here the cable length is changed in db t0 40m , but the Buffer_profile is not selected accordingly. it still holds pg_lossless_10000_300m_profile
127.0.0.1:6379[4]> hget "DEVICE_NEIGHBOR_METADATA|ARISTA02T0" type
"ToRRouter"

127.0.0.1:6379[4]>  hset "DEVICE_NEIGHBOR|Ethernet1" "name" "ARISTA02T0"
(integer) 0

 sonic-cfggen -d   -t /usr/share/sonic/device/x86_64-dell_s6100_c2538-r0/Force10-S6100/buffers.json.j2 >/tmp/buffers.json
 sonic-cfggen -j /tmp/buffers.json --write-to-db
 
127.0.0.1:6379[4]>   hget  "CABLE_LENGTH|AZURE" Ethernet1
"40m"
127.0.0.1:6379[4]>  hgetall  "BUFFER_PG|Ethernet1|3-4"
1) "profile"
2) "[BUFFER_PROFILE|pg_lossless_10000_300m_profile]"


  1. When there is change in speed , then using new cable length and speed , the buffer profile gets created . Now 40g_40m profile gets selected

127.0.0.1:6379[4]>  hgetall  "PORT|Ethernet1"
1) "speed"
2) "10000"
127.0.0.1:6379[4]> hset "PORT|Ethernet1" "speed" 40000
(integer) 0
127.0.0.1:6379[4]>  hget  "CABLE_LENGTH|AZURE" Ethernet1
"40m"
127.0.0.1:6379[4]>  hgetall  "BUFFER_PG|Ethernet1|3-4"
1) "profile"
2) "[BUFFER_PROFILE|pg_lossless_40000_40m_profile]"
127.0.0.1:6379[4]>

Describe the results you expected:

When there is change in cable length , the buffer_profile should change accordingly , even though speed is not changed

Output of show version:

showroot@sonic-s6100-01:~# show ver
SONiC Software Version: SONiC.HEAD.159-e69ce25
Distribution: Debian 9.4
Kernel: 4.9.0-5-amd64
Build commit: e69ce25
Build date: Sun Apr  1 12:22:17 UTC 2018
Built by: johnar@jenkins-worker-3

Docker images:
REPOSITORY                 TAG                 IMAGE ID            SIZE
docker-syncd-brcm-orig     latest              21deed7a9544        358.2 MB
docker-syncd-brcm          HEAD.159-e69ce25    21deed7a9544        358.2 MB
docker-orchagent-brcm      HEAD.159-e69ce25    4402f3397c62        287 MB
docker-orchagent-brcm      latest              4402f3397c62        287 MB
docker-lldp-sv2            HEAD.159-e69ce25    bd270863a533        297.1 MB
docker-lldp-sv2            latest              bd270863a533        297.1 MB
docker-dhcp-relay          HEAD.159-e69ce25    2c61bc6343b1        280.1 MB
docker-dhcp-relay          latest              2c61bc6343b1        280.1 MB
docker-database            HEAD.159-e69ce25    29a43900455a        278.7 MB
docker-database            latest              29a43900455a        278.7 MB
docker-teamd               HEAD.159-e69ce25    54378e02e9c3        284.1 MB
docker-teamd               latest              54378e02e9c3        284.1 MB
docker-snmp-sv2            HEAD.159-e69ce25    2221dc781ffb        319.2 MB
docker-snmp-sv2            latest              2221dc781ffb        319.2 MB
docker-router-advertiser   HEAD.159-e69ce25    5875de6f3bcb        276.4 MB
docker-router-advertiser   latest              5875de6f3bcb        276.4 MB
docker-platform-monitor    HEAD.159-e69ce25    5a8efa12f3c0        298.3 MB
docker-platform-monitor    latest              5a8efa12f3c0        298.3 MB
docker-fpm-quagga          HEAD.159-e69ce25    d0832f4b4d35        290.6 MB
docker-fpm-quagga          latest              d0832f4b4d35        290.6 MB
docker-syncd-brcm-rpc      1                   727b7c7712b8        581.9 MB
docker-syncd-brcm-rpc      latest              727b7c7712b8        581.9 MB
docker-syncd-brcm          latest              727b7c7712b8        581.9 MB


@chitra-raghavan chitra-raghavan changed the title [Dell-S6100]:Buffer_profile is not dnamically changed after changing cable length in config db [Dell-S6100]:Buffer_profile is not dynamically changed after changing cable length in config db Apr 16, 2018
@xinliu-seattle
Copy link
Contributor

I am contacting Dell to take a look at this issue.

@vharish02
Copy link
Contributor

Chitra,
This is as per design the cable length should not be changed had a chat with Ying of MSFT as well. Ying want's know why do you want to change the cable length. Once installed in the data center the cable length is fixed and does not change.
This is probably not a bug.

@chitra-raghavan
Copy link
Contributor Author

chitra-raghavan commented Sep 7, 2018

Thanks Harish. I will close the bug as this is not a requirement.

lguohan pushed a commit that referenced this issue Apr 21, 2021
Update the sonic-swss submodule. The following is the new commit in the submodule.
```
b34f783 Resolve neighbor when nexthop does not exist (#1704)
500e2e9 [voq/inbandif] Voq inbandif port (#1602)
9f22ba7 Handle IPv6 and ECMP routes to be programmed to ASIC (#1711)
1b916c3 [acl] Add regression test for `config acl` CLI command (#1694)
8bc7aee Allowing the first time FEC and AN configuration to be pushed to SAI (#1705)
d0dd6ee [Dynamic buffer calc][Mellanox] Fix bug: buffer over subscription in buffer pool size calculation (#1706)
d8b8ca9 fix for CRM available bug (#1699)
97f70d1 NAT : Update the CRM used counters for SNAT and DNAT entries (#1655)
a4e05a7 [vstest] System lag test timing issue fix (#1692)
ca8ba6d [vlan] Add support of VLAN host interface (#1645)
stepanblyschak pushed a commit to stepanblyschak/sonic-buildimage that referenced this issue May 10, 2021
Replace set_entry with mod_entry when setting the proxy_arp value for a VLAN.

Using set_entry will delete any other fields set for the key used, which is not desirable.

Signed-off-by: Lawrence Lee <lawlee@microsoft.com>
yxieca added a commit to yxieca/sonic-buildimage that referenced this issue May 11, 2021
Include fullowing changes:

* 9fc630c 2021-05-11 | [sonic_installer] temporary fix: don't migrate packages on aboot platforms (sonic-net#1607) (github/master) [Stepan Blyshchak]
* fde1d95 2021-05-11 | [config][vxlan] fix 'vxlan evpn_nvo add' command error (sonic-net#1511) [shikenghua]
* 331c5a5 2021-05-10 | [config]: Use mod_entry when editing VLAN_INTERFACE (sonic-net#1602) [Lawrence Lee]
* 8c2980a 2021-05-08 | [sonic-utilities] CLI support for port auto negotiation (sonic-net#1568) [Junchao-Mellanox]
* a71ff02 2021-05-06 | [sfpshow] Gracefully handle improper 'specification_compliance' field (sonic-net#1594) [Joe LeVeque]

Signed-off-by: Ying Xie <ying.xie@microsoft.com>
yxieca added a commit that referenced this issue May 11, 2021
Include fullowing changes:

* 9fc630c 2021-05-11 | [sonic_installer] temporary fix: don't migrate packages on aboot platforms (#1607) (github/master) [Stepan Blyshchak]
* fde1d95 2021-05-11 | [config][vxlan] fix 'vxlan evpn_nvo add' command error (#1511) [shikenghua]
* 331c5a5 2021-05-10 | [config]: Use mod_entry when editing VLAN_INTERFACE (#1602) [Lawrence Lee]
* 8c2980a 2021-05-08 | [sonic-utilities] CLI support for port auto negotiation (#1568) [Junchao-Mellanox]
* a71ff02 2021-05-06 | [sfpshow] Gracefully handle improper 'specification_compliance' field (#1594) [Joe LeVeque]

Signed-off-by: Ying Xie <ying.xie@microsoft.com>
qiluo-msft added a commit that referenced this issue May 20, 2021
…7647)

Includes below commits
```
sonic-swss
05f0438 2021-05-19 | Fix build error (#1751) [Shi Su]
1682a8d 2021-05-12 | [Bulk mode] Improve log in bulk failures (#1740) [Shi Su]
4509e88 2021-04-27 | [routeorch] Add support for blackhole routes (#1723) [Shi Su]
642014d 2019-10-31 | [fix] Use the same storm detection condition for queue occupancy non-zero case as the zero case (#1111) [Wenda Ni]

sonic-utilities
97fc442 2021-05-10 | [config]: Use mod_entry when editing VLAN_INTERFACE (#1602) [Lawrence Lee]
f60d579 2021-04-15 | [techsupport] Update show ip interface command (#1562) [Mahesh Maddikayala]
821d29d 2021-04-14 | Fix Multi-ASIC show specific resursive route by using common parsing function (#1560) [gechiang]

sonic-linux-kernel
61b331f 2021-05-06 | [dps200] Add dps200 PSU module driver (#207) [schobtr]

sonic-platform-daemons
5d2960f 2021-05-17 | [xcvrd] add support for logging mux_metrics events into state DB (#185) [vdahiya12]
a5c9207 2021-05-11 | [thermalctld] Enable stopping thermal manager (#180) [Junchao-Mellanox]
9123f63 2021-05-10 | [muxcable] Remove Xcvrd Sleep (#174) [Tamer Ahmed]
```
raphaelt-nvidia pushed a commit to raphaelt-nvidia/sonic-buildimage that referenced this issue May 23, 2021
Update the sonic-swss submodule. The following is the new commit in the submodule.
```
b34f783 Resolve neighbor when nexthop does not exist (sonic-net#1704)
500e2e9 [voq/inbandif] Voq inbandif port (sonic-net#1602)
9f22ba7 Handle IPv6 and ECMP routes to be programmed to ASIC (sonic-net#1711)
1b916c3 [acl] Add regression test for `config acl` CLI command (sonic-net#1694)
8bc7aee Allowing the first time FEC and AN configuration to be pushed to SAI (sonic-net#1705)
d0dd6ee [Dynamic buffer calc][Mellanox] Fix bug: buffer over subscription in buffer pool size calculation (sonic-net#1706)
d8b8ca9 fix for CRM available bug (sonic-net#1699)
97f70d1 NAT : Update the CRM used counters for SNAT and DNAT entries (sonic-net#1655)
a4e05a7 [vstest] System lag test timing issue fix (sonic-net#1692)
ca8ba6d [vlan] Add support of VLAN host interface (sonic-net#1645)
carl-nokia pushed a commit to carl-nokia/sonic-buildimage that referenced this issue Aug 7, 2021
Update the sonic-swss submodule. The following is the new commit in the submodule.
```
b34f783 Resolve neighbor when nexthop does not exist (sonic-net#1704)
500e2e9 [voq/inbandif] Voq inbandif port (sonic-net#1602)
9f22ba7 Handle IPv6 and ECMP routes to be programmed to ASIC (sonic-net#1711)
1b916c3 [acl] Add regression test for `config acl` CLI command (sonic-net#1694)
8bc7aee Allowing the first time FEC and AN configuration to be pushed to SAI (sonic-net#1705)
d0dd6ee [Dynamic buffer calc][Mellanox] Fix bug: buffer over subscription in buffer pool size calculation (sonic-net#1706)
d8b8ca9 fix for CRM available bug (sonic-net#1699)
97f70d1 NAT : Update the CRM used counters for SNAT and DNAT entries (sonic-net#1655)
a4e05a7 [vstest] System lag test timing issue fix (sonic-net#1692)
ca8ba6d [vlan] Add support of VLAN host interface (sonic-net#1645)
carl-nokia pushed a commit to carl-nokia/sonic-buildimage that referenced this issue Aug 7, 2021
Include fullowing changes:

* 9fc630c 2021-05-11 | [sonic_installer] temporary fix: don't migrate packages on aboot platforms (sonic-net#1607) (github/master) [Stepan Blyshchak]
* fde1d95 2021-05-11 | [config][vxlan] fix 'vxlan evpn_nvo add' command error (sonic-net#1511) [shikenghua]
* 331c5a5 2021-05-10 | [config]: Use mod_entry when editing VLAN_INTERFACE (sonic-net#1602) [Lawrence Lee]
* 8c2980a 2021-05-08 | [sonic-utilities] CLI support for port auto negotiation (sonic-net#1568) [Junchao-Mellanox]
* a71ff02 2021-05-06 | [sfpshow] Gracefully handle improper 'specification_compliance' field (sonic-net#1594) [Joe LeVeque]

Signed-off-by: Ying Xie <ying.xie@microsoft.com>
theasianpianist pushed a commit to theasianpianist/sonic-buildimage that referenced this issue Feb 5, 2022
What I did

Changes to support inband interface configuration

Why I did it

The VOQ chassis needs inband interface in the kernel for cpu to cpu communication across different asic instance and remote neighbor programming in the kernel. This PR adds support for configuring inband interface so that kernel interface can be created via sonic configuration.

How I verified it
swss vs test (test_virtual_chassis.py) to verify the remote neigh programming.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants