-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
show techsupport fail when /usr/core folder not existing #8850
Comments
The scripts shouldn't fail even From the log |
You are right. I was just coming to this realization too. |
The problem was introduced by this PR: sonic-net/sonic-utilities#1833, when /var/core doesn't exist, the script will fail. |
sonic-net/sonic-utilities#1723 for master |
sonic-net/sonic-utilities#1843 pending merge for 202006. |
Above 3 PRs introduced error at line 1224 and line 196 |
What I did Fix: sonic-net/sonic-buildimage#8850 Issue was introduced by #1723, #1833, and #1843 (pending merge) The error_handler is a great idea but the bash script needs to be error free first. How I did it Fix bash script errors. How to verify it run show techsupport test.. Signed-off-by: Ying Xie <ying.xie@microsoft.com>
What I did Fix: sonic-net/sonic-buildimage#8850 Issue was introduced by #1723, #1833, and #1843 (pending merge) The error_handler is a great idea but the bash script needs to be error free first. How I did it Fix bash script errors. How to verify it run show techsupport test.. Signed-off-by: Ying Xie <ying.xie@microsoft.com>
…#1844) What I did Fix: sonic-net/sonic-buildimage#8850 Issue was introduced by sonic-net#1723, sonic-net#1833, and sonic-net#1843 (pending merge) The error_handler is a great idea but the bash script needs to be error free first. How I did it Fix bash script errors. How to verify it run show techsupport test.. Signed-off-by: Ying Xie <ying.xie@microsoft.com>
…oved Error Reporting (#1843) What I did Fix: sonic-net/sonic-buildimage#8850 Issue was introduced by #1723, #1833, and #1843 (pending merge) The error_handler is a great idea but the bash script needs to be error free first. How I did it Fix bash script errors. How to verify it run show techsupport test.. Signed-off-by: Ying Xie <ying.xie@microsoft.com>
…#1844) What I did Fix: sonic-net/sonic-buildimage#8850 Issue was introduced by sonic-net#1723, sonic-net#1833, and sonic-net#1843 (pending merge) The error_handler is a great idea but the bash script needs to be error free first. How I did it Fix bash script errors. How to verify it run show techsupport test.. Signed-off-by: Ying Xie <ying.xie@microsoft.com>
What I did Fix: sonic-net/sonic-buildimage#8850 Issue was introduced by #1723, #1833, and #1843 (pending merge) The error_handler is a great idea but the bash script needs to be error free first. How I did it Fix bash script errors. How to verify it run show techsupport test.. Signed-off-by: Ying Xie <ying.xie@microsoft.com>
Description
show techsupport fails on any platform not provided /usr/bin/hw-management-generate-dump.sh
Steps to reproduce the issue:
Describe the results you received:
See log below
Describe the results you expected:
show techsupport should succeed.
Output of
show version
:Output of
show techsupport
:removed directory '/var/dump/sonic_dump_str2-7215-acs-1_20210927_230453/warmboot/teamd'
removed directory '/var/dump/sonic_dump_str2-7215-acs-1_20210927_230453/warmboot'
removed directory '/var/dump/sonic_dump_str2-7215-acs-1_20210927_230453'
handle_error $? $LINENO
ERR: RC:-1 observed on line 1224
HW Mgmt dump script /usr/bin/hw-management-generate-dump.sh does not exist
mkdir: created directory '/var/dump/sonic_dump_str2-7215-acs-1_20210927_230453'
mkdir: created directory '/var/dump/sonic_dump_str2-7215-acs-1_20210927_230453/log'
sonic_dump_str2-7215-acs-1_20210927_230453/log/techsupport_time_info.mdpRPlzew5
removed '/var/dump/sonic_dump_str2-7215-acs-1_20210927_230453/log/techsupport_time_info.mdpRPlzew5'
removed directory '/var/dump/sonic_dump_str2-7215-acs-1_20210927_230453/log'
removed directory '/var/dump/sonic_dump_str2-7215-acs-1_20210927_230453'
/var/dump/sonic_dump_str2-7215-acs-1_20210927_230453.tar: 90.6% -- replaced with /var/dump/sonic_dump_str2-7215-acs-1_20210927_230453.tar.gz
/var/dump/sonic_dump_str2-7215-acs-1_20210927_230453.tar.gz
real 2m7.188s
user 1m2.188s
sys 0m15.576s
admin@str2-7215-acs-1:~$ echo $?
1
Additional information you deem important (e.g. issue happens only occasionally):
The text was updated successfully, but these errors were encountered: