[techsupport] [202106] Removed -i option for docker commands and Improved Error Reporting #1843
Conversation
Signed-off-by: Vivek Reddy Karri <vkarri@nvidia.com>
|
Please don't merge until ready to cherry-pick #1844 right after merging this PR. |
|
@vivekreddynv it would be great if you could test your change with https://github.com/Azure/sonic-mgmt/tree/master/tests/show_techsupport. |
What I did Fix: sonic-net/sonic-buildimage#8850 Issue was introduced by #1723, #1833, and #1843 (pending merge) The error_handler is a great idea but the bash script needs to be error free first. How I did it Fix bash script errors. How to verify it run show techsupport test.. Signed-off-by: Ying Xie <ying.xie@microsoft.com>
What I did Fix: sonic-net/sonic-buildimage#8850 Issue was introduced by #1723, #1833, and #1843 (pending merge) The error_handler is a great idea but the bash script needs to be error free first. How I did it Fix bash script errors. How to verify it run show techsupport test.. Signed-off-by: Ying Xie <ying.xie@microsoft.com>
Hi @yxieca, Thanks for pointing out these false positive cases. Changes, for this PR were merged in master and 202012. pending in 202106. I would suggest, merging this PR in 202106, followed by fix1 and fix2. I will see what other sections of the code has the false positives issue and will verify the fixes by running the techsupport test. Will raise separate PR's after this? What do you think? |
|
@vivekredynv, what I noticed from making change for 202012 branch is that that branch is different from master branch, therefore more changes are needed. If you could make these changes and making sure they are complete, that would be better than missing a few and having to come back change again. |
…#1844) What I did Fix: sonic-net/sonic-buildimage#8850 Issue was introduced by sonic-net#1723, sonic-net#1833, and sonic-net#1843 (pending merge) The error_handler is a great idea but the bash script needs to be error free first. How I did it Fix bash script errors. How to verify it run show techsupport test.. Signed-off-by: Ying Xie <ying.xie@microsoft.com>
Signed-off-by: Vivek Reddy Karri <vkarri@nvidia.com>
|
Okay, it seems #1846 can't be cleanly cherry-picked to 202012. I'll manually port #1846 (any other fixes required) for 202012. But both the #1844 & #1846 can be cleanly cherry-picked for 202106. Thus i would suggest to merge this PR, followed by 1844 & 1846. That'll put master & 202106 in a consistent state. And if i have to make any changes to these two branches, it'll be easy to cherry-pick to both of them |
|
@vivekreddynv is it ok to take it to 202106 or something else is missing? |
Signed-off-by: Vivek Reddy Karri <vkarri@nvidia.com>
…ocker commands and Improved Error Reporting (sonic-net#1843) Signed-off-by: Vivek Reddy Karri <vkarri@nvidia.com>
@vivekreddynv I see the above comment from Ying, is this PR ready to be merged ? |
…ocker commands and Improved Error Reporting (sonic-net#1843) Signed-off-by: Vivek Reddy Karri <vkarri@nvidia.com>
…#1844) What I did Fix: sonic-net/sonic-buildimage#8850 Issue was introduced by sonic-net#1723, sonic-net#1833, and sonic-net#1843 (pending merge) The error_handler is a great idea but the bash script needs to be error free first. How I did it Fix bash script errors. How to verify it run show techsupport test.. Signed-off-by: Ying Xie <ying.xie@microsoft.com>
Signed-off-by: Vivek Reddy Karri vkarri@nvidia.com
What I did
PR #1723 cannot be cherry-picked directly to 202106. Thus raised a separate PR
How I did it
How to verify it
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)