Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[build]: sonic-utilities package depends on swsssdk; build as wheel and add build dependency #1011

Merged
merged 4 commits into from
Oct 5, 2017

Conversation

jleveque
Copy link
Contributor

@jleveque jleveque commented Oct 4, 2017

  • Resolves Missing dependencies required for sonic-utilities package  SONiC#113

  • Our current make dependency system assumes .deb dependencies are all of the .deb package format and all .whl dependencies are of the .whl package format. Now that sonic-utilities depends on swsssdk, it either needs to be built as a wheel or the dependency system needs to be refactored to allow for cross-dependencies. Wheel is the current Python standard, so maybe we should consider building all Python packages as wheels.

@jleveque jleveque self-assigned this Oct 4, 2017
@stcheng
Copy link
Contributor

stcheng commented Oct 4, 2017

make: *** No rule to make target 'target/debs/swsssdk-2.0.1-py2-none-any.whl-install', needed by 'target/debs/python-sonic-utilities_1.1-1_all.deb'.  Stop.

@lguohan
Copy link
Collaborator

lguohan commented Oct 4, 2017

build fails

@stcheng
Copy link
Contributor

stcheng commented Oct 4, 2017

+ sudo cp target/python-wheels/sonic-utilities_1.1-py2-none-any.whl ./fsroot/sonic-utilities_1.1-py2-none-any.whl
cp: cannot stat 'target/python-wheels/sonic-utilities_1.1-py2-none-any.whl': No such file or directory

@jleveque jleveque changed the title [build]: sonic-utilities package now depends on swsssdk; add build dependency [build]: sonic-utilities package depends on swsssdk; build as wheel and add build dependency Oct 5, 2017
@lguohan lguohan merged commit 1cd9818 into sonic-net:master Oct 5, 2017
@jleveque jleveque deleted the utilities_fix branch October 5, 2017 17:10
zhenggen-xu pushed a commit to zhenggen-xu/sonic-buildimage that referenced this pull request Oct 17, 2019
* msft_github/master:
  [DHCP Relay]: Support Multiple VLANs (Separate DHCP Relay Agents, One Per VLAN) (sonic-net#999)
  [build]: sonic-utilities package depends on swsssdk; build as wheel and add build dependency (sonic-net#1011)
  Make swssconfig status FATAL when it fails (sonic-net#1009)
  [swss]: Update swss-common/sairedis/swss submodules (sonic-net#1008)
  [config-engine]: Fix bug multiple ports connecting to same neighbor (sonic-net#1005)
dgsudharsan pushed a commit to dgsudharsan/sonic-buildimage that referenced this pull request Oct 29, 2019
20747fa -2019-10-28: Sflow orchagent changes (sonic-net#1012) [Sudharsan]
b767ca2 -2019-10-28: Copp sflow changes (sonic-net#1011)[Sudharsan]
madhanmellanox pushed a commit to madhanmellanox/sonic-buildimage that referenced this pull request Mar 23, 2020
jleveque added a commit that referenced this pull request Aug 9, 2020
* src/sonic-utilities 9700e45...621aad0 (9):
  > [Python] Migrate applications/scripts to import sonic-py-common package (#1008)
  > [config qos] QoS and Buffer config genration for multi ASIC platforms (#978)
  > [cli]: pass db connector as click context (#1029)
  > [PDDF] Make utilities compatible to platform API 2.0, in accordance with pddf_2.0 (#940)
  > [tests] Add unit tests for 'show platform ...' commands (#1021)
  > Add secure fast/warm-reboot support for Aboot (#994)
  > [sonic-installer] Create Envvars File for Incoming Image (#1011)
  > [config load]: do not stop/reset/reload service if it is disabled (#1028)
  > [tests]: move feature_test.py into tests folder (#1027)
santhosh-kt pushed a commit to santhosh-kt/sonic-buildimage that referenced this pull request Feb 25, 2021
* src/sonic-utilities 9700e45...621aad0 (9):
  > [Python] Migrate applications/scripts to import sonic-py-common package (sonic-net#1008)
  > [config qos] QoS and Buffer config genration for multi ASIC platforms (sonic-net#978)
  > [cli]: pass db connector as click context (sonic-net#1029)
  > [PDDF] Make utilities compatible to platform API 2.0, in accordance with pddf_2.0 (sonic-net#940)
  > [tests] Add unit tests for 'show platform ...' commands (sonic-net#1021)
  > Add secure fast/warm-reboot support for Aboot (sonic-net#994)
  > [sonic-installer] Create Envvars File for Incoming Image (sonic-net#1011)
  > [config load]: do not stop/reset/reload service if it is disabled (sonic-net#1028)
  > [tests]: move feature_test.py into tests folder (sonic-net#1027)
stepanblyschak pushed a commit to stepanblyschak/sonic-buildimage that referenced this pull request May 10, 2021
)

Create environment files for SONiC immutable attribute. The file
will reside in the incoming image dir under sonic-config dir.
Incoming image will then move the file to /etc/sonic. The file
will be used to avoid calls into cfggen for those attributes.

signed-off-by: Tamer Ahmed <tamer.ahmed@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants