Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add version tag for the docker images #1021

Merged
merged 1 commit into from
Oct 8, 2017
Merged

Conversation

lguohan
Copy link
Collaborator

@lguohan lguohan commented Oct 7, 2017

docker images are also tagged with the same image version.

- What I did
add version tag for the docker images

- How I did it
use docker tag in the image build process

- How to verify it

admin@str-a7050-acs-1:~$ show version
SONiC Software Version: SONiC.dockertag.0-dirty-20171007.064313


REPOSITORY                TAG                                 IMAGE ID            CREATED             SIZE
docker-syncd-brcm         dockertag.0-dirty-20171007.064313   54702527a5d3        12 hours ago        323 MB
docker-syncd-brcm         latest                              54702527a5d3        12 hours ago        323 MB
docker-orchagent-brcm     dockertag.0-dirty-20171007.064313   dc767a23c8d5        12 hours ago        263.7 MB
docker-orchagent-brcm     latest                              dc767a23c8d5        12 hours ago        263.7 MB
docker-lldp-sv2           dockertag.0-dirty-20171007.064313   6f89bf9ba435        12 hours ago        261.3 MB
docker-lldp-sv2           latest                              6f89bf9ba435        12 hours ago        261.3 MB
docker-dhcp-relay         dockertag.0-dirty-20171007.064313   e3809814dca2        12 hours ago        258.2 MB
docker-dhcp-relay         latest                              e3809814dca2        12 hours ago        258.2 MB
docker-database           dockertag.0-dirty-20171007.064313   8ede8961ee10        12 hours ago        256.5 MB
docker-database           latest                              8ede8961ee10        12 hours ago        256.5 MB
docker-snmp-sv2           dockertag.0-dirty-20171007.064313   09cc600c1f6a        12 hours ago        296 MB
docker-snmp-sv2           latest                              09cc600c1f6a        12 hours ago        296 MB
docker-teamd              dockertag.0-dirty-20171007.064313   da85c770bcc3        13 hours ago        260.8 MB
docker-teamd              latest                              da85c770bcc3        13 hours ago        260.8 MB
docker-platform-monitor   dockertag.0-dirty-20171007.064313   15fdba02afc6        13 hours ago        275.8 MB
docker-platform-monitor   latest                              15fdba02afc6        13 hours ago        275.8 MB
docker-fpm-quagga         dockertag.0-dirty-20171007.064313   9b316169d8ca        13 hours ago        267.3 MB
docker-fpm-quagga         latest                              9b316169d8ca        13 hours ago        267.3 MB

- Description for the changelog
add version tag for the docker images

- A picture of a cute animal (not mandatory but encouraged)

ʕ •ᴥ•ʔ

docker images are also tagged with the same image version.
@lguohan lguohan requested a review from qiluo-msft October 7, 2017 21:52
Copy link
Collaborator

@qiluo-msft qiluo-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am ok with this change. Suggest remove imagename:latest to make 'docker images' output clear.

@lguohan
Copy link
Collaborator Author

lguohan commented Oct 8, 2017

it is better not to remove imagename:latest since there are script to use latest instead of actual name.

@lguohan lguohan merged commit dc0f3ce into sonic-net:master Oct 8, 2017
@lguohan lguohan deleted the dockertag branch November 6, 2017 04:39
jleveque added a commit that referenced this pull request Aug 9, 2020
* src/sonic-utilities 9700e45...621aad0 (9):
  > [Python] Migrate applications/scripts to import sonic-py-common package (#1008)
  > [config qos] QoS and Buffer config genration for multi ASIC platforms (#978)
  > [cli]: pass db connector as click context (#1029)
  > [PDDF] Make utilities compatible to platform API 2.0, in accordance with pddf_2.0 (#940)
  > [tests] Add unit tests for 'show platform ...' commands (#1021)
  > Add secure fast/warm-reboot support for Aboot (#994)
  > [sonic-installer] Create Envvars File for Incoming Image (#1011)
  > [config load]: do not stop/reset/reload service if it is disabled (#1028)
  > [tests]: move feature_test.py into tests folder (#1027)
santhosh-kt pushed a commit to santhosh-kt/sonic-buildimage that referenced this pull request Feb 25, 2021
* src/sonic-utilities 9700e45...621aad0 (9):
  > [Python] Migrate applications/scripts to import sonic-py-common package (sonic-net#1008)
  > [config qos] QoS and Buffer config genration for multi ASIC platforms (sonic-net#978)
  > [cli]: pass db connector as click context (sonic-net#1029)
  > [PDDF] Make utilities compatible to platform API 2.0, in accordance with pddf_2.0 (sonic-net#940)
  > [tests] Add unit tests for 'show platform ...' commands (sonic-net#1021)
  > Add secure fast/warm-reboot support for Aboot (sonic-net#994)
  > [sonic-installer] Create Envvars File for Incoming Image (sonic-net#1011)
  > [config load]: do not stop/reset/reload service if it is disabled (sonic-net#1028)
  > [tests]: move feature_test.py into tests folder (sonic-net#1027)
stepanblyschak pushed a commit to stepanblyschak/sonic-buildimage that referenced this pull request May 10, 2021
Add unit tests for 'show platform ...' commands
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants