[sonic-sairedis update] Support for SAI header v1.10.2 with BRCM SAI v7.1.0.0 and MLNX SAI v1.21.1.0 #10583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vmittal-msft
force-pushed
the
sai_1.10.2
branch
from
9e6bd39
to
9415021
Compare
vmittal-msft
force-pushed
the
sai_1.10.2
branch
from
c77b08a
to
5b81725
Compare
vmittal-msft
changed the title
vmittal-msft
force-pushed
the
sai_1.10.2
branch
3 times, most recently
from
76dfe1c
to
269de28
Compare
vmittal-msft
changed the title
vmittal-msft
force-pushed
the
sai_1.10.2
branch
5 times, most recently
from
43563b8
to
a08595b
Compare
|
@vmittal-msft Can you please correct the MLNX SAI version in the title to v1.21.1.0? |
Done. Thanks. |
Hi @vmittal-msft I still see the title with v1.12.1.0 |
vmittal-msft
changed the title
Done. Thanks. |
alexrallen
suggested changes
Apr 22, 2022
There was a problem hiding this comment.
@vmittal-msft Before you update the sonic-sairedis submodule pointer in sonic-buildimage you need to make sure the following PRs are merged from SAI and the pointer is updated in sonic-sairedis as the v1.10 is currently missing them and will cause regressions.
Merged
6 tasks
|
Opened PR to take care of above - |
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
vmittal-msft
force-pushed
the
sai_1.10.2
branch
from
8f97941
to
48ae599
Compare
6 tasks
Signed-off-by: Vineet Mittal <vineetmittal@microsoft.com> Changes for SAI header v1.10.2 and BRCM SAI v7.1 Update SDK/FW to 4.5.1500/2010.1500 and SAI version to 1.21.1.1 Updated sonic-sairedis submodule to include SAI fixes
vmittal-msft
changed the title
vmittal-msft
changed the title
|
/Azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
judyjoseph
approved these changes
May 5, 2022
lolyu
pushed a commit
to lolyu/sonic-mgmt
that referenced
this pull request
May 31, 2022
Add a hotfix for BCM SAI 7.1.0 We are seeing Mux tunnel creation failure after BCM SAI is upgrated to `7.1.0` in PR sonic-net/sonic-buildimage#10583. This PR is to patch the `bcm.config` for `dualtor` deployment to workaround this issue until the issue is fixed in image. This PR will add `sai_remap_prio_on_tnl_egress=1` into `bcm.config` if the device is running `master` image, and deployment is `dualtor`, and the SKU contains `arista`. The change is validated by manually running `./testbed-cli.sh deploy-mg vms24-dual-t0-7050-2 str2 password.txt ` Signed-off-by: bingwang <bingwang@microsoft.com>
liushilongbuaa
pushed a commit
to liushilongbuaa/sonic-buildimage
that referenced
this pull request
Jun 20, 2022
…v7.1.0.0 and MLNX SAI v1.21.1.0 (sonic-net#10583)
StormLiangMS
pushed a commit
to StormLiangMS/sonic-mgmt
that referenced
this pull request
Jul 4, 2022
Add a hotfix for BCM SAI 7.1.0 We are seeing Mux tunnel creation failure after BCM SAI is upgrated to `7.1.0` in PR sonic-net/sonic-buildimage#10583. This PR is to patch the `bcm.config` for `dualtor` deployment to workaround this issue until the issue is fixed in image. This PR will add `sai_remap_prio_on_tnl_egress=1` into `bcm.config` if the device is running `master` image, and deployment is `dualtor`, and the SKU contains `arista`. The change is validated by manually running `./testbed-cli.sh deploy-mg vms24-dual-t0-7050-2 str2 password.txt ` Signed-off-by: bingwang <bingwang@microsoft.com>"
StormLiangMS
pushed a commit
to StormLiangMS/sonic-mgmt
that referenced
this pull request
Jul 4, 2022
**The hotfix is no longer required after PR sonic-net/sonic-buildimage#10962 is merged** Add a hotfix for BCM SAI 7.1.0 We are seeing Mux tunnel creation failure after BCM SAI is upgrated to `7.1.0` in PR sonic-net/sonic-buildimage#10583. This PR is to patch the `bcm.config` for `dualtor` deployment to workaround this issue until the issue is fixed in image. This PR will add `sai_remap_prio_on_tnl_egress=1` into `bcm.config` if the device is running `master` image, and deployment is `dualtor`, and the SKU contains `arista`. The change is validated by manually running `./testbed-cli.sh deploy-mg vms24-dual-t0-7050-2 str2 password.txt ` Signed-off-by: bingwang <bingwang@microsoft.com> Reverts !577
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Vineet Mittal vineetmittal@microsoft.com
Why I did it
Support SAI header v1.10.2
How I did it
Integrated SAI header 1.10.2 with sonic-sairedis and made changes to vendor code in sonic
sonic-net/sonic-sairedis#1034
sonic-net/saibcm-modules@fb4cf12
How to verify it
Verified to be working fine on BRCM TD3/TH based HWSKUs.
BRCM SAI ver: [7.1.0.0], OCP SAI ver: [1.10.2], SDK ver: [sdk-6.5.24] CANCUN ver: [06.04.01]
show int status
Interface Lanes Speed MTU FEC Alias Vlan Oper Admin Type Asym PFC
Ethernet100 97,98,99,100 100G 9100 rs Ethernet26/1 routed down down QSFP28 or later off
Ethernet104 105,106,107,108 100G 9100 rs Ethernet27/1 routed down down QSFP28 or later off
Ethernet108 109,110,111,112 100G 9100 rs Ethernet28/1 routed down down QSFP28 or later off
Ethernet112 117,118,119,120 100G 9100 rs Ethernet29/1 PortChannel101 up up QSFP28 or later off
Ethernet116 113,114,115,116 100G 9100 rs Ethernet30/1 PortChannel102 up up QSFP28 or later off
Ethernet120 121,122,123,124 100G 9100 rs Ethernet31/1 PortChannel103 up up QSFP28 or later off
Ethernet124 125,126,127,128 100G 9100 rs Ethernet32/1 PortChannel104 up up QSFP28 or later off
Ethernet128 129 10G 9100 N/A Ethernet33 routed down down N/A off
Ethernet132 128 10G 9100 N/A Ethernet34 routed down down N/A off
PortChannel101 N/A 100G 9100 N/A N/A routed up up N/A N/A
PortChannel102 N/A 100G 9100 N/A N/A routed up up N/A N/A
PortChannel103 N/A 100G 9100 N/A N/A routed up up N/A N/A
PortChannel104 N/A 100G 9100 N/A N/A routed up up N/A N/A
show ip bgp sum
IPv4 Unicast Summary:
BGP router identifier 10.1.0.32, local AS number 65100 vrf-id 0
BGP table version 12806
RIB entries 12807, using 2458944 bytes of memory
Peers 4, using 87264 KiB of memory
Peer groups 4, using 256 bytes of memory
Neighbhor V AS MsgRcvd MsgSent TblVer InQ OutQ Up/Down State/PfxRcd NeighborName
10.0.0.57 4 64600 3231 3230 0 0 0 00:01:10 6400 ARISTA01T1
10.0.0.59 4 64600 3231 3230 0 0 0 00:01:10 6400 ARISTA02T1
10.0.0.61 4 64600 3228 3229 0 0 0 00:01:10 6400 ARISTA03T1
10.0.0.63 4 64600 3231 3230 0 0 0 00:01:11 6400 ARISTA04T1
Total number of neighbors 4
show ip route summary
Route Source Routes FIB (vrf default)
connected 7 7
ebgp 6403 6403
ibgp 0 0
Totals 6410 6410
show ipv6 route summary
Route Source Routes FIB (vrf default)
kernel 1 1
connected 43 43
static 1 1
ebgp 6403 6403
ibgp 0 0
Totals 6448 6448
Following sonic-mgmt tests are passing with this -
fib/test_fib.py
vxlan/test_vxlan_decap.py
fdb/test_fdb.py
decap/test_decap.py
ipfwd/test_dir_bcast.py
vlan/test_vlan.py
Which release branch to backport (provide reason below if selected)
Description for the changelog
SAI header tag v1.10.2 support
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)