[Tunnel PFC] Add property for tunnel PFC #10962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardyu-ms
requested review from
sujinmkang,
prgeor and
vdahiya12
as code owners
richardyu-ms
force-pushed
the
remap_proeprty
branch
3 times, most recently
from
72fb63f
to
2fdd213
Compare
richardyu-ms
changed the title
bingwang-ms
reviewed
May 28, 2022
device/arista/x86_64-arista_7050cx3_32s/Arista-7050CX3-32S-C32/sai.profile
Show resolved
Hide resolved
bingwang-ms
reviewed
May 28, 2022
bingwang-ms
reviewed
May 28, 2022
src/sonic-config-engine/tests/sample_output/py3/config.arista7260-dualtor.bcm
Outdated
Show resolved
Hide resolved
lguohan
reviewed
May 31, 2022
device/arista/x86_64-arista_7260cx3_64/Arista-7260CX3-Q64/config.bcm.j2
Outdated
Show resolved
Hide resolved
lguohan
reviewed
May 31, 2022
device/arista/x86_64-arista_7050cx3_32s/Arista-7050CX3-32S-D48C8/config.bcm.j2
Show resolved
Hide resolved
richardyu-ms
force-pushed
the
remap_proeprty
branch
from
f6183b3
to
45808fb
Compare
lguohan
reviewed
May 31, 2022
device/arista/x86_64-arista_7260cx3_64/Arista-7260CX3-Q64/config.bcm.j2
Outdated
Show resolved
Hide resolved
Replace the config.bcm file with j2 template file - Add 'sai_remap_prio_on_tnl_egress=1' property when device metadata local - Host subtype is 'dualtor' - Change sai.profile foe the new config.bcm.j2 - Add tests Test done: Unit test.
richardyu-ms
force-pushed
the
remap_proeprty
branch
from
45808fb
to
ae9b69e
Compare
lguohan
reviewed
May 31, 2022
device/arista/x86_64-arista_7260cx3_64/Arista-7260CX3-C64/config.bcm.j2
Outdated
Show resolved
Hide resolved
yxieca
previously approved these changes
Jun 1, 2022
|
/azp run |
|
You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list. |
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: Ying Xie <ying.xie@microsoft.com>
yxieca
requested changes
Jun 4, 2022
There was a problem hiding this comment.
@richardyu-ms you changed config.bcm for 5 hardware skus. but only updated sai.profile for 2 of them. you need to update all 5 sai.profiles.
ah, never mind. 7260 has right contents in sai.profiles already. |
yxieca
approved these changes
Jun 5, 2022
yxieca
pushed a commit
that referenced
this pull request
Jun 5, 2022
* [Tunnel PFC] Add property for tunnel PFC Replace the config.bcm file with j2 template file - Add 'sai_remap_prio_on_tnl_egress=1' property when device metadata local - Host subtype is 'dualtor' - Change sai.profile foe the new config.bcm.j2
richardyu-ms
added a commit
to richardyu-ms/sonic-buildimage
that referenced
this pull request
Jun 6, 2022
*[Cherry-pick] [Tunnel PFC] Add property for tunnel PFC Replace the config.bcm file with j2 template file - Add 'sai_remap_prio_on_tnl_egress=1' property when device metadata local - Host subtype is 'dualtor' - Change sai.profile foe the new config.bcm.j2
6 tasks
richardyu-ms
added a commit
to richardyu-ms/sonic-buildimage
that referenced
this pull request
Jun 6, 2022
Per PR sonic-net#10962, add a new property sai_remap_prio_on_tnl_egress. Follow the rule, need to add the property into the permitted list file. Signed-off-by: richardyu-ms <richard.yu@microsoft.com>
6 tasks
richardyu-ms
added a commit
to richardyu-ms/sonic-buildimage
that referenced
this pull request
Jun 6, 2022
Per PR sonic-net#10962, added a new property sai_remap_prio_on_tnl_egress. Follow the rule, need to add the property into the permitted list file. Signed-off-by: richardyu-ms <richard.yu@microsoft.com>
6 tasks
lguohan
pushed a commit
that referenced
this pull request
Jun 6, 2022
* [Tunnel PFC] Add property for tunnel PFC Replace the config.bcm file with j2 template file - Add 'sai_remap_prio_on_tnl_egress=1' property when device metadata local - Host subtype is 'dualtor' - Change sai.profile foe the new config.bcm.j2
5 tasks
StormLiangMS
pushed a commit
to StormLiangMS/sonic-mgmt
that referenced
this pull request
Jul 4, 2022
**The hotfix is no longer required after PR sonic-net/sonic-buildimage#10962 is merged** Add a hotfix for BCM SAI 7.1.0 We are seeing Mux tunnel creation failure after BCM SAI is upgrated to `7.1.0` in PR sonic-net/sonic-buildimage#10583. This PR is to patch the `bcm.config` for `dualtor` deployment to workaround this issue until the issue is fixed in image. This PR will add `sai_remap_prio_on_tnl_egress=1` into `bcm.config` if the device is running `master` image, and deployment is `dualtor`, and the SKU contains `arista`. The change is validated by manually running `./testbed-cli.sh deploy-mg vms24-dual-t0-7050-2 str2 password.txt ` Signed-off-by: bingwang <bingwang@microsoft.com> Reverts !577
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
Add property sai_remap_prio_on_tnl_egress, which is dependent by tunnel PFC.
How I did it
Add property sai_remap_prio_on_tnl_egress, which is dependent by tunnel PFC.
This property should only be available in dual tor environment.
How to verify it
Test done:
Run test test_j2files.py
in another PR #11027
Which release branch to backport (provide reason below if selected)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)