Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified HWSKU to match the internally defined HWSKU string #1062

Merged
merged 6 commits into from
Oct 23, 2017
Merged

Modified HWSKU to match the internally defined HWSKU string #1062

merged 6 commits into from
Oct 23, 2017

Conversation

prsunny
Copy link
Contributor

@prsunny prsunny commented Oct 20, 2017

- What I did
Modified HWSKU to match the internally defined HWSKU string

@prsunny prsunny requested a review from lguohan October 20, 2017 21:12
@lguohan
Copy link
Collaborator

lguohan commented Oct 20, 2017

later, you can create a new branch and generate pr from that branch, then you won't have old commits in your pr.

@stcheng
Copy link
Contributor

stcheng commented Oct 20, 2017

yes. when doing merging, the commit messages shall also be cleaned up.

@prsunny
Copy link
Contributor Author

prsunny commented Oct 23, 2017

Based on internal discussion, the HWSKU shall be renamed to "Arista-7060CX-32S-C32"

@stcheng stcheng merged commit c74007b into sonic-net:master Oct 23, 2017
yxieca added a commit to yxieca/sonic-buildimage that referenced this pull request Sep 19, 2019
Submodule src/sonic-swss 24fcbb6..3cee6b8:
  > [aclorch]: Fix table name in counter table for mirror rules (sonic-net#1060)
  > Cannot ping to link-local ipv6 interface address of the switch. (sonic-net#774)
  > [MirrorOrch]: Mirror Session Retention across Warm Reboot (sonic-net#1062)

Submodule src/sonic-utilities afaedb7..a06bee7:
  > [201811][config] Add '-h' and '-?' as help options to unify with show/sonic-clear cmds (sonic-net#654)
  > Revert "Fixed config Asym PFC CLI. (sonic-net#632)" (sonic-net#652)

Signed-off-by: Ying Xie <ying.xie@microsoft.com>
yxieca added a commit that referenced this pull request Sep 19, 2019
Submodule src/sonic-swss 24fcbb6..3cee6b8:
  > [aclorch]: Fix table name in counter table for mirror rules (#1060)
  > Cannot ping to link-local ipv6 interface address of the switch. (#774)
  > [MirrorOrch]: Mirror Session Retention across Warm Reboot (#1062)

Submodule src/sonic-utilities afaedb7..a06bee7:
  > [201811][config] Add '-h' and '-?' as help options to unify with show/sonic-clear cmds (#654)
  > Revert "Fixed config Asym PFC CLI. (#632)" (#652)

Signed-off-by: Ying Xie <ying.xie@microsoft.com>
abdosi added a commit that referenced this pull request Sep 19, 2020
Revert "Revert " [201911]show interface counters for multi ASIC devices
(#1104)""
 Revert "Revert "Pfcstat (#1097)""
  [show] Fix 'show int neighbor expected' (#1106)
   Update argument for docker exec it->i (#1118)
     Update to make config load/reload backward compatible. (#1115)
     Handling deletion of Port Channel before deletion of its members
     (#1062)
    Skip default route present in ASIC-DB but not in APP-DB. (#1107)
     [CLI][PFCWD][Multi-ASIC] Added multi ASIC support to 'pfcwd' CLI
     (#1102)
       [201911]  Multi asic platform config interface portchannel, show
       transceiver  (#1087)
       [drop counters] Fix configuration for counters with lowercase
       names (#1103)

Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
stepanblyschak pushed a commit to stepanblyschak/sonic-buildimage that referenced this pull request May 10, 2021
…ic-net#1062)

* Handling deletion of Portchannel before deletion of its members

* removed a extra space in the condifitional statement

* added Note about portchannel deletion in Command-Reference guide

* removed ctx.fail() and replaced it with click.echo() to display the error. Also, references of portchannel is replaced with port channel in the command reference guide

Co-authored-by: Madhan Babu <madhan@arc-build-server.mtr.labs.mlnx>
taras-keryk pushed a commit to taras-keryk/sonic-buildimage that referenced this pull request Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants