Restart ntp after ntp-config #1106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lguohan
approved these changes
Nov 3, 2017
|
Does removing the ntp.service dependency fix the issue that caused Shuotian to revert this change a few days ago (#1102)? |
|
how you verify with this change? |
|
Yes, this fix #1102. |
|
I manually set wrong hwclock on a test device, didn't specify ntp server in minigraph, and re-imaged the box. When it's loaded, the system clock was wrong because ntp was not working. I then manually wrote correct ntp server into configdb, ran |
madhanmellanox
pushed a commit
to madhanmellanox/sonic-buildimage
that referenced
this pull request
Mar 23, 2020
sonic-net#1106) * [aclorch] if vendor does not implement ACL action capability quieries - use default capabilities (do not fail)
abdosi
added a commit
that referenced
this pull request
Sep 19, 2020
Revert "Revert " [201911]show interface counters for multi ASIC devices (#1104)"" Revert "Revert "Pfcstat (#1097)"" [show] Fix 'show int neighbor expected' (#1106) Update argument for docker exec it->i (#1118) Update to make config load/reload backward compatible. (#1115) Handling deletion of Port Channel before deletion of its members (#1062) Skip default route present in ASIC-DB but not in APP-DB. (#1107) [CLI][PFCWD][Multi-ASIC] Added multi ASIC support to 'pfcwd' CLI (#1102) [201911] Multi asic platform config interface portchannel, show transceiver (#1087) [drop counters] Fix configuration for counters with lowercase names (#1103) Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
In ntp-config service, explicitly restart ntp service after generating ntp.conf file