-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Tunnel PFC][Fix bug] Fix bug and Tests for adding property 'sai_remap_prio_on_tnl_egress' #11027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this pr will be merged after #11027 |
6 tasks
lguohan
reviewed
Jun 6, 2022
please rebase the pr and test. |
Add tests for adding property 'sai_remap_prio_on_tnl_egress', this property should only be added in dual tor environment. Test done: Run test test_j2files.py Signed-off-by: richardyu <richardyu@contoso.com>
richardyu-ms
force-pushed
the
add_test_tunnel_remap
branch
from
June 8, 2022 04:45
945debf
to
fdf48f9
Compare
/azp run Azure.sonic-buildimage |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run Azure.sonic-buildimage |
Azure Pipelines successfully started running 1 pipeline(s). |
neethajohn
reviewed
Jun 8, 2022
src/sonic-config-engine/tests/sample_output/py3/arista7260-dualtor.config.bcm
Outdated
Show resolved
Hide resolved
richardyu-ms
changed the title
[Tunnel PFC] Tests for adding property 'sai_remap_prio_on_tnl_egress'
[Tunnel PFC] Fix bug and Tests for adding property 'sai_remap_prio_on_tnl_egress'
Jun 10, 2022
richardyu-ms
force-pushed
the
add_test_tunnel_remap
branch
2 times, most recently
from
June 10, 2022 02:38
07e46c6
to
9f872b3
Compare
Signed-off-by: richardyu <richardyu@contoso.com>
richardyu-ms
force-pushed
the
add_test_tunnel_remap
branch
from
June 10, 2022 02:46
9f872b3
to
aef99e5
Compare
neethajohn
reviewed
Jun 10, 2022
richardyu-ms
changed the title
[Tunnel PFC] Fix bug and Tests for adding property 'sai_remap_prio_on_tnl_egress'
[Tunnel PFC][Fix bug] Fix bug and Tests for adding property 'sai_remap_prio_on_tnl_egress'
Jun 10, 2022
6 tasks
neethajohn
approved these changes
Jun 10, 2022
lguohan
approved these changes
Jun 10, 2022
fix in 202012 merged in b0c48f9 |
richardyu-ms
added a commit
to richardyu-ms/sonic-buildimage
that referenced
this pull request
Jun 11, 2022
…sai_remap_prio_on_tnl_egress' manual cherry-pick from sonic-net#11027 Fix a bug in the template Add tests for adding property 'sai_remap_prio_on_tnl_egress', this property should only be added in dual tor environment.
yxieca
pushed a commit
that referenced
this pull request
Jun 14, 2022
…p_prio_on_tnl_egress' (#11027) * [Tunnel PFC] Tests for adding property 'sai_remap_prio_on_tnl_egress' Add tests for adding property 'sai_remap_prio_on_tnl_egress', this property should only be added in dual tor environment. Test done: Run test test_j2files.py Co-authored-by: richardyu <richardyu@contoso.com>
richardyu-ms
added a commit
that referenced
this pull request
Jun 15, 2022
…sai_remap_prio_on_tnl_egress' (#11099) * [202012][Tunnel PFC][Fix bug] Fix bug and Tests for adding property 'sai_remap_prio_on_tnl_egress' manual cherry-pick from #11027 Fix a bug in the template Add tests for adding property 'sai_remap_prio_on_tnl_egress', this property should only be added in dual tor environment. * merge change after sync from 202012 and remove a mistaken changes in cherry-pick Signed-off-by: richardyu-ms <richard.yu@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
How I did it
Add tests for adding property 'sai_remap_prio_on_tnl_egress'
How to verify it
Which release branch to backport (provide reason below if selected)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)