Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mellanox] Add arch folder to SDK binary location #11278

Merged
merged 2 commits into from
Jun 29, 2022

Conversation

alexrallen
Copy link
Contributor

Why I did it

This is for the eventual support of multiple architectures for the mellanox platform.

How I did it

Change the location of the binaries in Switch-SDK-drivers so that the path specifies the target architecture in addition to the target distribution that the debians are built for.

This is the most straightforward way to separate binaries built against different architectures and selectively target them for installation in the mellanox SONiC image.

How to verify it

Build SONiC for mellanox and verify it compiles successfully.

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205

Description for the changelog

[mellanox] Add arch folder to SDK binary location

A picture of a cute animal (not mandatory but encouraged)

131138

@alexrallen alexrallen requested a review from lguohan as a code owner June 28, 2022 20:02
@liat-grozovik liat-grozovik changed the title [mellanox] Add arch folder to SDK binary location [Mellanox] Add arch folder to SDK binary location Jun 29, 2022
@liat-grozovik liat-grozovik merged commit 3ba9ae2 into sonic-net:master Jun 29, 2022
@yxieca
Copy link
Contributor

yxieca commented Jun 30, 2022

@alexrallen this change cannot be cherry-picked to 202205 branch cleanly, please raise PR if needed.

@alexrallen
Copy link
Contributor Author

@yxieca Can you please cherry-pick #10882 onto 202205 and then cherry-pick my commit? That will keep 202205 appropriately in sync with master.

If not I can raise a PR but I would like to avoid human error in duplicating changes as possible :)

@liat-grozovik
Copy link
Collaborator

@alexrallen can you please also provide guidelines to 202012 and 202111?

qiluo-msft pushed a commit that referenced this pull request Jul 5, 2022
- Why I did it
This is for the eventual support of multiple architectures for the mellanox platform.

- How I did it
Change the location of the binaries in Switch-SDK-drivers so that the path specifies the target architecture in addition to the target distribution that the debians are built for.

This is the most straightforward way to separate binaries built against different architectures and selectively target them for installation in the mellanox SONiC image.

- How to verify it
Build SONiC for mellanox and verify it compiles successfully.
yxieca pushed a commit that referenced this pull request Jul 6, 2022
- Why I did it
This is for the eventual support of multiple architectures for the mellanox platform.

- How I did it
Change the location of the binaries in Switch-SDK-drivers so that the path specifies the target architecture in addition to the target distribution that the debians are built for.

This is the most straightforward way to separate binaries built against different architectures and selectively target them for installation in the mellanox SONiC image.

- How to verify it
Build SONiC for mellanox and verify it compiles successfully.
vivekrnv pushed a commit to vivekrnv/sonic-buildimage that referenced this pull request Aug 1, 2022
- Why I did it
This is for the eventual support of multiple architectures for the mellanox platform.

- How I did it
Change the location of the binaries in Switch-SDK-drivers so that the path specifies the target architecture in addition to the target distribution that the debians are built for.

This is the most straightforward way to separate binaries built against different architectures and selectively target them for installation in the mellanox SONiC image.

- How to verify it
Build SONiC for mellanox and verify it compiles successfully.
liat-grozovik pushed a commit that referenced this pull request Aug 11, 2022
…11598)

- Why I did it
This is for the eventual support of multiple architectures for the mellanox platform.

- How I did it
Change the location of the binaries in Switch-SDK-drivers so that the path specifies the target architecture in addition to the target distribution that the debians are built for.

This is the most straightforward way to separate binaries built against different architectures and selectively target them for installation in the mellanox SONiC image.

- How to verify it
Build SONiC for mellanox and verify it compiles successfully.
skbarista pushed a commit to skbarista/sonic-buildimage that referenced this pull request Aug 17, 2022
- Why I did it
This is for the eventual support of multiple architectures for the mellanox platform.

- How I did it
Change the location of the binaries in Switch-SDK-drivers so that the path specifies the target architecture in addition to the target distribution that the debians are built for.

This is the most straightforward way to separate binaries built against different architectures and selectively target them for installation in the mellanox SONiC image.

- How to verify it
Build SONiC for mellanox and verify it compiles successfully.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants