Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mellanox] [202111] Add arch folder to SDK binary location (#11278) #11598

Merged
merged 3 commits into from
Aug 11, 2022

Conversation

vivekrnv
Copy link
Contributor

@vivekrnv vivekrnv commented Aug 1, 2022

  • Why I did it
    Backport [Mellanox] Add arch folder to SDK binary location #11278 to 202111 .
    This is for the eventual support of multiple architectures for the mellanox platform.

  • How I did it
    Change the location of the binaries in Switch-SDK-drivers so that the path specifies the target architecture in addition to the target distribution that the debians are built for.

This is the most straightforward way to separate binaries built against different architectures and selectively target them for installation in the mellanox SONiC image.

  • How to verify it
    Build SONiC for mellanox and verify it compiles successfully.

- Why I did it
This is for the eventual support of multiple architectures for the mellanox platform.

- How I did it
Change the location of the binaries in Switch-SDK-drivers so that the path specifies the target architecture in addition to the target distribution that the debians are built for.

This is the most straightforward way to separate binaries built against different architectures and selectively target them for installation in the mellanox SONiC image.

- How to verify it
Build SONiC for mellanox and verify it compiles successfully.
@vivekrnv vivekrnv requested a review from lguohan as a code owner August 1, 2022 23:01
@vivekrnv vivekrnv changed the title [Mellanox] Add arch folder to SDK binary location (#11278) [Mellanox] [202111] Add arch folder to SDK binary location (#11278) Aug 1, 2022
@vivekrnv
Copy link
Contributor Author

vivekrnv commented Aug 3, 2022

/azpw run Azure.sonic-buildimage

@mssonicbld
Copy link
Collaborator

/AzurePipelines run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Aug 8, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: alexrallen / name: Alexander Allen (c52e67c)
  • ✅ login: liat-grozovik (e4a480b)

@dgsudharsan
Copy link
Collaborator

@liat-grozovik Can we merge this?

@liat-grozovik liat-grozovik merged commit d14f1a6 into sonic-net:202111 Aug 11, 2022
@vivekrnv vivekrnv deleted the mlnx_sdk_bin_2111 branch August 11, 2022 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants