Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mellanox] Fix issue: failed to decode Json while there is no hwsku.json #11436

Merged
merged 1 commit into from
Jul 14, 2022

Conversation

Junchao-Mellanox
Copy link
Collaborator

Why I did it

Fix bug: pmon report error on start up because some SKUs do not have hwsku.json

How I did it

If hwsku.json, do not extract RJ45 port information

How to verify it

Manual test.
Unit test.

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@liat-grozovik liat-grozovik merged commit 2863945 into sonic-net:master Jul 14, 2022
@Junchao-Mellanox Junchao-Mellanox deleted the decode-json-error branch July 14, 2022 06:26
yxieca pushed a commit that referenced this pull request Jul 29, 2022
…son (#11436)

- Why I did it
Fix bug: pmon report error on start up because some SKUs do not have hwsku.json

- How I did it
If hwsku.json, do not extract RJ45 port information

- How to verify it
Manual test.
Unit test.
skbarista pushed a commit to skbarista/sonic-buildimage that referenced this pull request Aug 17, 2022
…son (sonic-net#11436)

- Why I did it
Fix bug: pmon report error on start up because some SKUs do not have hwsku.json

- How I did it
If hwsku.json, do not extract RJ45 port information

- How to verify it
Manual test.
Unit test.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants