Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mellanox] Fix chassis test issue #11460

Merged
merged 1 commit into from
Jul 17, 2022

Conversation

stephenxs
Copy link
Collaborator

@stephenxs stephenxs commented Jul 16, 2022

Fix compiling issue

=================================== FAILURES =================================== 
____________________ TestChassis.test_get_port_or_cage_type ____________________ 
self = <tests.test_chassis.TestChassis object at 0x7f7e81fecaf0> 
def test_get_port_or_cage_type(self): 
chassis = Chassis() 
> chassis.RJ45_port_list = [0] 
E AttributeError: can't set attribute 
tests/test_chassis.py:289: AttributeError 
=============================== warnings summary ============

It was caused by #11336 but the root cause is that the ci/merge flow of PR #11336 and #11436 interleaved.

Signed-off-by: Stephen Sun stephens@nvidia.com

Why I did it

How I did it

How to verify it

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

Signed-off-by: Stephen Sun <stephens@nvidia.com>
@stephenxs stephenxs marked this pull request as ready for review July 16, 2022 05:38
@prgeor prgeor merged commit 8282d42 into sonic-net:master Jul 17, 2022
@stephenxs stephenxs deleted the fix-chassis-test-issue branch July 17, 2022 03:15
yxieca pushed a commit that referenced this pull request Jul 28, 2022
Signed-off-by: Stephen Sun <stephens@nvidia.com>
skbarista pushed a commit to skbarista/sonic-buildimage that referenced this pull request Aug 17, 2022
Signed-off-by: Stephen Sun <stephens@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants