Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added libpci and pciutils to the pmon docker #12684

Merged

Conversation

assrinivasan
Copy link
Contributor

Why I did it

This is part of a corresponding change to the pcie daemon that enables it to verify PCI peripherals on a platform against a preconfigured YAML file, and enables the pcied daemon to call the system commands needed for PCI peripheral verification

How I did it

Adding aforementioned libraries to the Dockerfile.j2 file

How to verify it

run 'which setpci' from the pmon docker - would show the path of the binary

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205

Description for the changelog

Modified pmon's Dockerfile.j2 to include pciutils and libpci libraries.

Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU.

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

This enables the pcied daemon to call the corresponding system commands needed for pci transactions
@assrinivasan assrinivasan merged commit 7de0450 into sonic-net:master Nov 14, 2022
davidpil2002 pushed a commit to davidpil2002/sonic-buildimage that referenced this pull request Nov 15, 2022
This enables the pcied daemon to call the corresponding system commands needed for pci transactions
@assrinivasan
Copy link
Contributor Author

@prgeor @yxieca Please review my requests for 202012, 202205 and 202211 branches. TIA

@prgeor
Copy link
Contributor

prgeor commented Feb 14, 2023

@qiluo-msft if you can cherry pick to 202012
@StormLiangMS if you can cherry pick to 202211

@mssonicbld
Copy link
Collaborator

@assrinivasan PR conflicts with 202211 branch

mssonicbld pushed a commit to mssonicbld/sonic-buildimage that referenced this pull request Feb 21, 2023
This enables the pcied daemon to call the corresponding system commands needed for pci transactions
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202205: #13900

mssonicbld pushed a commit that referenced this pull request Feb 21, 2023
This enables the pcied daemon to call the corresponding system commands needed for pci transactions
assrinivasan added a commit to assrinivasan/sonic-buildimage that referenced this pull request Mar 2, 2023
This enables the pcied daemon to call the corresponding system commands needed for pci transactions
liuh-80 pushed a commit to liuh-80/sonic-buildimage that referenced this pull request Mar 2, 2023
This enables the pcied daemon to call the corresponding system commands needed for pci transactions
assrinivasan added a commit to assrinivasan/sonic-buildimage that referenced this pull request Mar 2, 2023
This enables the pcied daemon to call the corresponding system commands needed for pci transactions
@assrinivasan
Copy link
Contributor Author

PR to cherry-pick to 202012 branch: #14056

qiluo-msft pushed a commit that referenced this pull request Mar 9, 2023
#### Why I did it

This is part of a corresponding change to the pcie daemon that enables it to verify PCI peripherals on a platform against a preconfigured YAML file, and enables the pcied daemon to call the system commands needed for PCI peripheral verification

#### How I did it
Adding aforementioned libraries to the Dockerfile.j2 file

#### How to verify it
run 'which setpci' from the pmon docker - would show the path of the binary

#### Description for the changelog

Modified pmon's Dockerfile.j2 to include pciutils and libpci libraries.

**cherry-pick of SHA: 7de0450**
@StormLiangMS
Copy link
Contributor

@assrinivasan pls create PR for 202211, cherry-pick failed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants