Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Seastone] fix dx010 qsfp eeprom data write issue #13930

Merged
merged 1 commit into from
Mar 1, 2023

Conversation

qnos
Copy link
Contributor

@qnos qnos commented Feb 22, 2023

Why I did it

Platform cases test_tx_disable, test_tx_disable_channel, test_power_override failed in dx010.

How I did it

Add i2c access algorithm for CPLD i2c adapters.

How to verify it

Verify it with platform_tests/api/test_sfp.py::TestSfpApi test cases.

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211

Description for the changelog

Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU.

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@qnos qnos requested a review from lguohan as a code owner February 22, 2023 10:52
@qnos
Copy link
Contributor Author

qnos commented Feb 22, 2023

@prgeor @assrinivasan Please help review it.

@prgeor
Copy link
Contributor

prgeor commented Feb 22, 2023

@lguohan to merge

@prgeor
Copy link
Contributor

prgeor commented Feb 22, 2023

@qnos please check the build failures. it could be flaky...try re-trigger of the build

Why I did it
test_tx_disable, test_tx_disable_channel, test_power_override failed in dx010.

How I did it
Add i2c access algorithm for CPLD i2c adapters.

How to verify it
Verify it with platform_tests/api/test_sfp.py::TestSfpApi test cases.

Signed-off-by: Eric Zhu <erzhu@celestica.com>
@qnos qnos force-pushed the dx010-qsfp-eeprom-access-fix branch from b95e0d5 to d693ecc Compare February 23, 2023 00:37
@lguohan
Copy link
Collaborator

lguohan commented Feb 23, 2023

@prgeor , can you add tagging accordingly?

@prgeor
Copy link
Contributor

prgeor commented Feb 23, 2023

@lguohan updated the labels. merge?

Copy link
Contributor

@StormLiangMS StormLiangMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@StormLiangMS StormLiangMS merged commit f801b8f into sonic-net:master Mar 1, 2023
mssonicbld pushed a commit to mssonicbld/sonic-buildimage that referenced this pull request Mar 1, 2023
Why I did it
Platform cases test_tx_disable, test_tx_disable_channel, test_power_override failed in dx010.

How I did it
Add i2c access algorithm for CPLD i2c adapters.

How to verify it
Verify it with platform_tests/api/test_sfp.py::TestSfpApi test cases.
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202211: #14032

mssonicbld pushed a commit to mssonicbld/sonic-buildimage that referenced this pull request Mar 1, 2023
Why I did it
Platform cases test_tx_disable, test_tx_disable_channel, test_power_override failed in dx010.

How I did it
Add i2c access algorithm for CPLD i2c adapters.

How to verify it
Verify it with platform_tests/api/test_sfp.py::TestSfpApi test cases.
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202205: #14042

qiluo-msft pushed a commit that referenced this pull request Mar 2, 2023
Why I did it
Platform cases test_tx_disable, test_tx_disable_channel, test_power_override failed in dx010.

How I did it
Add i2c access algorithm for CPLD i2c adapters.

How to verify it
Verify it with platform_tests/api/test_sfp.py::TestSfpApi test cases.
mssonicbld pushed a commit that referenced this pull request Mar 6, 2023
Why I did it
Platform cases test_tx_disable, test_tx_disable_channel, test_power_override failed in dx010.

How I did it
Add i2c access algorithm for CPLD i2c adapters.

How to verify it
Verify it with platform_tests/api/test_sfp.py::TestSfpApi test cases.
qiluo-msft pushed a commit that referenced this pull request Mar 6, 2023
Why I did it
Platform cases test_tx_disable, test_tx_disable_channel, test_power_override failed in dx010.

How I did it
Add i2c access algorithm for CPLD i2c adapters.

How to verify it
Verify it with platform_tests/api/test_sfp.py::TestSfpApi test cases.
xumia pushed a commit to xumia/sonic-buildimage-1 that referenced this pull request Mar 10, 2023
Why I did it
Platform cases test_tx_disable, test_tx_disable_channel, test_power_override failed in dx010.

How I did it
Add i2c access algorithm for CPLD i2c adapters.

How to verify it
Verify it with platform_tests/api/test_sfp.py::TestSfpApi test cases.
github-actions bot pushed a commit to liushilongbuaa/sonic-buildimage that referenced this pull request Aug 29, 2023
Why I did it
Platform cases test_tx_disable, test_tx_disable_channel, test_power_override failed in dx010.

How I did it
Add i2c access algorithm for CPLD i2c adapters.

How to verify it
Verify it with platform_tests/api/test_sfp.py::TestSfpApi test cases.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants