You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We suspect the issue #13791 is caused by redis server being temporarily unavailable during system initialization so we do not use -d in sonic-cfggen, for now, to avoid accessing redis server
Provide a string containing required json data when calling sonic-cfggen
How to verify it
Manually test it
Which release branch to backport (provide reason below if selected)
201811
201911
202006
202012
202106
202111
202205
202211
Description for the changelog
Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU.
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)
We suspect the issue is caused by redis server temporarily unavailable so we do not use -d in sonic-cfggen for now
Signed-off-by: Stephen Sun <stephens@nvidia.com>
@stephenxs was this approach should be taken in other places in the code? do we have an issue in github to track the issue?
Hi @liat-grozovik
We have an issue #13791
Theoretically, the issue can occur wherever redis-server is accessed, but so far we have observed similar issue only in rsyslog.conf in teamd #13674 and there is a WA for it as well.
So I do not think we need to change the code everywhere redis-server is accessed.
Meanwhile, I'm not 100% confident that the issue is caused by redis-server not being accessible. Another PR to collect other info into sonic-dump (sonic-net/sonic-utilities#2686) is also opened
…onic-net#13888)
- Why I did it
We suspect the issue sonic-net#13791 is caused by redis server being temporarily unavailable during system initialization so we do not use -d in sonic-cfggen, for now, to avoid accessing redis server
- How I did it
Provide a string containing required json data when calling sonic-cfggen
- How to verify it
Manually test it
Signed-off-by: Stephen Sun <stephens@nvidia.com>
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mssonicbld
added
Included in 202211 Branch
and removed
Approved for 202211 Branch
Created PR to 202211 Branch
labels
Why I did it
We suspect the issue #13791 is caused by redis server being temporarily unavailable during system initialization so we do not use -d in sonic-cfggen, for now, to avoid accessing redis server
Signed-off-by: Stephen Sun stephens@nvidia.com
How I did it
Provide a string containing required json data when calling
sonic-cfggenHow to verify it
Manually test it
Which release branch to backport (provide reason below if selected)
Description for the changelog
Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU.
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)