Enhance the error message output mechanism when swss docker is created #14384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enhance the error message output mechanism during swss docker creating Signed-off-by: Stephen Sun <stephens@nvidia.com>
|
Hi @qiluo-msft |
8 tasks
qiluo-msft
approved these changes
Apr 7, 2023
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
Apr 20, 2023
#### Why I did it Enhance the error message output mechanism during swss docker creating #### How I did it Capture the output to stderr of `sonic-cfggen` and output it using `echo` to make sure the error message will be logged in syslog. #### How to verify it Manually test
|
Cherry-pick PR to 202211: #14766 |
mssonicbld
pushed a commit
that referenced
this pull request
Apr 23, 2023
#### Why I did it Enhance the error message output mechanism during swss docker creating #### How I did it Capture the output to stderr of `sonic-cfggen` and output it using `echo` to make sure the error message will be logged in syslog. #### How to verify it Manually test
mssonicbld
added
Included in 202211 Branch
and removed
Approved for 202211 Branch
Created PR to 202211 Branch
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
Enhance the error message output mechanism during swss docker creating
Signed-off-by: Stephen Sun stephens@nvidia.com
How I did it
Capture the output to stderr of
sonic-cfggenand output it usingechoto make sure the error message will be logged in syslog.How to verify it
Manually test
Which release branch to backport (provide reason below if selected)
Description for the changelog
Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU.
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)