-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[installer]: support new onie machine.conf format #1468
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As comment
installer/x86_64/install.sh
Outdated
if [ -f /etc/machine-build.conf ]; then | ||
# onie_ variable are generate at runtime. | ||
# they are no longer hardcoded in /etc/machine.conf | ||
set | grep onie_ > $demo_mnt/machine.conf |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why use 'set' instead of 'env'?
Suggest grep 'onie_' at the line beginning. Maybe
env | grep ^onie_
Not sure it is available in ONIE environment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since the variables are not exported, so they are not env
onie_* variable are generated at runtime in /etc/machine.conf. We can no longer copy the static machine.conf into sonic image.
Signed-off-by: Guohan Lu <gulv@microsoft.com>
/host/machine.conf is incorrent for other application. Please remove quote. |
9e740759c370645b4367acf22856aebcfb7fce45 (HEAD -> 201911, origin/201911) [201911][multi asic] show ip bgp summary changes for bgp mon (#1483) fa07245786df11e6df902c33fcd9c7115a7c5380 [CLI][techsupport] Merge 'show techsupport' changes from master (#1468) Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
onie_* variable are generated at runtime in /etc/machine.conf.
We can no longer copy the static machine.conf into sonic image.
- What I did
support new onie machine.conf format
- How I did it
export the onie_* varilable into sonic static machine.conf
- How to verify it
alphanetwork validated.
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)