/host/machine.conf is incorrent

[fillmorechen0928]

Please refer
#1404

Original /host/machine.conf:

onie_version=master-201802221653.0.1-dirty
onie_vendor_id=31874
onie_build_machine=alphanetworks_snh60b0_640f
onie_machine_rev=0
onie_arch=x86_64
onie_build_platform=x86_64-alphanetworks_snh60b0_640f-r0
onie_config_version=1
onie_build_date="2018-02-22T16:53+0800"
onie_partition_type=gpt
onie_kernel_version=3.14.27
onie_firmware=bios
onie_switch_asic=bcm
onie_skip_ethmgmt_macs=no
onie_grub_image_name=grubx64.efi
onie_machine=alphanetworks_snh60b0_640f
onie_platform=x86_64-alphanetworks_snh60b0_640f-r0

Current /host/machine.conf:
onie_arch='x86_64'
onie_bin=''
onie_boot_reason='rescue'
onie_build_date='2018-01-23T19:05+0800'
onie_build_machine='alphanetworks_snh60b0_640f'
onie_cli_static_parms=''
onie_cli_static_url='sonic-broadcom.bin'
onie_config_version='1'
onie_dev='/dev/sda2'
onie_exec_url='sonic-broadcom.bin'
onie_firmware='bios'
onie_grub_image_name='grubx64.efi'
onie_initrd_tmp='/'
onie_installer='/var/tmp/installer'
onie_kernel_version='3.14.27'
onie_machine='alphanetworks_snh60b0_640f'
onie_machine_rev='0'
onie_partition_type='gpt'
onie_platform='x86_64-alphanetworks_snh60b0_640f-r0'
onie_root_dir='/mnt/onie-boot/onie'
onie_skip_ethmgmt_macs='no'
onie_switch_asic='bcm'
onie_vendor_id='31874'
onie_version='master-201801231905.0.1-dirty'

Please remove quote.

It cause path with more quotes for other APP in SONIC.

[lguohan]

the original /host/machine.conf and current /host/machine.conf seems to have different onie_version

original:
onie_version=master-201802221653.0.1-dirty

current:
onie_version='master-201801231905.0.1-dirty'

also in #1404, you said it works, so something has changed. It seems your current onie version is older than the original version. I suspect it is an onie issue. Can you check which onie you are going to use?

[fillmorechen0928]

The difference is Original /host/machine.conf and Current /host/machine.conf.

ONIE's machine.conf is the same as onie_machine.zip (#1404)

[fillmorechen0928]

The problem is how you generating "/host/machine.conf".

[fillmorechen0928]

ONIE's machine.conf is the same as onie_machine.zip (#1404).

Before (#1404) /host/machine.conf
and after (#1404) /host/machine.conf
should be the same format.

[fillmorechen0928]

The result of "set | grep ^onie_ > $demo_mnt/machine.conf" command is different from "cp /etc/machine.conf $demo_mnt" .

[lguohan]

#1404 is based on your request, and you have verified the PR and said it works. If it is not working now, then something has changed. In the example you given, you are using different onie versions. I verified the 'set | grep ^onie_ > $demo_mnt/machine.conf', it does not generate quote on my machine.

[fillmorechen0928]

PR #1468 is working for #1404 issue. sonic_installer problem is fixed.

[fillmorechen0928]

But PR #1468 generate #1519 found by other team member.

I will verifiy the 'set | grep ^onie_ > $demo_mnt/machine.conf' on my device.

[fillmorechen0928]

I verified the 'set | grep ^onie_ > $demo_mnt/machine.conf', it generates quote on my machine.

[fillmorechen0928]

1. Boot up with ONIE and show machine.conf.

2. show machine-build.conf

3. Execute machine.conf

4. Show the result of 'set | grep ^onie_ > /tmp/machine.conf', it generates quote on my machine.

[lguohan]

can you check your onie version. master-201802221653.0.1-dirty, according to you log above, that one does not have quote.

[fillmorechen0928]

The file machine-build.conf does not have quote.

But the "set" command has quote.

[fillmorechen0928]

#1404 has the attachment files onie_machine.zip

[lguohan]

Original /host/machine.conf:

onie_version=master-201802221653.0.1-dirty
onie_vendor_id=31874
onie_build_machine=alphanetworks_snh60b0_640f
onie_machine_rev=0
onie_arch=x86_64
onie_build_platform=x86_64-alphanetworks_snh60b0_640f-r0
onie_config_version=1
onie_build_date="2018-02-22T16:53+0800"
onie_partition_type=gpt
onie_kernel_version=3.14.27
onie_firmware=bios
onie_switch_asic=bcm
onie_skip_ethmgmt_macs=no
onie_grub_image_name=grubx64.efi
onie_machine=alphanetworks_snh60b0_640f
onie_platform=x86_64-alphanetworks_snh60b0_640f-r0

[lguohan]

this one does not have quote.

[fillmorechen0928]

Don't care about master-201802221653.0.1-dirty version.

This is workaround version for SONIC issue. It's /host/machine.conf does not have quote due to generating from "cp /etc/machine.conf $demo_mnt" .

[fillmorechen0928]

The command 'set | grep ^onie_ > $demo_mnt/machine.conf', it generates quote.

[lguohan]

can you check if this works for you?

set | grep ^onie |  sed -e "s/='/=/" -e "s/'$//"

[fillmorechen0928]

Yes, it is work.

The test result:

1. Execute machine.conf
   

2. Show the result of 'set | grep ^onie | sed -e "s/='/=/" -e "s/'$//"', it does not generate quote on my machine.