Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[yang][dhcp_server] Add dhcp_server_ipv4 yang model #15955

Merged
merged 8 commits into from
Aug 28, 2023

Conversation

yaqiangz
Copy link
Contributor

@yaqiangz yaqiangz commented Jul 25, 2023

Why I did it

Work item tracking
  • Microsoft ADO (number only): 24598412

How I did it

Add yang model for IPv4 DHCP Server.
Add four new tables: DHCP_SERVER_IPV4, DHCP_SERVER_IPV4_CUSTOMIZED_OPTIONS, DHCP_SERVER_IPV4_RANGE, DHCP_SERVER_IPV4_PORT

HLD: https://github.com/yaqiangz/SONiC/blob/master_dhcp_server_hld/doc/dhcp_server/port_based_dhcp_server_high_level_design.md#rev-01

How to verify it

Build sonic_yang_models packages.

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@yaqiangz yaqiangz force-pushed the azure-master_dhcp_yang_2 branch 6 times, most recently from 70e082f to 780fb3c Compare July 25, 2023 08:25
@yaqiangz yaqiangz force-pushed the azure-master_dhcp_yang_2 branch 2 times, most recently from ef64fcc to 12a95c9 Compare July 26, 2023 07:26
@yaqiangz yaqiangz force-pushed the azure-master_dhcp_yang_2 branch from 12a95c9 to 088d84d Compare July 26, 2023 07:47
@yaqiangz
Copy link
Contributor Author

/azpw run

@mssonicbld
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list.

@yaqiangz
Copy link
Contributor Author

yaqiangz commented Aug 2, 2023

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 15955 in repo sonic-net/sonic-buildimage

@yaqiangz
Copy link
Contributor Author

yaqiangz commented Aug 2, 2023

/azpw run Azure.sonic-buildimage

@mssonicbld
Copy link
Collaborator

/AzurePipelines run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/AzurePipelines run Azure.sonic-buildimage (Build broadcom)

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

@yaqiangz yaqiangz marked this pull request as ready for review August 16, 2023 11:57
@yaqiangz yaqiangz requested a review from qiluo-msft as a code owner August 16, 2023 11:57
@yaqiangz yaqiangz force-pushed the azure-master_dhcp_yang_2 branch 2 times, most recently from 3068bf9 to c33d97f Compare August 17, 2023 05:13
@yaqiangz yaqiangz force-pushed the azure-master_dhcp_yang_2 branch from c33d97f to 73238a4 Compare August 17, 2023 05:15
@yaqiangz yaqiangz requested a review from ganglyu August 18, 2023 04:32
@qiluo-msft qiluo-msft added the YANG YANG model related changes label Aug 21, 2023
@yxieca yxieca merged commit 44d52db into sonic-net:master Aug 28, 2023
wen587 added a commit to wen587/sonic-buildimage that referenced this pull request Aug 29, 2023
yxieca pushed a commit that referenced this pull request Aug 31, 2023
Why I did it
#15955 import sonic-vlan in yang model, which would cause YANG backlink issue. So #15955 was reverted by #16322.
This PR is re-submitted of #15955 without import sonic-vlan.
Add yang model for IPv4 DHCP Server.

How I did it
Add yang model for IPv4 DHCP Server.
Add four new tables: DHCP_SERVER_IPV4, DHCP_SERVER_IPV4_CUSTOMIZED_OPTIONS, DHCP_SERVER_IPV4_RANGE, DHCP_SERVER_IPV4_PORT.
Add related unit test.

HLD: https://github.com/yaqiangz/SONiC/blob/master_dhcp_server_hld/doc/dhcp_server/port_based_dhcp_server_high_level_design.md#rev-01

How to verify it
Build sonic_yang_models packages.
sonic-otn pushed a commit to sonic-otn/sonic-buildimage that referenced this pull request Sep 20, 2023
Add yang model for IPv4 DHCP Server.
Add four new tables: DHCP_SERVER_IPV4, DHCP_SERVER_IPV4_CUSTOMIZED_OPTIONS, DHCP_SERVER_IPV4_RANGE, DHCP_SERVER_IPV4_PORT
sonic-otn pushed a commit to sonic-otn/sonic-buildimage that referenced this pull request Sep 20, 2023
sonic-otn pushed a commit to sonic-otn/sonic-buildimage that referenced this pull request Sep 20, 2023
Why I did it
sonic-net#15955 import sonic-vlan in yang model, which would cause YANG backlink issue. So sonic-net#15955 was reverted by sonic-net#16322.
This PR is re-submitted of sonic-net#15955 without import sonic-vlan.
Add yang model for IPv4 DHCP Server.

How I did it
Add yang model for IPv4 DHCP Server.
Add four new tables: DHCP_SERVER_IPV4, DHCP_SERVER_IPV4_CUSTOMIZED_OPTIONS, DHCP_SERVER_IPV4_RANGE, DHCP_SERVER_IPV4_PORT.
Add related unit test.

HLD: https://github.com/yaqiangz/SONiC/blob/master_dhcp_server_hld/doc/dhcp_server/port_based_dhcp_server_high_level_design.md#rev-01

How to verify it
Build sonic_yang_models packages.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
YANG YANG model related changes
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

6 participants