-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[yang][dhcp_server] Add dhcp_server_ipv4 yang model #15955
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaqiangz
force-pushed
the
azure-master_dhcp_yang_2
branch
6 times, most recently
from
July 25, 2023 08:25
70e082f
to
780fb3c
Compare
yaqiangz
force-pushed
the
azure-master_dhcp_yang_2
branch
2 times, most recently
from
July 26, 2023 07:26
ef64fcc
to
12a95c9
Compare
yaqiangz
force-pushed
the
azure-master_dhcp_yang_2
branch
from
July 26, 2023 07:47
12a95c9
to
088d84d
Compare
/azpw run |
/AzurePipelines run |
You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list. |
/azp run Azure.sonic-buildimage |
Commenter does not have sufficient privileges for PR 15955 in repo sonic-net/sonic-buildimage |
/azpw run Azure.sonic-buildimage |
/AzurePipelines run Azure.sonic-buildimage |
Azure Pipelines successfully started running 1 pipeline(s). |
/AzurePipelines run Azure.sonic-buildimage (Build broadcom) |
No pipelines are associated with this pull request. |
ganglyu
reviewed
Aug 17, 2023
ganglyu
reviewed
Aug 17, 2023
ganglyu
reviewed
Aug 17, 2023
ganglyu
reviewed
Aug 17, 2023
yaqiangz
force-pushed
the
azure-master_dhcp_yang_2
branch
2 times, most recently
from
August 17, 2023 05:13
3068bf9
to
c33d97f
Compare
yaqiangz
force-pushed
the
azure-master_dhcp_yang_2
branch
from
August 17, 2023 05:15
c33d97f
to
73238a4
Compare
ganglyu
approved these changes
Aug 21, 2023
Blueve
approved these changes
Aug 28, 2023
qiluo-msft
pushed a commit
that referenced
this pull request
Aug 29, 2023
11 tasks
yxieca
pushed a commit
that referenced
this pull request
Aug 31, 2023
Why I did it #15955 import sonic-vlan in yang model, which would cause YANG backlink issue. So #15955 was reverted by #16322. This PR is re-submitted of #15955 without import sonic-vlan. Add yang model for IPv4 DHCP Server. How I did it Add yang model for IPv4 DHCP Server. Add four new tables: DHCP_SERVER_IPV4, DHCP_SERVER_IPV4_CUSTOMIZED_OPTIONS, DHCP_SERVER_IPV4_RANGE, DHCP_SERVER_IPV4_PORT. Add related unit test. HLD: https://github.com/yaqiangz/SONiC/blob/master_dhcp_server_hld/doc/dhcp_server/port_based_dhcp_server_high_level_design.md#rev-01 How to verify it Build sonic_yang_models packages.
sonic-otn
pushed a commit
to sonic-otn/sonic-buildimage
that referenced
this pull request
Sep 20, 2023
Add yang model for IPv4 DHCP Server. Add four new tables: DHCP_SERVER_IPV4, DHCP_SERVER_IPV4_CUSTOMIZED_OPTIONS, DHCP_SERVER_IPV4_RANGE, DHCP_SERVER_IPV4_PORT
sonic-otn
pushed a commit
to sonic-otn/sonic-buildimage
that referenced
this pull request
Sep 20, 2023
…t#15955)" (sonic-net#16322) This reverts commit 44d52db.
sonic-otn
pushed a commit
to sonic-otn/sonic-buildimage
that referenced
this pull request
Sep 20, 2023
Why I did it sonic-net#15955 import sonic-vlan in yang model, which would cause YANG backlink issue. So sonic-net#15955 was reverted by sonic-net#16322. This PR is re-submitted of sonic-net#15955 without import sonic-vlan. Add yang model for IPv4 DHCP Server. How I did it Add yang model for IPv4 DHCP Server. Add four new tables: DHCP_SERVER_IPV4, DHCP_SERVER_IPV4_CUSTOMIZED_OPTIONS, DHCP_SERVER_IPV4_RANGE, DHCP_SERVER_IPV4_PORT. Add related unit test. HLD: https://github.com/yaqiangz/SONiC/blob/master_dhcp_server_hld/doc/dhcp_server/port_based_dhcp_server_high_level_design.md#rev-01 How to verify it Build sonic_yang_models packages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
Work item tracking
How I did it
Add yang model for IPv4 DHCP Server.
Add four new tables: DHCP_SERVER_IPV4, DHCP_SERVER_IPV4_CUSTOMIZED_OPTIONS, DHCP_SERVER_IPV4_RANGE, DHCP_SERVER_IPV4_PORT
HLD: https://github.com/yaqiangz/SONiC/blob/master_dhcp_server_hld/doc/dhcp_server/port_based_dhcp_server_high_level_design.md#rev-01
How to verify it
Build sonic_yang_models packages.
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)