Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[yang][dhcp_server] Add dhcp_server_ipv4 yang model #16327

Merged

Conversation

yaqiangz
Copy link
Contributor

@yaqiangz yaqiangz commented Aug 30, 2023

Why I did it

#15955 import sonic-vlan in yang model, which would cause YANG backlink issue. So #15955 was reverted by #16322.

This PR is re-submitted of #15955 without import sonic-vlan.

Add yang model for IPv4 DHCP Server.

Work item tracking
  • Microsoft ADO (number only): 24905905

How I did it

Add yang model for IPv4 DHCP Server.
Add four new tables: DHCP_SERVER_IPV4, DHCP_SERVER_IPV4_CUSTOMIZED_OPTIONS, DHCP_SERVER_IPV4_RANGE, DHCP_SERVER_IPV4_PORT.
Add related unit test.

HLD: https://github.com/yaqiangz/SONiC/blob/master_dhcp_server_hld/doc/dhcp_server/port_based_dhcp_server_high_level_design.md#rev-01

How to verify it

Build sonic_yang_models packages.

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@yaqiangz yaqiangz force-pushed the azure-master_dhcp_server_ipv4_yang branch 5 times, most recently from 43b64cd to fd102b0 Compare August 30, 2023 02:32
@yaqiangz yaqiangz force-pushed the azure-master_dhcp_server_ipv4_yang branch from fd102b0 to edbc2bc Compare August 30, 2023 02:42
@yaqiangz yaqiangz marked this pull request as ready for review August 30, 2023 04:39
@yaqiangz yaqiangz requested a review from qiluo-msft as a code owner August 30, 2023 04:39
@yaqiangz yaqiangz requested a review from ganglyu August 30, 2023 06:35
@yaqiangz yaqiangz requested a review from Blueve August 30, 2023 07:05
@yaqiangz
Copy link
Contributor Author

@yxieca Could you pls help to merge this PR?

@yxieca yxieca merged commit 110dc1e into sonic-net:master Aug 31, 2023
sonic-otn pushed a commit to sonic-otn/sonic-buildimage that referenced this pull request Sep 20, 2023
Why I did it
sonic-net#15955 import sonic-vlan in yang model, which would cause YANG backlink issue. So sonic-net#15955 was reverted by sonic-net#16322.
This PR is re-submitted of sonic-net#15955 without import sonic-vlan.
Add yang model for IPv4 DHCP Server.

How I did it
Add yang model for IPv4 DHCP Server.
Add four new tables: DHCP_SERVER_IPV4, DHCP_SERVER_IPV4_CUSTOMIZED_OPTIONS, DHCP_SERVER_IPV4_RANGE, DHCP_SERVER_IPV4_PORT.
Add related unit test.

HLD: https://github.com/yaqiangz/SONiC/blob/master_dhcp_server_hld/doc/dhcp_server/port_based_dhcp_server_high_level_design.md#rev-01

How to verify it
Build sonic_yang_models packages.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants