Fix the dependency grpcio-tools version #16776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saiarcot895
reviewed
Oct 4, 2023
| # For building sonic_ycabled | ||
| # Note: upstream build breaks with old version of setuptools | ||
| # ref: https://github.com/grpc/grpc/issues/34569 | ||
| RUN pip3 install grpcio==1.58.0 grpcio-tools==1.58.0 |
There was a problem hiding this comment.
Looks like the dockers and the base image are on GRPC 1.39.0. Do we want to use that version instead?
There was a problem hiding this comment.
If the current situation is truly any version, it is using relative newer version until recent build broken. So I prefer not to change situation dramatically.
saiarcot895
approved these changes
Oct 4, 2023
|
@StormLiangMS @yxieca please help backport this patch. ADO: 25396344 |
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
Oct 9, 2023
#### Why I did it Fix the build break of marvell-armhf/sonic-ycabled
|
Cherry-pick PR to 202305: #16809 |
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
Oct 9, 2023
#### Why I did it Fix the build break of marvell-armhf/sonic-ycabled
11 tasks
|
Cherry-pick PR to 202211: #16810 |
11 tasks
mssonicbld
added a commit
that referenced
this pull request
Oct 9, 2023
mssonicbld
added
Included in 202211 Branch
and removed
Approved for 202211 Branch
Created PR to 202211 Branch
labels
mssonicbld
added a commit
that referenced
this pull request
Oct 9, 2023
mssonicbld
added
Included in 202305 Branch
and removed
Created PR to 202305 Branch
labels
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
Oct 9, 2023
#### Why I did it Fix the build break of marvell-armhf/sonic-ycabled
|
Cherry-pick PR to 202205: #16816 |
11 tasks
mssonicbld
pushed a commit
that referenced
this pull request
Oct 10, 2023
#### Why I did it Fix the build break of marvell-armhf/sonic-ycabled
mssonicbld
added
Included in 202205 Branch
and removed
Approved for 202205 Branch
Created PR to 202205 Branch
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
Fix the build break of marvell-armhf/sonic-ycabled
Upstream build breaks with old version of setuptools
ref: grpc/grpc#34569
Work item tracking
How I did it
How to verify it
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)