Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the dependency grpcio-tools version #16776

Merged
merged 1 commit into from
Oct 4, 2023
+5 −0
Merged

Fix the dependency grpcio-tools version #16776

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions sonic-slave-bullseye/Dockerfile.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -501,6 +501,11 @@ RUN patch -p1 -i /disable-non-manylinux.patch /usr/local/lib/python3.9/dist-pack
# For building sonic-utilities
RUN pip3 install fastentrypoints mock

# For building sonic_ycabled
# Note: upstream build breaks with old version of setuptools
# ref: https://github.com/grpc/grpc/issues/34569
RUN pip3 install grpcio==1.58.0 grpcio-tools==1.58.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the dockers and the base image are on GRPC 1.39.0. Do we want to use that version instead?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the current situation is truly any version, it is using relative newer version until recent build broken. So I prefer not to change situation dramatically.


# For running Python unit tests
RUN pip3 install pytest-runner==5.2
RUN pip3 install nose==1.3.7
Expand Down