Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docker_image_ctl]: Add --force while removing obsolete dockers #1744

Merged
merged 1 commit into from
May 26, 2018
Merged

[docker_image_ctl]: Add --force while removing obsolete dockers #1744

merged 1 commit into from
May 26, 2018

Conversation

stcheng
Copy link
Contributor

@stcheng stcheng commented May 25, 2018 •
edited
Loading 

You cannot remove a running container 4018a005a31e951cf5062d82e568ed2704bd82b6089e72327ecaeadfc3101b12. Stop the container before attempting removal or use -f"

@stcheng stcheng requested a review from yxieca May 25, 2018 21:33
@lguohan lguohan merged commit 46c2d34 into sonic-net:master May 26, 2018
lguohan pushed a commit that referenced this pull request May 26, 2018
@lguohan
[docker_image_ctl]: Add --force while removing obsolete dockers (#1744)
188afc1
@stcheng stcheng deleted the shuotian/force branch May 26, 2018 21:16
volodymyrsamotiy added a commit to volodymyrsamotiy/sonic-buildimage that referenced this pull request May 28, 2021
@volodymyrsamotiy
[swss] Update submodule pointer
9500cda 
dad1287 [tunneldecaporch] Set default MTU for the overlay loopback interface (sonic-net#1756)
1bc94d1 [orchagent] Fix typo in PortsOrch::initPortSupportedSpeeds (sonic-net#1755)
a44e651 [nhg]: Add support for weight in nexthop group member. (sonic-net#1752)
5c625b2 [Bulk mode] Limit the size of bulker (sonic-net#1744)
d1cd0fd Fix error msg due to not supported "SAI_SWITCH_ATTR_MAX_NUMBER_OF_TEMP_SENSORS"  attributes (sonic-net#1745)
278770d [sub intf] Fix kernel side processing to enslave sub interface to non-default vrf (sonic-net#1521)
031f536 support flush FDB entries per port and per vlan (sonic-net#1064)
3629d70 [sonic-swss] Add port auto negotiation support to swss (sonic-net#1714)
7c6ebb1 [fix] Use the same storm detection condition for queue occupancy non-zero case as the zero case (sonic-net#1111)
fb06c32 [fabricportsorch] Add fabric support (sonic-net#1459)

Signed-off-by: Volodymyr Samotiy <volodymyrs@nvidia.com>
@volodymyrsamotiy volodymyrsamotiy mentioned this pull request May 28, 2021
Merged
4 tasks
@Junchao-Mellanox Junchao-Mellanox mentioned this pull request May 31, 2021
Closed
4 tasks
liat-grozovik pushed a commit that referenced this pull request May 31, 2021
@volodymyrsamotiy
[swss] Update submodule pointer (#7748)
f8b3265 
dad1287 [tunneldecaporch] Set default MTU for the overlay loopback interface (#1756)
1bc94d1 [orchagent] Fix typo in PortsOrch::initPortSupportedSpeeds (#1755)
a44e651 [nhg]: Add support for weight in nexthop group member. (#1752)
5c625b2 [Bulk mode] Limit the size of bulker (#1744)
d1cd0fd Fix error msg due to not supported "SAI_SWITCH_ATTR_MAX_NUMBER_OF_TEMP_SENSORS"  attributes (#1745)
278770d [sub intf] Fix kernel side processing to enslave sub interface to non-default vrf (#1521)
031f536 support flush FDB entries per port and per vlan (#1064)
3629d70 [sonic-swss] Add port auto negotiation support to swss (#1714)
7c6ebb1 [fix] Use the same storm detection condition for queue occupancy non-zero case as the zero case (#1111)
fb06c32 [fabricportsorch] Add fabric support (#1459)

Signed-off-by: Volodymyr Samotiy <volodymyrs@nvidia.com>
yxieca added a commit to yxieca/sonic-buildimage that referenced this pull request Aug 5, 2021
@yxieca
[202012][utilities] advance sonic-utilities submodule head
1c410cd 
To include following changes:

* d84a8cc 2021-08-05 | [fast-reboot] revert the change of disabling counter polling before fast-reboot (sonic-net#1744) (HEAD -> 202012, github/202012) [Ying Xie]
* e900bc5 2021-08-04 | Add script null_route_helper (sonic-net#1718) [bingwang-ms]
* 85f14e1 2021-08-02 | disk_check updates: (sonic-net#1736) [Renuka Manavalan]
* d68ac1c 2021-05-27 | [console][show] Force refresh all lines status during show line (sonic-net#1641) [Blueve]
* a0e417f 2021-04-25 | [console] Display success message after line cleared (sonic-net#1579) [Blueve]
* 0c6bb27 2021-04-07 | [console] Include Flow Control status in show line result (sonic-net#1549) [Blueve]
@yxieca yxieca mentioned this pull request Aug 5, 2021
Merged
@yxieca yxieca mentioned this pull request Aug 5, 2021
Merged
yxieca added a commit to yxieca/sonic-buildimage that referenced this pull request Aug 6, 2021
@yxieca
[utilities] advance utilities submodule head
0ecd579 
Advance utilities submodule head to include:
* b540f5f 2021-08-05 | [fast-reboot] revert the change of disabling counter polling before fast-reboot (sonic-net#1744) (HEAD -> master, github/master) [Ying Xie]

Signed-off-by: Ying Xie <ying.xie@microsoft.com>
lguohan pushed a commit that referenced this pull request Aug 6, 2021
@yxieca
[202012][utilities] advance sonic-utilities submodule head (#8355)
a21fdeb 
To include following changes:

* d84a8cc 2021-08-05 | [fast-reboot] revert the change of disabling counter polling before fast-reboot (#1744) (HEAD -> 202012, github/202012) [Ying Xie]
* e900bc5 2021-08-04 | Add script null_route_helper (#1718) [bingwang-ms]
* 85f14e1 2021-08-02 | disk_check updates: (#1736) [Renuka Manavalan]
* d68ac1c 2021-05-27 | [console][show] Force refresh all lines status during show line (#1641) [Blueve]
* a0e417f 2021-04-25 | [console] Display success message after line cleared (#1579) [Blueve]
* 0c6bb27 2021-04-07 | [console] Include Flow Control status in show line result (#1549) [Blueve]
judyjoseph added a commit that referenced this pull request Aug 7, 2021
@judyjoseph
Update sonic-utilities submodule
eee50a1 
8b149a3 Load the  database global_db only once for show cli  (#1712)
cd0e560 [config][interface][speed] Fixed the config interface speed in multiasic issue (#1739)
b595ba6 [fast-reboot] revert the change of disabling counter polling before fast-reboot (#1744)
8518820 [minigraph] Donot enable PFC watchdog for MgmtTsToR (#1734)
2213774 [CLI][show][bgp] Fix the show ip bgp network command (#1733)
3526507 [configlet] Python3 compatible syntax for extracting a key from the dict (#1721)
5b56b97 [sonic_installer] don't print errors when installing an image not supporting app ext (#1719)
a581955 [LLDP] Fix lldpshow script to enable display multiple MAC addresses on the same remote physical interface (#1657)
lguohan pushed a commit that referenced this pull request Aug 7, 2021
@yxieca
[utilities] advance utilities submodule head (#8356)
6b4fe48 
Advance utilities submodule head to include:
* b540f5f 2021-08-05 | [fast-reboot] revert the change of disabling counter polling before fast-reboot (#1744) (HEAD -> master, github/master) [Ying Xie]

Signed-off-by: Ying Xie <ying.xie@microsoft.com>
carl-nokia pushed a commit to carl-nokia/sonic-buildimage that referenced this pull request Aug 7, 2021
@volodymyrsamotiy
[swss] Update submodule pointer (sonic-net#7748)
9813e35 
dad1287 [tunneldecaporch] Set default MTU for the overlay loopback interface (sonic-net#1756)
1bc94d1 [orchagent] Fix typo in PortsOrch::initPortSupportedSpeeds (sonic-net#1755)
a44e651 [nhg]: Add support for weight in nexthop group member. (sonic-net#1752)
5c625b2 [Bulk mode] Limit the size of bulker (sonic-net#1744)
d1cd0fd Fix error msg due to not supported "SAI_SWITCH_ATTR_MAX_NUMBER_OF_TEMP_SENSORS"  attributes (sonic-net#1745)
278770d [sub intf] Fix kernel side processing to enslave sub interface to non-default vrf (sonic-net#1521)
031f536 support flush FDB entries per port and per vlan (sonic-net#1064)
3629d70 [sonic-swss] Add port auto negotiation support to swss (sonic-net#1714)
7c6ebb1 [fix] Use the same storm detection condition for queue occupancy non-zero case as the zero case (sonic-net#1111)
fb06c32 [fabricportsorch] Add fabric support (sonic-net#1459)

Signed-off-by: Volodymyr Samotiy <volodymyrs@nvidia.com>
carl-nokia pushed a commit to carl-nokia/sonic-buildimage that referenced this pull request Aug 7, 2021
@yxieca
[utilities] advance utilities submodule head (sonic-net#8356)
26f01d7 
Advance utilities submodule head to include:
* b540f5f 2021-08-05 | [fast-reboot] revert the change of disabling counter polling before fast-reboot (sonic-net#1744) (HEAD -> master, github/master) [Ying Xie]

Signed-off-by: Ying Xie <ying.xie@microsoft.com>
theasianpianist pushed a commit to theasianpianist/sonic-buildimage that referenced this pull request Feb 5, 2022
@shi-su
[Bulk mode] Limit the size of bulker (sonic-net#1744)
5c625b2 
What I did
Limit the size of the bulker.

Why I did it
Without a constraint on the size of bulkers, the bulked operation may take longer than the SAI timeout to finish. Such behavior would result in errors and swss crashes. This PR limits the bulk size and avoids SAI timeout in bulk mode.
taras-keryk pushed a commit to taras-keryk/sonic-buildimage that referenced this pull request Apr 28, 2022
@yxieca
[fast-reboot] revert the change of disabling counter polling before f…
b540f5f 
…ast-reboot (sonic-net#1744)

What I did
The change being removed was introduced with PR#1174 with the condition that flex counter polling will be enabled in the boot up path unconditionally. However, a change was made to enable_counters.py to only enable counters when the configuration is missing (sonic-buildimage PR#7735). After the later change, the disabled flex counters will not be enabled when fast-reboot into the same image.

How to verify it
run fast-reboot test and snmp test, without the fix, the snmp test would fail. With the fix, the snmp test passes.

Signed-off-by: Ying Xie ying.xie@microsoft.com
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lguohan lguohan lguohan approved these changes

@jleveque jleveque jleveque approved these changes

@yxieca yxieca yxieca approved these changes

Assignees
No one assigned
Labels
Bug 🐛
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@stcheng @lguohan @jleveque @yxieca