Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for platforms based on Barefoot Networks' device #1796

Merged
merged 170 commits into from
Jul 24, 2018

Conversation

mkbalani
Copy link
Contributor

@mkbalani mkbalani commented Jun 18, 2018

**- Incorporate support for platforms based on Barefoot Networks' device **

**- Added port config files and related scripts for the platforms **

**- Verified using SONiC tests (requires the corresponding changes to sairedis and swss) **

p4 barefoot

wadelnn and others added 30 commits October 5, 2017 09:28
Signed-off-by: Wade He <chihen.he@gmail.com>
Signed-off-by: Wade He <chihen.he@gmail.com>
1. Update sensors.conf.
2. Fixed IO expander init.
3. Fixed PSU EEPROM.
4. Fixed MB EEPROM.
5. Add fancontrol and fan init.
6. Add SYS LED control (sys, fan, fan tray).
7. 2.5V compute and setup max and min.
8. Fixed typo MB eeprom delete address.
9. Remove coretemp to BMC.
10. Add active CPLD.
11. Modify SFP+ GPIO slave address.
12. Modify tmp75 Near Port 32 slave address.

Signed-off-by: Wade He <chihen.he@gmail.com>
Signed-off-by: Wade He <chihen.he@gmail.com>
Signed-off-by: Wade He <chihen.he@gmail.com>
Signed-off-by: Wade He <chihen.he@gmail.com>
1. Fixed ignore sensors Vbat.
2. Reorg hwmon order.

Signed-off-by: Wade He <chihen.he@gmail.com>
Signed-off-by: Wade He <chihen.he@gmail.com>
* Fixed blink LED mask set error.

Signed-off-by: Wade He <chihen.he@gmail.com>
* This will break fast reboot as killall is required for killing bgp process and initiating graceful termination of BGP session.
Will fix this in a seperate PR. Need this for SONIC upstreaming
@mkbalani
Copy link
Contributor Author

@lguohan It seems the vs build job is still somehow using an old refpoint for swss. From the PR diff here swss-ref
I can see that the refpoint is correctly dcf6c, however the jenkins build shows below error > assert len(keys) == 1 E AssertionError: assert 3 == 1 E + where 3 = len(('oid:0x700000000058a', 'oid:0x700000000058f', 'oid:0x700000000058e')) which should not be seen with this refpoint

@lguohan
Copy link
Collaborator

lguohan commented Jul 16, 2018

retest this please

@@ -0,0 +1,57 @@
# Automatically added by dh_systemd_enable
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think this is automatically added by debian, remove from the check-in.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed file

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BFN build break after removing this file. Adding it back for now. We shall have ingrasys folk review them and update accordingly

@@ -0,0 +1,4 @@
lib/systemd/
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think this is automatically added by debian, remove from the check-in.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed file

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same comment as above

@@ -0,0 +1,4 @@
usr/sbin
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think this is automatically added by debian, remove from the check-in.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed file

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same comment as above

@@ -0,0 +1,42 @@
# Automatically added by dh_systemd_start
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think this is automatically added by debian, remove from the check-in.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed file

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same comment as above

@@ -0,0 +1,21 @@
# Automatically added by dh_systemd_start
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this file is automatically added by debian, remove from the check-in.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed file

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BFN build break after removing this file. Adding it back for now. We shall have ingrasys folk review them and update accordingly

@lguohan
Copy link
Collaborator

lguohan commented Jul 16, 2018

retest this please

@mkbalani
Copy link
Contributor Author

retesting build and fixes

@mkbalani
Copy link
Contributor Author

@lguohan BTW azure swss master is still pointing to 762e7da, rather than dcf6c, because of which vs job is failing I think.

* Remove bmc interface from interface jinja template and sample output interfaces file
* Add bmc interface at boot time to network interfaces for bfn bmc based platforms
Address upstream comments for usb0 interface
Remove autogen ingrasys debian files
Revert "Remove autogen ingrasys debian files"
SWI-1509 Buffer and qos config template fix for bfn platforms
@lguohan
Copy link
Collaborator

lguohan commented Jul 23, 2018

retest this please

* Reference only ppg 3,4 in qos files as no profiles are attached to 0,1 in buffer configs
@lguohan
Copy link
Collaborator

lguohan commented Jul 24, 2018

can you fix the vs test by below patch.

diff --git a/platform/vs/tests/conftest.py b/platform/vs/tests/conftest.py
index 9256597..48ad7e1 100644
--- a/platform/vs/tests/conftest.py
+++ b/platform/vs/tests/conftest.py
@@ -54,8 +54,21 @@ class AsicDbValidator(object):
         atbl = swsscommon.Table(self.adb, "ASIC_STATE:SAI_OBJECT_TYPE_ACL_TABLE")
         keys = atbl.getKeys()
 
-        assert len(keys) == 1
-        self.default_acl_table = keys[0]
+        assert len(keys) >= 1
+        # Filter out DTel Acl tables
+        default_table_found = False
+        for k in keys:
+            if default_table_found:
+                break
+            (status, fvs) = atbl.get(k)
+            for item in fvs:
+                if item[0] == "SAI_ACL_TABLE_ATTR_ACL_BIND_POINT_TYPE_LIST":
+                    if 'SAI_ACL_BIND_POINT_TYPE_PORT' in item[1]:
+                        self.default_acl_table = k
+                        default_table_found = True
+                        break
+                    else:
+                        break
 
         atbl = swsscommon.Table(self.adb, "ASIC_STATE:SAI_OBJECT_TYPE_ACL_ENTRY")
         keys = atbl.getKeys()

@lguohan
Copy link
Collaborator

lguohan commented Jul 24, 2018

retest this please

@lguohan lguohan merged commit 93905d3 into sonic-net:master Jul 24, 2018
vivekrnv added a commit to vivekrnv/sonic-buildimage that referenced this pull request Nov 16, 2021
…t#1796)

efa2ff6 [show][platform summary] Add chassis type in the platform summary output(sonic-net#1922)
a39350c [aclshow] enhance ACL counters to work with FC infrastructure (sonic-net#1858)
ed88013 [sonic-package-manager] fix registry requests failing when no service field in Bearer fields (sonic-net#1921)
00b6045 [VS test] Increase test timeout (sonic-net#1924)

Signed-off-by: Vivek Reddy Karri <vkarri@nvidia.com>
qiluo-msft pushed a commit that referenced this pull request Nov 22, 2021
a3e34e3 [Auto Techsupport] Event driven Techsupport Changes (#1796)
efa2ff6 [show][platform summary] Add chassis type in the platform summary output(#1922)
a39350c [aclshow] enhance ACL counters to work with FC infrastructure (#1858)
ed88013 [sonic-package-manager] fix registry requests failing when no service field in Bearer fields (#1921)
00b6045 [VS test] Increase test timeout (#1924)
taras-keryk pushed a commit to taras-keryk/sonic-buildimage that referenced this pull request Apr 28, 2022
#### What I did

sonic-utilities changes required for feature "Event Driven TechSupport Invocation & CoreDump Mgmt". [HLD](sonic-net/SONiC#818 )

Summary of the changes:

- Added the AUTO GEN CLI for the CFG DB tables required for this feature
- Added the coredump_gen_handler.py & techsupport_cleanup.py scripts.
- Added the UT's required for these scripts.
- Enhanced coredump-compress & generate-dump scripts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.