Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pycparser installation #1820

Merged
merged 2 commits into from
Jun 29, 2018
Merged

Conversation

qiluo-msft
Copy link
Collaborator

Signed-off-by: Qi Luo <qiluo-msft@users.noreply.github.com>
@@ -29,7 +29,8 @@ RUN apt-get install -y default-jre
RUN apt-get install -y rsyslog psmisc

# Remove cffi 1.5.2, will install 1.10.0 by pip later
RUN apt-get remove -y python-cffi python-cffi-backend
# Remove pycparser 2.14, will install >=2.17 by pip later
RUN apt-get remove -y python-cffi python-cffi-backend python-ply python-pycparser
Copy link
Contributor

@jleveque jleveque Jun 28, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not separate into two apt-get remove calls for posterity's sake?

# Remove cffi 1.5.2, will install 1.10.0 by pip later
RUN apt-get remove -y python-cffi python-cffi-backend

# Remove pycparser 2.14, will install >=2.17 by pip later
RUN apt-get remove -y python-ply python-pycparser
``` #Resolved

Signed-off-by: Qi Luo <qiluo-msft@users.noreply.github.com>
@qiluo-msft qiluo-msft merged commit 5ad7d24 into sonic-net:master Jun 29, 2018
@qiluo-msft qiluo-msft deleted the qiluo/fix-mgmt branch June 29, 2018 15:39
lguohan pushed a commit that referenced this pull request Apr 30, 2019
stephenxs added a commit to stephenxs/sonic-buildimage that referenced this pull request Jul 29, 2021
f54b7d0b [Dynamic Buffer Calc][202012]Bug fix: Don't create lossless buffer profile for active ports without speed configured (sonic-net#1820)
ac7f5cff Td2: Reclaim buffer from unused ports (sonic-net#1830)
04105a4b [debugcounterorch] check if counter type is supported before querying (sonic-net#1789)
a67d8af6 [202012][portsorch] fix errors when moving port from one lag to another. (sonic-net#1819)

Signed-off-by: Stephen Sun <stephens@nvidia.com>
dgsudharsan added a commit to dgsudharsan/sonic-buildimage that referenced this pull request Sep 15, 2021
92d0744 [config reload] Removed job-mode for sonic.target restart (sonic-net#1820)
c28fb22 [ci]: Support PR coverage (sonic-net#1806)
vivekrnv added a commit to vivekrnv/sonic-buildimage that referenced this pull request Sep 15, 2021
Signed-off-by: Vivek Reddy Karri <vkarri@nvidia.com>

ce11545 [config reload] Removed job-mode for sonic.target restart (sonic-net#1820)
f76f672 [fdbshow]: Fix typo in comment (sonic-net#1809)
17208a0 [ci]: Support PR coverage (sonic-net#1806)
c2c2354 fix wrong code indent in sfputil (sonic-net#1808)
47a9a0f [portconfig] Validate duplicate speed value and interface type value (sonic-net#1745)
f1086ee [sonic_installer]Add --skip-platform-check option for sonic_installer when image mismatch (sonic-net#1791)
c007d65 [warm-reboot] Add new preboot health check: verify database integrity (sonic-net#1785)
41e31e8 Fix PatchApplier init order (sonic-net#1762)
qiluo-msft pushed a commit that referenced this pull request Sep 16, 2021
Included Commits
92d0744 [config reload] Removed job-mode for sonic.target restart (#1820)
c28fb22 [ci]: Support PR coverage (#1806)
judyjoseph added a commit that referenced this pull request Sep 27, 2021
sonic-swss:

bb69ca2 [portsorch] Avoid orchagent crash when set invalid interface types to port (#1906)
6e1bacc [pfcwd] Fix the polling interval time granularity (#1912)
564785b [teammgrd]: Improve LAGs cleanup on shutdown: send SIGTERM directly to PID. (#1841)
7ee8d26 [tlm teamd] Add retry mechanism before logging the ERR in get_dumps. (#1629)
7f57d3d [fgnhgorch] Enable packet flow when no FG ECMP neighbors are resolved (#1900)
08d009f Mux state order change (#1902)

sonic-utilities:

1bc0f07 Provide support to install platform extensions (#1578)
968c781 [config reload] Removed job-mode for sonic.target restart (#1820)
qiluo-msft pushed a commit that referenced this pull request Sep 28, 2021
0d538d3 [ci]: Support code diff coverage (#1834)
48887d1 [config] support for configuring muxcable to standby mode of operation (#1837)
2088a9a Provide support to install platform extensions (#1578)
c97fe54 Add check_db_integrity script to setup.py (#1828)
c0b9917 [debug dump util] COPP Module Added (#1670)
826311c [techsupport] Removed interactive option for docker commands and Improved Error Reporting (#1723)
ce11545 [config reload] Removed job-mode for sonic.target restart (#1820)
f76f672 [fdbshow]: Fix typo in comment (#1809)
17208a0 [ci]: Support PR coverage (#1806)
c2c2354 fix wrong code indent in sfputil (#1808)
47a9a0f [portconfig] Validate duplicate speed value and interface type value (#1745)
f1086ee [sonic_installer]Add --skip-platform-check option for sonic_installer when image mismatch (#1791)
c007d65 [warm-reboot] Add new preboot health check: verify database integrity (#1785)
41e31e8 Fix PatchApplier init order (#1762)
2416175 [config reload] Fix config reload failure due to sonic.target job cancellation (#1814)
2b12aad [portstat, intfstat] added rates and utilization (#1750)
26e700a [debug dump util] Techsupport addition (#1669)
9f2326e [debug dump util] Base Skeleton and Click Class added (#1668)
taras-keryk pushed a commit to taras-keryk/sonic-buildimage that referenced this pull request Apr 28, 2022
…1820)

#### What I did

As discussed in this PR sonic-net/sonic-utilities#1814 (comment), only the stop.job should have job-mode set to replace irreversibly.

Otherwise,  simultaneous config reloads in the quick succession, can lead to the behavior.

Although ,when the restart job (and all the other dependent jobs) are finished and is taken out of systemd's job queue, the next stop job will not be cancelled.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Ansible Testbed Setup] Fail on build sonic-mgmt docker
2 participants