[sonic-utilities] Update submodule to support fast-reboot cause #1830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephenxs
added a commit
to stephenxs/sonic-buildimage
that referenced
this pull request
Jul 29, 2021
f54b7d0b [Dynamic Buffer Calc][202012]Bug fix: Don't create lossless buffer profile for active ports without speed configured (sonic-net#1820) ac7f5cff Td2: Reclaim buffer from unused ports (sonic-net#1830) 04105a4b [debugcounterorch] check if counter type is supported before querying (sonic-net#1789) a67d8af6 [202012][portsorch] fix errors when moving port from one lag to another. (sonic-net#1819) Signed-off-by: Stephen Sun <stephens@nvidia.com>
stephenxs
added a commit
to stephenxs/sonic-buildimage
that referenced
this pull request
Jul 29, 2021
237b89c [Dynamic Buffer Calc] Bug fix: Don't create lossless buffer profile for active ports without speed configured (sonic-net#1822) ec104c1 [gearbox] Set context for phys based on configs (sonic-net#1826) 7f80f06 Td2: Reclaim buffer from unused ports (sonic-net#1830) 0fe2dfe [VS] Fix for VS test failures (sonic-net#1836) c81e319 refactor(fdbsyncd): Convert files with dos2unix (sonic-net#1828) c805021 [configure.ac] Add the option of passing libnl path to configure script (sonic-net#1824) ed6786d 9f0bb8d [swss]: Allow portsyncd to run on system without ports (sonic-net#1808) 5d97b05 Update MACsec SA PN counter to support SAI API 1.8 (sonic-net#1818) 64e33b3 Ignore ALREADY_EXIST error in FDB creation (sonic-net#1815) Signed-off-by: Stephen Sun <stephens@nvidia.com>
prsunny
pushed a commit
that referenced
this pull request
Jul 30, 2021
sairedis: *[recorder] Fix incorrect attribute enum value capability query (#843) d86b051 *[syncd] Fix fdb flood queue size limit check (#863) 3a2af76 *[vslib] implement query for SAI_DEBUG_COUNTER_TYPE enum values (#842) 575dcb4 swss: *[portsorch] fix errors when moving port from one lag to anoth… a67d8af *[debugcounterorch] check if counter type is supported before querying… ( 04105a4 *Td2: Reclaim buffer from unused ports (#1830) ac7f5cf *[Dynamic Buffer Calc][202012]Bug fix: Don't create lossless buffer pr… f54b7d0 Signed-off-by: Nazarii Hnydyn <nazariig@nvidia.com>
judyjoseph
added a commit
that referenced
this pull request
Aug 18, 2021
0dcb2b6 Open record file in append mode (#1845) 03ce2ee [vnet/vxlan] Add support of multiple mappers for the VxLAN tunnel (#1843) c5e90ab VOQ: Nexthop for remote VOQ LC should be created on inband OIF. (#1823) 834c5c8 Td2: Reclaim buffer from unused ports (#1830) a5ad55c [Dynamic Buffer Calc] Bug fix: Don't create lossless buffer profile for active ports without speed configured (#1822) f50368f [cfgmgr] Update Makefile.am to consume lib zmq (#1865)
theasianpianist
pushed a commit
to theasianpianist/sonic-buildimage
that referenced
this pull request
Feb 5, 2022
Signed-off-by: Neetha John <nejo@microsoft.com> By default, lossless profiles are attached to PGs 3, 4 of all ports which results in a lot of buffer wastage when most of those ports are unused (not associated with a DEVICE_NEIGHBOR). In TD2, ingress pool size comprises of the reserved space as well. Hence making use of a special cable length of '0m' to identify unused ports and skip reserving space for those ports What I did * In buffermgr, if port with cable len '0m' is identified, return immediately without creating pg lossless profile or attaching profile to the lossless pgs of that port * Listen to 'admin_status' update as well from the PORT table and update port-speed mapping. This is to handle add-rack scenario where a port is added later - The port starts of with cable length 0m - Configlet to add a port is applied. The order of operations specifc to the PORT/CABLE_LENGTH table are - port is initially set to admin down, cable length is updated for that port, port table attributes are defined and port is set to admin up - speed update might not be seen when the port is set to admin up. Hence port-speed mapping will capture the speed update whenever its seen and once the cable length is updated while the port is brought back up, profiles can be attached to the lossless pgs of the port How I verified it - Manual tests done. Verified that no space is reserved for unused ports - Verified that when a port is added using 'add-rack' scenario, profile is attached to pgs of that port - New VS test added
taras-keryk
pushed a commit
to taras-keryk/sonic-buildimage
that referenced
this pull request
Apr 28, 2022
sonic-net#1831) #### What I did Fixing issue sonic-net#1830 #### How I did it Problem we consume the function `loadData` from sonic-yang-mgmt pkg that always crops tables without YANG models from configdb json object. It does it as a side-effect and is not an expected outcome of the function. The fix here is to crop the current/target tables before doing any sorting, this way gurantee we avoid this bug. I think the better soln is to fix sonic-yang-mgmt pkg. Will look into this more next week. #### How to verify it Run the command in the issue, it will result in the expected outcome #### Previous command output (if the output of a command-line utility has changed) #### New command output (if the output of a command-line utility has changed)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sonic-utilities commits include: