[Mellanox][Smartswitch] Add no_wait option for dpu reboot and add platform information parsing #20943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
oleksandrivantsiv
approved these changes
Dec 2, 2024
prgeor
reviewed
Dec 2, 2024
| @@ -169,23 +189,32 @@ def get_open_fd(self, path, flag): | |||
| finally: | |||
| os.close(fd) | |||
|
|
|||
| def get_pci_dev_path(self): | |||
There was a problem hiding this comment.
@gpunathilell any specific reason why this PCI remove could not be done in common code? @vvolam fyi
There was a problem hiding this comment.
we discussed this at the meeting. We have an extra dependency on the rshim here. Before removing PCI we need to stop rshim. After rescaning the PCI we need to start the rshim. Common code can't cover this.
liat-grozovik
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
Changes for
dpuctlplat.py:Work item tracking
How I did it
Changed
dpuctlplat.pyto support systemctl commands from pmon container using the dbus-send commandHow to verify it
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)