-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Mellanox][Smartswitch] Platform API for Smartswtich #20944
Conversation
Returns: | ||
An integer, the number of modules available on this chassis | ||
""" | ||
return DeviceDataManager.get_dpu_count() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to be returning only DPUs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, only the DPUs are represented as modules, the switch itself is not a module
Dependent on for mellanox build to pass #20943 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
@gpunathilell Please check the build errors. |
/azpw run |
/azpw run Azure.sonic-buildimage |
/azpw run |
/azpw run Azure.sonic-buildimage |
/AzurePipelines run Azure.sonic-buildimage |
Azure Pipelines successfully started running 1 pipeline(s). |
@kperumalbfn can we merge this? |
logger.log_error(f"Failed to check midplane reachability for {self.get_name()}! {e}") | ||
return False | ||
|
||
def get_midplane_interface(self): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gpunathilell Do we have any new sonic-mgmt tests?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is vendor API implementation for Smart Switch PMON: https://github.com/sonic-net/SONiC/blob/master/doc/smart-switch/pmon/smartswitch-pmon.md
The test for the feature will be contributed by Cisco, who is working on the feature implementation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @oleksandrivantsiv
Should be merged after #20943
Why I did it
Introduction of
SmartSwitchChassis
,DpuModule
classes for APIs required for Smartswitch PMONmodule.py
- Introduction ofDpuModule
for representing each DPU as a moduleplatform.py
- InitializeSmartSwitchChassis
based on number of DPUs on platformchassis.py
- Introduction ofSmartSwitchChassis
for representing each the smartswitch as a modular chassis with DPUS presentWork item tracking
How I did it
How to verify it
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)