Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[config engine] update test_cfggen test_port_description test #2593

Merged
merged 1 commit into from
Feb 21, 2019
Merged

[config engine] update test_cfggen test_port_description test #2593

merged 1 commit into from
Feb 21, 2019

Conversation

mykolaf
Copy link
Collaborator

@mykolaf mykolaf commented Feb 21, 2019 •
edited
Loading

Signed-off-by: Mykola Faryma mykolaf@mellanox.com

test_port_description was introduced around the time #2481 was merged. The expected output for it changed. This causes build failure.

- What I did

- How I did it

- How to verify it

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

[config engine] update test_cfggen test_port_description test
5cceb86 
Signed-off-by: Mykola Faryma <mykolaf@mellanox.com>
@mykolaf mykolaf requested a review from lguohan February 21, 2019 11:08
@liat-grozovik liat-grozovik merged commit b86dc06 into sonic-net:master Feb 21, 2019
@yxieca
Copy link
Contributor

yxieca commented Feb 21, 2019

Made to 201811 branch on 2/21/2019 (addressing build test failure).

yxieca pushed a commit that referenced this pull request Feb 21, 2019
@mykolaf @yxieca
[config engine] update test_cfggen test_port_description test (#2593)
797b21e 
Signed-off-by: Mykola Faryma <mykolaf@mellanox.com>
@mykolaf mykolaf mentioned this pull request Feb 26, 2019
Merged
tiantianlv pushed a commit to SONIC-DEV/sonic-buildimage that referenced this pull request Apr 10, 2019
@mykolaf @tiantianlv
[config engine] update test_cfggen test_port_description test (sonic-…
cc81419 
…net#2593)

Signed-off-by: Mykola Faryma <mykolaf@mellanox.com>
tiantianlv pushed a commit to SONIC-DEV/sonic-buildimage that referenced this pull request Apr 10, 2019
@mykolaf @tiantianlv
[config engine] update test_cfggen test_port_description test (sonic-…
374aa33 
…net#2593)

Signed-off-by: Mykola Faryma <mykolaf@mellanox.com>
tiantianlv pushed a commit to SONIC-DEV/sonic-buildimage that referenced this pull request Apr 10, 2019
@mykolaf @tiantianlv
[config engine] update test_cfggen test_port_description test (sonic-…
e9a2d95 
…net#2593)

Signed-off-by: Mykola Faryma <mykolaf@mellanox.com>
@mykolaf mykolaf deleted the ce_test branch March 3, 2020 16:10
@Junchao-Mellanox Junchao-Mellanox mentioned this pull request Jan 30, 2023
Closed
dprital added a commit to dprital/sonic-buildimage that referenced this pull request Jan 30, 2023
@dprital
[submodule] Advance sonic-swss pointer
78f8d99 
Update sonic-swss submodule pointer to include the following:
* a2a483d [acl] Add new ACL key BTH_OPCODE and AETH_SYNDROME  ([sonic-net#2617](sonic-net/sonic-swss#2617))
* 9d1f66b [bfdorch] add local discriminator to state DB ([sonic-net#2629](sonic-net/sonic-swss#2629))
* c54b3d1 Vxlan tunnel endpoint custom monitoring APPL DB table. ([sonic-net#2589](sonic-net/sonic-swss#2589))
* 7f03db2 Fix potential risks ([sonic-net#2516](sonic-net/sonic-swss#2516))
* 383ee68 [refactor]Refactoring sai handle status ([sonic-net#2621](sonic-net/sonic-swss#2621))
* cd95972 Fix issue 13341 ARP entry can be out of sync between kernel and APPL_DB if multiple updates are received from RTNL ([sonic-net#2619](sonic-net/sonic-swss#2619))
* a01470f Remove TODO comments that are no longer relevant ([sonic-net#2622](sonic-net/sonic-swss#2622))
* d058390 Changed the BFD default detect multiplier to 10x ([sonic-net#2614](sonic-net/sonic-swss#2614))
* d78b528 [MuxOrch] Enabling neighbor when adding in active state ([sonic-net#2601](sonic-net/sonic-swss#2601))
* 4ebdad1 [routesync] Fix for stale dynamic neighbor ([sonic-net#2553](sonic-net/sonic-swss#2553))
* 8857f92 Added new attributes for Vnet and Vxlan ecmp configurations. ([sonic-net#2584](sonic-net/sonic-swss#2584))
* b6bbc3e Revert [voq][chassis]Add show fabric counters port/queue commands (2522) ([sonic-net#2611](sonic-net/sonic-swss#2611))
* 52406e2 Add missing parameter to on_switch_shutdown_request method. ([sonic-net#2567](sonic-net/sonic-swss#2567))
* 4ac9ad9 Increase diff coverage to 80% ([sonic-net#2599](sonic-net/sonic-swss#2599))
* 8a0bb36 Handle Mac address 'none' ([sonic-net#2593](sonic-net/sonic-swss#2593))
* f496ab3 [vstest] Only collect stdout of orchagent_restart_check in vstest ([sonic-net#2597](sonic-net/sonic-swss#2597))
* 1dab495 Avoid aborting orchagent when setting TUNNEL attributes ([sonic-net#2591](sonic-net/sonic-swss#2591))
* 4395cea Fix neighbor doesn't update all attribute ([sonic-net#2577](sonic-net/sonic-swss#2577))

Signed-off-by: dprital <drorp@nvidia.com>
liat-grozovik pushed a commit that referenced this pull request Feb 1, 2023
@dprital
[submodule] Advance sonic-swss pointer (#13551)
4c3aafc 
Update sonic-swss submodule pointer to include the following:
* a2a483d [acl] Add new ACL key BTH_OPCODE and AETH_SYNDROME  ([#2617](sonic-net/sonic-swss#2617))
* 9d1f66b [bfdorch] add local discriminator to state DB ([#2629](sonic-net/sonic-swss#2629))
* c54b3d1 Vxlan tunnel endpoint custom monitoring APPL DB table. ([#2589](sonic-net/sonic-swss#2589))
* 7f03db2 Fix potential risks ([#2516](sonic-net/sonic-swss#2516))
* 383ee68 [refactor]Refactoring sai handle status ([#2621](sonic-net/sonic-swss#2621))
* cd95972 Fix issue 13341 ARP entry can be out of sync between kernel and APPL_DB if multiple updates are received from RTNL ([#2619](sonic-net/sonic-swss#2619))
* a01470f Remove TODO comments that are no longer relevant ([#2622](sonic-net/sonic-swss#2622))
* d058390 Changed the BFD default detect multiplier to 10x ([#2614](sonic-net/sonic-swss#2614))
* d78b528 [MuxOrch] Enabling neighbor when adding in active state ([#2601](sonic-net/sonic-swss#2601))
* 4ebdad1 [routesync] Fix for stale dynamic neighbor ([#2553](sonic-net/sonic-swss#2553))
* 8857f92 Added new attributes for Vnet and Vxlan ecmp configurations. ([#2584](sonic-net/sonic-swss#2584))
* b6bbc3e Revert [voq][chassis]Add show fabric counters port/queue commands (2522) ([#2611](sonic-net/sonic-swss#2611))
* 52406e2 Add missing parameter to on_switch_shutdown_request method. ([#2567](sonic-net/sonic-swss#2567))
* 4ac9ad9 Increase diff coverage to 80% ([#2599](sonic-net/sonic-swss#2599))
* 8a0bb36 Handle Mac address 'none' ([#2593](sonic-net/sonic-swss#2593))
* f496ab3 [vstest] Only collect stdout of orchagent_restart_check in vstest ([#2597](sonic-net/sonic-swss#2597))
* 1dab495 Avoid aborting orchagent when setting TUNNEL attributes ([#2591](sonic-net/sonic-swss#2591))
* 4395cea Fix neighbor doesn't update all attribute ([#2577](sonic-net/sonic-swss#2577))

Signed-off-by: dprital <drorp@nvidia.com>
mihirpat1 pushed a commit to mihirpat1/sonic-buildimage that referenced this pull request Jun 14, 2023
@prsunny
Handle Mac address 'none' (sonic-net#2593)
8a0bb36 
In some rare cases, kernel neighbor add notifications are received with Mac string as 'none'. Fixing this to prevent crash.
yxieca pushed a commit that referenced this pull request Nov 7, 2023
@mssonicbld
[submodule] Update submodule sonic-swss to the latest HEAD automatica…
6897543 
…lly (#17094)

src/sonic-swss

* 01bf3b19 - (HEAD -> 202205, origin/202205) [muxorch] Fixing updateRoute logic (#2950) (5 hours ago) [Nikola Dancejic]
* 1e264e01 - Handle Mac address 'none' (#2593) (9 hours ago) [Prince Sunny]
* dc0e29b4 - [202205][teamd]: Clean teamd process if LAG creation fails (#2888) (#2932) (4 days ago) [Lawrence Lee]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liat-grozovik liat-grozovik liat-grozovik approved these changes

@nazariig nazariig nazariig approved these changes

@lguohan lguohan Awaiting requested review from lguohan

Assignees
No one assigned
Labels
Bug 🐛 Included in 201811 Branch Request for 201811 Branch :shipit:
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mykolaf @yxieca @nazariig @liat-grozovik