[minigraph] asymmetric pfc is disabled by default #2481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
volodymyrsamotiy
approved these changes
Jan 28, 2019
liat-grozovik
approved these changes
Jan 30, 2019
mykolaf
force-pushed
the
pfc_asym
branch
2 times, most recently
from
fb37613
to
d3bd2e1
Compare
Signed-off-by: Mykola Faryma <mykolaf@mellanox.com> Conflicts: src/sonic-config-engine/tests/sample_output/ports.json src/sonic-config-engine/tests/test_cfggen.py
|
@stcheng could you please take a look? |
|
@lguohan could you please review? this is a fix i believe should go to 201811 branch as well. |
|
Made to 201811 branch on 2/21/2019 |
yxieca
pushed a commit
that referenced
this pull request
Feb 21, 2019
Signed-off-by: Mykola Faryma <mykolaf@mellanox.com> Conflicts: src/sonic-config-engine/tests/sample_output/ports.json src/sonic-config-engine/tests/test_cfggen.py
|
I get a compile error on test_minigraph_port_description where this seems to be expected too, also the order of keys is not aggreeing with assertEqual: FAIL: test_minigraph_port_description (test_cfggen.TestCfgGen)Traceback (most recent call last): |
|
Hi @MichelMoriniaux, check this out #2593 |
|
cool! |
tiantianlv
pushed a commit
to SONIC-DEV/sonic-buildimage
that referenced
this pull request
Apr 10, 2019
Signed-off-by: Mykola Faryma <mykolaf@mellanox.com> Conflicts: src/sonic-config-engine/tests/sample_output/ports.json src/sonic-config-engine/tests/test_cfggen.py
tiantianlv
pushed a commit
to SONIC-DEV/sonic-buildimage
that referenced
this pull request
Apr 10, 2019
Signed-off-by: Mykola Faryma <mykolaf@mellanox.com> Conflicts: src/sonic-config-engine/tests/sample_output/ports.json src/sonic-config-engine/tests/test_cfggen.py
tiantianlv
pushed a commit
to SONIC-DEV/sonic-buildimage
that referenced
this pull request
Apr 10, 2019
Signed-off-by: Mykola Faryma <mykolaf@mellanox.com> Conflicts: src/sonic-config-engine/tests/sample_output/ports.json src/sonic-config-engine/tests/test_cfggen.py
dprital
added a commit
to dprital/sonic-buildimage
that referenced
this pull request
Oct 11, 2022
Update sonic-swss submodule pointer to include the following: * 08711a8 [orchdaemon]: Fixed sairedis record file rotation ([sonic-net#2481](sonic-net/sonic-swss#2481)) Signed-off-by: dprital <drorp@nvidia.com>
bacrossland
added a commit
to target/sonic-buildimage
that referenced
this pull request
Oct 24, 2022
Why I did it
Fix updated sonic-swss submodule which uses GMock for testing:
08711a8 [orchdaemon]: Fixed sairedis record file rotation (sonic-net#2481)
How I did it
Add install of GMock to Dockerfile.j2 in all Debian releases.
bacrossland
added a commit
to target/sonic-buildimage
that referenced
this pull request
Oct 24, 2022
Why I did it
Fix updated sonic-swss submodule which uses GMock for testing:
08711a8 [orchdaemon]: Fixed sairedis record file rotation (sonic-net#2481)
How I did it
Add install of GMock to Dockerfile.j2 in all Debian releases.
bacrossland
added a commit
to target/sonic-buildimage
that referenced
this pull request
Oct 24, 2022
Why I did it
Fix updated sonic-swss submodule which uses GMock for testing:
08711a8 [orchdaemon]: Fixed sairedis record file rotation (sonic-net#2481)
How I did it
Add install of GMock to Dockerfile.j2 in all Debian releases.
bacrossland
added a commit
to target/sonic-buildimage
that referenced
this pull request
Oct 24, 2022
Why I did it
Fix updated sonic-swss submodule which uses GMock for testing:
08711a8 [orchdaemon]: Fixed sairedis record file rotation (sonic-net#2481)
How I did it
Add install of GMock to Dockerfile.j2 in all Debian releases.
bacrossland
added a commit
to target/sonic-buildimage
that referenced
this pull request
Oct 24, 2022
Why I did it
Fix updated sonic-swss submodule which uses GMock for testing:
08711a8 [orchdaemon]: Fixed sairedis record file rotation (sonic-net#2481)
How I did it
Add install of GMock to Dockerfile.j2 in all Debian releases.
liat-grozovik
pushed a commit
that referenced
this pull request
Oct 26, 2022
Update sonic-swss submodule pointer to include the following: * 08711a8 [orchdaemon]: Fixed sairedis record file rotation ([#2481](sonic-net/sonic-swss#2481)) Signed-off-by: dprital <drorp@nvidia.com>
stephenxs
added a commit
to stephenxs/sonic-buildimage
that referenced
this pull request
Nov 22, 2022
72b9cf9 [psushow & psuutil] Support PSU power threshold checking (sonic-net#2326) dfdc92e Revert "Support the bandit check by GitHub Action (sonic-net#2358)" (sonic-net#2509) 85638b2 YANG Validation for ConfigDB Updates: DEVICE_METADATA, SNMP, SNMP_COMMUNITY tables (sonic-net#2481) da44d71 YANG Validation for ConfigDB Updates: PORT_STORM_CONTROL, PORT_QOS_MAP, BUFFER_PROFILE, BUFFER_PG, BUFFER_QUEUE, BUFFER_POOL, FEATURE, DEFAULT_LOSSLESS_BUFFER_PARAMETER tables (# ba9b628 [sfp] Fix issue: Application Advertisement is not well formatted (sonic-net#2491) Signed-off-by: Stephen Sun <stephens@nvidia.com>
prgeor
pushed a commit
that referenced
this pull request
Nov 23, 2022
#12791) * Update submodule sonic-utilities 72b9cf9 [psushow & psuutil] Support PSU power threshold checking (#2326) dfdc92e Revert "Support the bandit check by GitHub Action (#2358)" (#2509) 85638b2 YANG Validation for ConfigDB Updates: DEVICE_METADATA, SNMP, SNMP_COMMUNITY tables (#2481) da44d71 YANG Validation for ConfigDB Updates: PORT_STORM_CONTROL, PORT_QOS_MAP, BUFFER_PROFILE, BUFFER_PG, BUFFER_QUEUE, BUFFER_POOL, FEATURE, DEFAULT_LOSSLESS_BUFFER_PARAMETER tables (# ba9b628 [sfp] Fix issue: Application Advertisement is not well formatted (#2491) Signed-off-by: Stephen Sun <stephens@nvidia.com> * Update submodule sonic-platform-daemons ed818f8 [PSU daemon] Support PSU power threshold checking (#288) 707a720 [chassisd] update chassisd to write fabric and lc asics on sep erate table (#311) e8c5657 [ycabled] fix exception-handling logic for ycabled (#306) 905874d [ycabled] move swsscommon API's from subroutines to call them exactly once per task_worker/thread (#303) 510d330 Fix typo in xcvrd (#313) 9ae551f [ycabled] add support for detach mode in 'active-active' topology (#309) 82fc7a6 Added filtering logic to send filtered fields from DB event (#307) 8a2dad9 [ycabled] fix no port/state returned by grpc server (#308) 4ea12cf Fix xcvrd to support 400G ZR optic (#293) 23b6970 [ycabled] fix naming error for error condition for CLI handling (#302) 501abb2 [ycabled] add some exception catching logic to some vendor specific API's (#301) 534f839 [ycabled] add support for getting grpc secerts via shared file (#298) 3622aac Remove shell=True (#300) 143422b add support to execute new ycable API's, add datetime field to mux_info (#297) 6522c46 [ycabled] add notification for gRPC connection state transitions to IDLE/TRANSIENT_FAILURE (#295) 4b3b238 Install libyang to azure pipeline (#292) 8ff5f37 Use get() to fetch default value from dictionary for port admin_status #286 b03cc74 [Xcvrd] Soak duplicate events and process only updated interested events (#285) 3acb171 [ycable] cleanup logic for creating grpc future ready (#289) ce3b6db [ycabled] fix insert events from xcvrd;cleanup some mux toggle logic (#287) Signed-off-by: Stephen Sun <stephens@nvidia.com> * Update submodule sonic-platform-common 7c48be2 Add warning/critical thresholds for PSU power (#304) f5ba0d0 Add missing PM and VDM related EEPROM read (#326) 02dd597 implement CMIS set_laser_freq to support 100GHz grid space (#294) Signed-off-by: Stephen Sun <stephens@nvidia.com> * Revert "Update submodule sonic-platform-daemons" This reverts commit aea648b. Signed-off-by: Stephen Sun <stephens@nvidia.com>
StormLiangMS
pushed a commit
to StormLiangMS/sonic-buildimage
that referenced
this pull request
Dec 8, 2022
sonic-net#12791) * Update submodule sonic-utilities 72b9cf9 [psushow & psuutil] Support PSU power threshold checking (sonic-net#2326) dfdc92e Revert "Support the bandit check by GitHub Action (sonic-net#2358)" (sonic-net#2509) 85638b2 YANG Validation for ConfigDB Updates: DEVICE_METADATA, SNMP, SNMP_COMMUNITY tables (sonic-net#2481) da44d71 YANG Validation for ConfigDB Updates: PORT_STORM_CONTROL, PORT_QOS_MAP, BUFFER_PROFILE, BUFFER_PG, BUFFER_QUEUE, BUFFER_POOL, FEATURE, DEFAULT_LOSSLESS_BUFFER_PARAMETER tables (# ba9b628 [sfp] Fix issue: Application Advertisement is not well formatted (sonic-net#2491) Signed-off-by: Stephen Sun <stephens@nvidia.com> * Update submodule sonic-platform-daemons ed818f8 [PSU daemon] Support PSU power threshold checking (sonic-net#288) 707a720 [chassisd] update chassisd to write fabric and lc asics on sep erate table (sonic-net#311) e8c5657 [ycabled] fix exception-handling logic for ycabled (sonic-net#306) 905874d [ycabled] move swsscommon API's from subroutines to call them exactly once per task_worker/thread (sonic-net#303) 510d330 Fix typo in xcvrd (sonic-net#313) 9ae551f [ycabled] add support for detach mode in 'active-active' topology (sonic-net#309) 82fc7a6 Added filtering logic to send filtered fields from DB event (sonic-net#307) 8a2dad9 [ycabled] fix no port/state returned by grpc server (sonic-net#308) 4ea12cf Fix xcvrd to support 400G ZR optic (sonic-net#293) 23b6970 [ycabled] fix naming error for error condition for CLI handling (sonic-net#302) 501abb2 [ycabled] add some exception catching logic to some vendor specific API's (sonic-net#301) 534f839 [ycabled] add support for getting grpc secerts via shared file (sonic-net#298) 3622aac Remove shell=True (sonic-net#300) 143422b add support to execute new ycable API's, add datetime field to mux_info (sonic-net#297) 6522c46 [ycabled] add notification for gRPC connection state transitions to IDLE/TRANSIENT_FAILURE (sonic-net#295) 4b3b238 Install libyang to azure pipeline (sonic-net#292) 8ff5f37 Use get() to fetch default value from dictionary for port admin_status sonic-net#286 b03cc74 [Xcvrd] Soak duplicate events and process only updated interested events (sonic-net#285) 3acb171 [ycable] cleanup logic for creating grpc future ready (sonic-net#289) ce3b6db [ycabled] fix insert events from xcvrd;cleanup some mux toggle logic (sonic-net#287) Signed-off-by: Stephen Sun <stephens@nvidia.com> * Update submodule sonic-platform-common 7c48be2 Add warning/critical thresholds for PSU power (sonic-net#304) f5ba0d0 Add missing PM and VDM related EEPROM read (sonic-net#326) 02dd597 implement CMIS set_laser_freq to support 100GHz grid space (sonic-net#294) Signed-off-by: Stephen Sun <stephens@nvidia.com> * Revert "Update submodule sonic-platform-daemons" This reverts commit aea648b. Signed-off-by: Stephen Sun <stephens@nvidia.com>
StormLiangMS
pushed a commit
that referenced
this pull request
Dec 10, 2022
#12791) * Update submodule sonic-utilities 72b9cf9 [psushow & psuutil] Support PSU power threshold checking (#2326) dfdc92e Revert "Support the bandit check by GitHub Action (#2358)" (#2509) 85638b2 YANG Validation for ConfigDB Updates: DEVICE_METADATA, SNMP, SNMP_COMMUNITY tables (#2481) da44d71 YANG Validation for ConfigDB Updates: PORT_STORM_CONTROL, PORT_QOS_MAP, BUFFER_PROFILE, BUFFER_PG, BUFFER_QUEUE, BUFFER_POOL, FEATURE, DEFAULT_LOSSLESS_BUFFER_PARAMETER tables (# ba9b628 [sfp] Fix issue: Application Advertisement is not well formatted (#2491) Signed-off-by: Stephen Sun <stephens@nvidia.com> * Update submodule sonic-platform-daemons ed818f8 [PSU daemon] Support PSU power threshold checking (#288) 707a720 [chassisd] update chassisd to write fabric and lc asics on sep erate table (#311) e8c5657 [ycabled] fix exception-handling logic for ycabled (#306) 905874d [ycabled] move swsscommon API's from subroutines to call them exactly once per task_worker/thread (#303) 510d330 Fix typo in xcvrd (#313) 9ae551f [ycabled] add support for detach mode in 'active-active' topology (#309) 82fc7a6 Added filtering logic to send filtered fields from DB event (#307) 8a2dad9 [ycabled] fix no port/state returned by grpc server (#308) 4ea12cf Fix xcvrd to support 400G ZR optic (#293) 23b6970 [ycabled] fix naming error for error condition for CLI handling (#302) 501abb2 [ycabled] add some exception catching logic to some vendor specific API's (#301) 534f839 [ycabled] add support for getting grpc secerts via shared file (#298) 3622aac Remove shell=True (#300) 143422b add support to execute new ycable API's, add datetime field to mux_info (#297) 6522c46 [ycabled] add notification for gRPC connection state transitions to IDLE/TRANSIENT_FAILURE (#295) 4b3b238 Install libyang to azure pipeline (#292) 8ff5f37 Use get() to fetch default value from dictionary for port admin_status #286 b03cc74 [Xcvrd] Soak duplicate events and process only updated interested events (#285) 3acb171 [ycable] cleanup logic for creating grpc future ready (#289) ce3b6db [ycabled] fix insert events from xcvrd;cleanup some mux toggle logic (#287) Signed-off-by: Stephen Sun <stephens@nvidia.com> * Update submodule sonic-platform-common 7c48be2 Add warning/critical thresholds for PSU power (#304) f5ba0d0 Add missing PM and VDM related EEPROM read (#326) 02dd597 implement CMIS set_laser_freq to support 100GHz grid space (#294) Signed-off-by: Stephen Sun <stephens@nvidia.com> * Revert "Update submodule sonic-platform-daemons" This reverts commit aea648b. Signed-off-by: Stephen Sun <stephens@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Mykola Faryma mykolaf@mellanox.com
- What I did
add generation of "pfc_asym" property for PORT. Asymmetric PFC is off by default.
- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)