Enable watermark stats polling by default #2603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Wenda Ni <wenni@microsoft.com>
lguohan
approved these changes
Feb 25, 2019
lguohan
approved these changes
Feb 25, 2019
pavel-shirshov
approved these changes
Mar 7, 2019
wendani
commented
Apr 16, 2019
| @@ -14,6 +14,8 @@ def enable_counters(): | |||
| enable_counter_group(db, 'PORT') | |||
| enable_counter_group(db, 'QUEUE') | |||
| enable_counter_group(db, 'PFCWD') | |||
| enable_counter_group(db, 'PG_WATERMARK') | |||
| enable_counter_group(db, 'QUEUE_WATERMARK') | |||
There was a problem hiding this comment.
Once the corresponding FLEX_COUNTER_GROUP_TABLE is enabled, CONFIG_DB will have the entry flow into it even if the saved config may not have the entry enlisted. In the warm-reboot case, Orch::bake() can detect the entry, and will populate the entry into m_toSync. The counter poll postponement will thus lose its purpose in the warm-reboot case. @pavel-shirshov
yxieca
pushed a commit
that referenced
this pull request
May 4, 2023
e86e275bf [201811] add bgpraw to show run all (#2603)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Wenda Ni wenni@microsoft.com
- What I did
- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)